2021-01-08 22:19:20 +00:00
|
|
|
<?php
|
|
|
|
|
|
|
|
|
|
namespace MediaWiki\Extension\DiscussionTools\Tests;
|
|
|
|
|
|
2021-01-28 17:19:52 +00:00
|
|
|
use Language;
|
2021-01-08 22:19:20 +00:00
|
|
|
use MediaWiki\Extension\DiscussionTools\CommentFormatter;
|
|
|
|
|
use MediaWiki\Extension\DiscussionTools\CommentParser;
|
2021-01-28 17:19:52 +00:00
|
|
|
use MediaWiki\User\UserIdentity;
|
|
|
|
|
use MWTimestamp;
|
2021-01-08 22:19:20 +00:00
|
|
|
|
|
|
|
|
class MockCommentFormatter extends CommentFormatter {
|
|
|
|
|
|
Change CommentParser into a service
Goal:
-----
To have a method like CommentParser::parse(), which just takes a node
to parse and a title and returns plain data, so that we don't need to
keep track of the config to construct a CommentParser object (the
required config like content language is provided by services) and
we don't need to keep that object around after parsing.
Changes:
--------
CommentParser.php:
* …is now a service. Constructor only takes services as arguments.
The node and title are passed to a new parse() method.
* parse() should return plain data, but I split this part to a separate
patch for ease of review: I49bfe019aa460651447fd383f73eafa9d7180a92.
* CommentParser still cheats and accesses global state in a few places,
e.g. calling Title::makeTitleSafe or CommentUtils::getTitleFromUrl,
so we can't turn its tests into true unit tests. This work is left
for future commits.
LanguageData.php:
* …is now a service, instead of a static class.
Parser.js:
* …is not a real service, but it's changed to behave in a similar way.
Constructor takes only the required config as argument,
and node and title are instead passed to a new parse() method.
CommentParserTest.php:
parser.test.js:
* Can be simplified, now that we don't need a useless node and title
to test internal methods that don't use them.
testUtils.js:
* Can be simplified, now that we don't need to override internal
ResourceLoader stuff just to change the parser config.
Change-Id: Iadb7757debe000025e52770ca51ebcf24ca8ee66
2022-02-19 02:43:21 +00:00
|
|
|
/**
|
|
|
|
|
* @var CommentParser
|
|
|
|
|
*/
|
|
|
|
|
public static $parser;
|
2021-01-08 22:19:20 +00:00
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* @return CommentParser
|
|
|
|
|
*/
|
Change CommentParser into a service
Goal:
-----
To have a method like CommentParser::parse(), which just takes a node
to parse and a title and returns plain data, so that we don't need to
keep track of the config to construct a CommentParser object (the
required config like content language is provided by services) and
we don't need to keep that object around after parsing.
Changes:
--------
CommentParser.php:
* …is now a service. Constructor only takes services as arguments.
The node and title are passed to a new parse() method.
* parse() should return plain data, but I split this part to a separate
patch for ease of review: I49bfe019aa460651447fd383f73eafa9d7180a92.
* CommentParser still cheats and accesses global state in a few places,
e.g. calling Title::makeTitleSafe or CommentUtils::getTitleFromUrl,
so we can't turn its tests into true unit tests. This work is left
for future commits.
LanguageData.php:
* …is now a service, instead of a static class.
Parser.js:
* …is not a real service, but it's changed to behave in a similar way.
Constructor takes only the required config as argument,
and node and title are instead passed to a new parse() method.
CommentParserTest.php:
parser.test.js:
* Can be simplified, now that we don't need a useless node and title
to test internal methods that don't use them.
testUtils.js:
* Can be simplified, now that we don't need to override internal
ResourceLoader stuff just to change the parser config.
Change-Id: Iadb7757debe000025e52770ca51ebcf24ca8ee66
2022-02-19 02:43:21 +00:00
|
|
|
protected static function getParser(): CommentParser {
|
2022-06-09 13:51:33 +00:00
|
|
|
return static::$parser;
|
2021-01-08 22:19:20 +00:00
|
|
|
}
|
|
|
|
|
|
2021-01-28 17:19:52 +00:00
|
|
|
/**
|
|
|
|
|
* @inheritDoc
|
|
|
|
|
*/
|
2022-06-28 17:34:17 +00:00
|
|
|
public static function getSignatureRelativeTime(
|
|
|
|
|
MWTimestamp $timestamp, Language $lang, UserIdentity $user
|
|
|
|
|
): string {
|
2021-01-28 17:19:52 +00:00
|
|
|
// Relative times can't be used in tests, so just return a plain timestamp
|
|
|
|
|
return $timestamp->getTimestamp();
|
|
|
|
|
}
|
2021-01-08 22:19:20 +00:00
|
|
|
}
|