wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-12-02 20:16:41 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-extensions-Discus.../tests/cases/timestamp-format-switch/timestamp-format-switch-formatted-desktop.html

69 lines
8.7 KiB
HTML
Raw Normal View History

Truncate timestamps in comment IDs / names For comments posted on or after 2022-07-12 (configurable), use a shorter format, identical to the timestamps MediaWiki uses in URLs. Changing the format for already existing comments would involve difficult migrations, therefore we elect not to do it. Bug: T304595 Change-Id: I387051a6a3a1d84cfae45c3e1516db870cc8b977
2022-06-20 20:12:06 +00:00
<div class="mw-parser-output">
Only include one set of DiscussionTools buttons in the page HTML We no longer need to support toggling visual enhancements without reloading the page, so we can remove the extraneous set of buttons to reduce HTML size. Bug: T322457 Change-Id: I54e57c754c54b7e611069f9832d1ebabf141a396
2024-02-20 00:57:43 +00:00
<div class="mw-heading mw-heading2 ext-discussiontools-init-section"><span class='ext-discussiontools-init-section-subscribeButton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-iconElement oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget' data-ooui='{"_":"OO.ui.ButtonWidget","href":"\/w\/index.php?title=Talk:T304595&amp;action=dtsubscribe&amp;commentname=h-Matma_Rex-2022-07-10T00%3A00%3A00.000Z&amp;section=Test+past","rel":["nofollow"],"framed":false,"icon":"bellOutline","label":"(discussiontools-topicsubscription-button-subscribe-label)","title":"(discussiontools-topicsubscription-button-subscribe-tooltip)","flags":["progressive"],"classes":["ext-discussiontools-init-section-subscribeButton"]}'><a role='button' title='(discussiontools-topicsubscription-button-subscribe-tooltip)' tabindex='0' href='/w/index.php?title=Talk:T304595&amp;action=dtsubscribe&amp;commentname=h-Matma_Rex-2022-07-10T00%3A00%3A00.000Z&amp;section=Test+past' rel='nofollow' class='oo-ui-buttonElement-button'><span class='oo-ui-iconElement-icon oo-ui-icon-bellOutline oo-ui-image-progressive'></span><span class='oo-ui-labelElement-label'>(discussiontools-topicsubscription-button-subscribe-label)</span><span class='oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator oo-ui-image-progressive'></span></a></span><h2><span class="mw-headline" id="Test_past" data-mw-thread-id="h-Test_past-2022-07-10T00:00:00.000Z"><span data-mw-comment-start="" id="h-Test_past-2022-07-10T00:00:00.000Z"></span>Test past<span data-mw-comment-end="h-Test_past-2022-07-10T00:00:00.000Z"></span></span></h2><div class="ext-discussiontools-init-section-bar"><div class="ext-discussiontools-init-section-metadata"><span class='ext-discussiontools-init-section-metaitem ext-discussiontools-init-section-timestampLabel'>(discussiontools-topicheader-latestcomment: <a href="#c-Matma_Rex-2022-07-10T00:00:00.000Z-Test_past">1657411200</a>)</span><span class='ext-discussiontools-init-section-metaitem ext-discussiontools-init-section-commentCountLabel'>(discussiontools-topicheader-commentcount: 1)</span><span class='ext-discussiontools-init-section-metaitem ext-discussiontools-init-section-authorCountLabel'>(discussiontools-topicheader-authorcount: 1)</span></div><div class="ext-discussiontools-init-section-actions"></div></div></div>
<p><span data-mw-comment-start="" id="c-Matma_Rex-2022-07-10T00:00:00.000Z-Test_past"></span>Hello from the past! <a href="http://localhost/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> (<a href="http://localhost/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a>) <a href="https://example.org/wiki/Talk:T304595#c-Matma_Rex-2022-07-10T00:00:00.000Z-Test_past" class="ext-discussiontools-init-timestamplink">00:00, 10 July 2022 (UTC)</a><span class="ext-discussiontools-init-replylink-buttons" data-mw-thread-id="c-Matma_Rex-2022-07-10T00:00:00.000Z-Test_past"><span class="ext-discussiontools-init-replybutton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget" data-ooui='{"_":"OO.ui.ButtonWidget","rel":["nofollow"],"framed":false,"label":"(discussiontools-replybutton)","flags":["progressive"],"classes":["ext-discussiontools-init-replybutton"]}'><a role="button" tabindex="0" rel="nofollow" class="oo-ui-buttonElement-button"><span class="oo-ui-iconElement-icon oo-ui-iconElement-noIcon oo-ui-image-progressive"></span><span class="oo-ui-labelElement-label">(discussiontools-replybutton)</span><span class="oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator oo-ui-image-progressive"></span></a></span></span><span data-mw-comment-end="c-Matma_Rex-2022-07-10T00:00:00.000Z-Test_past"></span>
Truncate timestamps in comment IDs / names For comments posted on or after 2022-07-12 (configurable), use a shorter format, identical to the timestamps MediaWiki uses in URLs. Changing the format for already existing comments would involve difficult migrations, therefore we elect not to do it. Bug: T304595 Change-Id: I387051a6a3a1d84cfae45c3e1516db870cc8b977
2022-06-20 20:12:06 +00:00
</p>
Only include one set of DiscussionTools buttons in the page HTML We no longer need to support toggling visual enhancements without reloading the page, so we can remove the extraneous set of buttons to reduce HTML size. Bug: T322457 Change-Id: I54e57c754c54b7e611069f9832d1ebabf141a396
2024-02-20 00:57:43 +00:00
<div class="mw-heading mw-heading2 ext-discussiontools-init-section"><span class='ext-discussiontools-init-section-subscribeButton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-iconElement oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget' data-ooui='{"_":"OO.ui.ButtonWidget","href":"\/w\/index.php?title=Talk:T304595&amp;action=dtsubscribe&amp;commentname=h-Matma_Rex-20220715000000&amp;section=Test+future","rel":["nofollow"],"framed":false,"icon":"bellOutline","label":"(discussiontools-topicsubscription-button-subscribe-label)","title":"(discussiontools-topicsubscription-button-subscribe-tooltip)","flags":["progressive"],"classes":["ext-discussiontools-init-section-subscribeButton"]}'><a role='button' title='(discussiontools-topicsubscription-button-subscribe-tooltip)' tabindex='0' href='/w/index.php?title=Talk:T304595&amp;action=dtsubscribe&amp;commentname=h-Matma_Rex-20220715000000&amp;section=Test+future' rel='nofollow' class='oo-ui-buttonElement-button'><span class='oo-ui-iconElement-icon oo-ui-icon-bellOutline oo-ui-image-progressive'></span><span class='oo-ui-labelElement-label'>(discussiontools-topicsubscription-button-subscribe-label)</span><span class='oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator oo-ui-image-progressive'></span></a></span><h2><span class="mw-headline" id="Test_future" data-mw-thread-id="h-Test_future-20220715000000"><span data-mw-comment-start="" id="h-Test_future-20220715000000"></span>Test future<span data-mw-comment-end="h-Test_future-20220715000000"></span></span></h2><div class="ext-discussiontools-init-section-bar"><div class="ext-discussiontools-init-section-metadata"><span class='ext-discussiontools-init-section-metaitem ext-discussiontools-init-section-timestampLabel'>(discussiontools-topicheader-latestcomment: <a href="#c-Matma_Rex-20220715000000-Test_future">1657843200</a>)</span><span class='ext-discussiontools-init-section-metaitem ext-discussiontools-init-section-commentCountLabel'>(discussiontools-topicheader-commentcount: 1)</span><span class='ext-discussiontools-init-section-metaitem ext-discussiontools-init-section-authorCountLabel'>(discussiontools-topicheader-authorcount: 1)</span></div><div class="ext-discussiontools-init-section-actions"></div></div></div>
<p><span data-mw-comment-start="" id="c-Matma_Rex-20220715000000-Test_future"></span>Hello from the future! <a href="http://localhost/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> (<a href="http://localhost/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a>) <a href="https://example.org/wiki/Talk:T304595#c-Matma_Rex-20220715000000-Test_future" class="ext-discussiontools-init-timestamplink">00:00, 15 July 2022 (UTC)</a><span class="ext-discussiontools-init-replylink-buttons" data-mw-thread-id="c-Matma_Rex-20220715000000-Test_future"><span class="ext-discussiontools-init-replybutton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget" data-ooui='{"_":"OO.ui.ButtonWidget","rel":["nofollow"],"framed":false,"label":"(discussiontools-replybutton)","flags":["progressive"],"classes":["ext-discussiontools-init-replybutton"]}'><a role="button" tabindex="0" rel="nofollow" class="oo-ui-buttonElement-button"><span class="oo-ui-iconElement-icon oo-ui-iconElement-noIcon oo-ui-image-progressive"></span><span class="oo-ui-labelElement-label">(discussiontools-replybutton)</span><span class="oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator oo-ui-image-progressive"></span></a></span></span><span data-mw-comment-end="c-Matma_Rex-20220715000000-Test_future"></span>
Truncate timestamps in comment IDs / names For comments posted on or after 2022-07-12 (configurable), use a shorter format, identical to the timestamps MediaWiki uses in URLs. Changing the format for already existing comments would involve difficult migrations, therefore we elect not to do it. Bug: T304595 Change-Id: I387051a6a3a1d84cfae45c3e1516db870cc8b977
2022-06-20 20:12:06 +00:00
</p>
</div>
Use setExtensionData() instead of marker comments where possible (3/3) We started using marker comments (HTML comments with special content inserted into the page) for the reply buttons back in the day, because we needed to indicate their location in the HTML. Later we used the same idea for things which aren't actually tied to a specific location in the HTML, such as boolean data like __DTEMPTYTALKPAGE__. There is a better way to do this. This commit stop writing the HTML comments, which are no longer used, and cleans up the tests. Bug: T328980 Change-Id: I37541356830945cc9abcc79d4c445ff6f2449759 (cherry picked from commit ab40ef62c08fe375ea04b254e4df0a28c295544f)
2023-02-07 00:42:00 +00:00
Embed pageThread JSON in jsConfigVars instead of infusing HTML Bug: T322651 Depends-On: I86d461756398780dc24949013f35b7730a481052 Change-Id: I85ee8e6ed6eba97b94f4e4c415fbc5286c234cce
2022-08-12 17:13:48 +00:00
<pre>
Use setExtensionData() instead of marker comments where possible (3/3) We started using marker comments (HTML comments with special content inserted into the page) for the reply buttons back in the day, because we needed to indicate their location in the HTML. Later we used the same idea for things which aren't actually tied to a specific location in the HTML, such as boolean data like __DTEMPTYTALKPAGE__. There is a better way to do this. This commit stop writing the HTML comments, which are no longer used, and cleans up the tests. Bug: T328980 Change-Id: I37541356830945cc9abcc79d4c445ff6f2449759 (cherry picked from commit ab40ef62c08fe375ea04b254e4df0a28c295544f)
2023-02-07 00:42:00 +00:00
newestComment: {
"id": "c-Matma_Rex-20220715000000-Test_future",
"timestamp": "20220715000000",
"author": "Matma Rex",
"heading": {
"headingLevel": 2,
"name": "h-Matma_Rex-20220715000000",
"type": "heading",
"level": 0,
"id": "h-Test_future-20220715000000",
"replies": [
"c-Matma_Rex-20220715000000-Test_future"
],
"text": "Test future",
"linkableTitle": "Test future"
}
}
hasLedeContent
Embed pageThread JSON in jsConfigVars instead of infusing HTML Bug: T322651 Depends-On: I86d461756398780dc24949013f35b7730a481052 Change-Id: I85ee8e6ed6eba97b94f4e4c415fbc5286c234cce
2022-08-12 17:13:48 +00:00
{
"wgDiscussionToolsPageThreads": [
{
"headingLevel": 2,
"name": "h-Matma_Rex-2022-07-10T00:00:00.000Z",
"type": "heading",
"level": 0,
"id": "h-Test_past-2022-07-10T00:00:00.000Z",
"replies": [
{
"timestamp": "2022-07-10T00:00:00.000Z",
"author": "Matma Rex",
"type": "comment",
"level": 1,
"id": "c-Matma_Rex-2022-07-10T00:00:00.000Z-Test_past",
"replies": []
}
[BREAKING CHANGE] Remove isSectionEditable from overflow hook Instead make isUneditableSection an optional property of ContentHeadingItem. Change-Id: Icfddf28aa789b5014ac183ff9f9699f38d78c121
2023-10-11 15:53:55 +00:00
],
"uneditableSection": true
Embed pageThread JSON in jsConfigVars instead of infusing HTML Bug: T322651 Depends-On: I86d461756398780dc24949013f35b7730a481052 Change-Id: I85ee8e6ed6eba97b94f4e4c415fbc5286c234cce
2022-08-12 17:13:48 +00:00
},
{
"headingLevel": 2,
"name": "h-Matma_Rex-20220715000000",
"type": "heading",
"level": 0,
"id": "h-Test_future-20220715000000",
"replies": [
{
"timestamp": "20220715000000",
"author": "Matma Rex",
"type": "comment",
"level": 1,
"id": "c-Matma_Rex-20220715000000-Test_future",
"replies": []
}
[BREAKING CHANGE] Remove isSectionEditable from overflow hook Instead make isUneditableSection an optional property of ContentHeadingItem. Change-Id: Icfddf28aa789b5014ac183ff9f9699f38d78c121
2023-10-11 15:53:55 +00:00
],
"uneditableSection": true
Embed pageThread JSON in jsConfigVars instead of infusing HTML Bug: T322651 Depends-On: I86d461756398780dc24949013f35b7730a481052 Change-Id: I85ee8e6ed6eba97b94f4e4c415fbc5286c234cce
2022-08-12 17:13:48 +00:00
}
]
}
</pre>
Reference in a new issue Copy permalink