mediawiki-extensions-Discus.../tests/data/README.txt

Minimal overrides for LanguageData::getLocalData() and mw.config
required for us to be able to parse HTML generated by the given wiki.

To make one of these files, run the following in browser console:

config.json:
  JSON.stringify( mw.config.get( [ 'wgContentLanguage', 'wgArticlePath', 'wgNamespaceIds', 'wgFormattedNamespaces' ] ), null, '\t' )

data.json:
  JSON.stringify( mw.loader.require( 'ext.discussionTools.init' ).parserData )
Split Data class into ResourceLoaderData and LanguageData The Data class contained utilities for two unrelated purposes. Split each half to a separate class. Notably, this improves the signature of the getLocalData() function. Change-Id: Icde615fb9d483fee1f352c34909b37f8ffde8081 2022-02-19 04:03:09 +00:00			`Minimal overrides for LanguageData::getLocalData() and mw.config`
Integration tests for parsing Tests that handle a specific case and describe what they are testing would be nice… but tests that just document the current status to avoid regressions are also okay and easier to add. Change-Id: I0b3530ae0e77de70932aaf623f5290d1876699a0 2019-10-24 12:59:42 +00:00			`required for us to be able to parse HTML generated by the given wiki.`
Improve and document the files in tests/data/ * Remove 'wgMetaNamespace' and 'wgMetaNamespaceTalk', the same data exists in 'wgFormattedNamespaces'. * Rename 'wgContentLang' to 'wgContentLanguage', to match its real name in JS config. MediaWiki doesn't use 'wgContentLang' anywhere, although the related PHP global is called $wgContLang. * Document how I made these files, previously only mentioned in the commit message of e9c401e3aa. Change-Id: I67f962812c155aedf41154e0d837e7feb5af972d 2020-08-31 23:14:35 +00:00
			`To make one of these files, run the following in browser console:`

			`config.json:`
Add another test case for transclusions overlapping comments Prior to 8de940b5, the comments on this page would not be marked as partially transcluded. Bug: T298408 Change-Id: Ib7eb8b4113151048c0e778b3530600d98dd8f705 2022-01-14 01:24:06 +00:00			`JSON.stringify( mw.config.get( [ 'wgContentLanguage', 'wgArticlePath', 'wgNamespaceIds', 'wgFormattedNamespaces' ] ), null, '\t' )`
Improve and document the files in tests/data/ * Remove 'wgMetaNamespace' and 'wgMetaNamespaceTalk', the same data exists in 'wgFormattedNamespaces'. * Rename 'wgContentLang' to 'wgContentLanguage', to match its real name in JS config. MediaWiki doesn't use 'wgContentLang' anywhere, although the related PHP global is called $wgContLang. * Document how I made these files, previously only mentioned in the commit message of e9c401e3aa. Change-Id: I67f962812c155aedf41154e0d837e7feb5af972d 2020-08-31 23:14:35 +00:00
			`data.json:`
Change CommentParser into a service Goal: ----- To have a method like CommentParser::parse(), which just takes a node to parse and a title and returns plain data, so that we don't need to keep track of the config to construct a CommentParser object (the required config like content language is provided by services) and we don't need to keep that object around after parsing. Changes: -------- CommentParser.php: * …is now a service. Constructor only takes services as arguments. The node and title are passed to a new parse() method. * parse() should return plain data, but I split this part to a separate patch for ease of review: I49bfe019aa460651447fd383f73eafa9d7180a92. * CommentParser still cheats and accesses global state in a few places, e.g. calling Title::makeTitleSafe or CommentUtils::getTitleFromUrl, so we can't turn its tests into true unit tests. This work is left for future commits. LanguageData.php: * …is now a service, instead of a static class. Parser.js: * …is not a real service, but it's changed to behave in a similar way. Constructor takes only the required config as argument, and node and title are instead passed to a new parse() method. CommentParserTest.php: parser.test.js: * Can be simplified, now that we don't need a useless node and title to test internal methods that don't use them. testUtils.js: * Can be simplified, now that we don't need to override internal ResourceLoader stuff just to change the parser config. Change-Id: Iadb7757debe000025e52770ca51ebcf24ca8ee66 2022-02-19 02:43:21 +00:00			`JSON.stringify( mw.loader.require( 'ext.discussionTools.init' ).parserData )`