wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-17 05:10:50 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-extensions-Discus.../tests/cases/signatures-funny/signatures-funny-modified.html

18 lines
4.9 KiB
HTML
Raw Normal View History

Add reply links at the end of a line, even if the signature is in the middle Previously they were added at the end of the text node containing the timestamp, which was usually the end of the line, but not always. And also fix the same problem for inserting the actual replies (or reply widgets). This replaces an undocumented hack that prevented our own reply links from triggering this bug (without it, the reply widget would be inserted before the reply link rather than after). While we're here, remove unintentional spacing that appeared before some reply links, caused by trailing whitespace in text nodes. Add tests for all of the above. Bug: T245695 Change-Id: I354b63e2446bb996176a2e3d76abf944127f307e
2020-03-02 18:50:36 +00:00
<h2><span class="mw-headline" id="multi_signatures">multi signatures</span><span class="mw-editsection"><span class="mw-editsection-bracket">[</span><a href="/w/index.php?title=Talk:Scratch&amp;action=edit&amp;section=5" title="Edit section: multi signatures">edit source</a><span class="mw-editsection-bracket">]</span></span></h2>
More test cases for multiple signatures in funny places Expand the 'signatures-funny' test case with more examples, which don't behave correctly. Follow-up commits I04a8ea09401e06f2d4bb1f226f17eb528b29ed95 and Ic26a87642f8a15d5de2f7073d4d8176b299c7f94 fix them. Bug: T255738 Change-Id: I0fdd8bdf11b497ffeed37c37953c5730f6e4f3b7
2020-08-11 04:09:18 +00:00
<p>aaa <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 08:31, 25 January 2020 (UTC) amended! <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 08:41, 25 January 2020 (UTC)
Add reply links at the end of a line, even if the signature is in the middle Previously they were added at the end of the text node containing the timestamp, which was usually the end of the line, but not always. And also fix the same problem for inserting the actual replies (or reply widgets). This replaces an undocumented hack that prevented our own reply links from triggering this bug (without it, the reply widget would be inserted before the reply link rather than after). While we're here, remove unintentional spacing that appeared before some reply links, caused by trailing whitespace in text nodes. Add tests for all of the above. Bug: T245695 Change-Id: I354b63e2446bb996176a2e3d76abf944127f307e
2020-03-02 18:50:36 +00:00
</p>
More test cases for multiple signatures in funny places Expand the 'signatures-funny' test case with more examples, which don't behave correctly. Follow-up commits I04a8ea09401e06f2d4bb1f226f17eb528b29ed95 and Ic26a87642f8a15d5de2f7073d4d8176b299c7f94 fix them. Bug: T255738 Change-Id: I0fdd8bdf11b497ffeed37c37953c5730f6e4f3b7
2020-08-11 04:09:18 +00:00
<ul><li>bbb <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 08:32, 25 January 2020 (UTC)
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
<ul><li>ccc <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 08:33, 25 January 2020 (UTC) amended! <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 08:43, 25 January 2020 (UTC)<dl><dd data-parsoid="{}">Reply to c|Matma Rex|2020-01-25T08:33:00.000Z|Matma Rex|2020-01-25T08:32:00.000Z</dd></dl></li></ul><dl><dd data-parsoid="{}">Reply to c|Matma Rex|2020-01-25T08:32:00.000Z|Matma Rex|2020-01-25T08:31:00.000Z</dd></dl></li></ul><dl><dd data-parsoid="{}">Reply to c|Matma Rex|2020-01-25T08:31:00.000Z|multi_signatures</dd></dl>
More test cases for multiple signatures in funny places Expand the 'signatures-funny' test case with more examples, which don't behave correctly. Follow-up commits I04a8ea09401e06f2d4bb1f226f17eb528b29ed95 and Ic26a87642f8a15d5de2f7073d4d8176b299c7f94 fix them. Bug: T255738 Change-Id: I0fdd8bdf11b497ffeed37c37953c5730f6e4f3b7
2020-08-11 04:09:18 +00:00
<p>multi-line top level <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 08:34, 25 January 2020 (UTC)
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
</p><dl><dd data-parsoid="{}">Reply to c|Matma Rex|2020-01-25T08:34:00.000Z|multi_signatures</dd></dl><p>ddd <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 08:34, 25 January 2020 (UTC)
Add reply links at the end of a line, even if the signature is in the middle Previously they were added at the end of the text node containing the timestamp, which was usually the end of the line, but not always. And also fix the same problem for inserting the actual replies (or reply widgets). This replaces an undocumented hack that prevented our own reply links from triggering this bug (without it, the reply widget would be inserted before the reply link rather than after). While we're here, remove unintentional spacing that appeared before some reply links, caused by trailing whitespace in text nodes. Add tests for all of the above. Bug: T245695 Change-Id: I354b63e2446bb996176a2e3d76abf944127f307e
2020-03-02 18:50:36 +00:00
</p>
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
<ul><li>eee <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 08:35, 25 January 2020 (UTC) amended! <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 08:45, 25 January 2020 (UTC)<dl><dd data-parsoid="{}">Reply to c|Matma Rex|2020-01-25T08:35:00.000Z|Matma Rex|2020-01-25T08:34:00.000Z</dd></dl></li>
<li>fff <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 08:36, 25 January 2020 (UTC) also!<dl><dd data-parsoid="{}">Reply to c|Matma Rex|2020-01-25T08:36:00.000Z|Matma Rex|2020-01-25T08:34:00.000Z</dd></dl></li>
More test cases for multiple signatures in funny places Expand the 'signatures-funny' test case with more examples, which don't behave correctly. Follow-up commits I04a8ea09401e06f2d4bb1f226f17eb528b29ed95 and Ic26a87642f8a15d5de2f7073d4d8176b299c7f94 fix them. Bug: T255738 Change-Id: I0fdd8bdf11b497ffeed37c37953c5730f6e4f3b7
2020-08-11 04:09:18 +00:00
<li>fff <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 08:37, 25 January 2020 (UTC) and <i>also</i>!
Disambiguate comments by parent ID, rather than sequential numbers Sequential numbers aren't great because they change when an earlier comment is archived. Parent comment/heading IDs should change less often. This also makes much more sense for disambiguating subsections, e.g. a dozen identical ===Votes=== sections for a dozen proposals. Bug: T264478 Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
2020-10-01 20:13:47 +00:00
<ul><li>multi-line reply <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 08:38, 25 January 2020 (UTC)<dl><dd data-parsoid="{}">Reply to c|Matma Rex|2020-01-25T08:38:00.000Z|Matma Rex|2020-01-25T08:37:00.000Z</dd></dl></li>
<li>ggg <b><a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> | <a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex">talk</a></b> 08:38, 25 January 2020 (UTC)<dl><dd data-parsoid="{}">Reply to c|Matma Rex|2020-01-25T08:38:00.000Z|Matma Rex|2020-01-25T08:37:00.000Z|1</dd></dl></li></ul><dl><dd data-parsoid="{}">Reply to c|Matma Rex|2020-01-25T08:37:00.000Z|Matma Rex|2020-01-25T08:34:00.000Z</dd></dl></li></ul><dl><dd data-parsoid="{}">Reply to c|Matma Rex|2020-01-25T08:34:00.000Z|multi_signatures|1</dd></dl>
Don't detect comments within headings Bug: T267068 Change-Id: Id134f15e086fd070801c4b1d836dbfbf9bf444ad
2020-11-04 15:17:39 +00:00
<h2><span id="hello_Matma_Rex_.28talk.29_18:27.2C_2_November_2020_.28UTC.29"></span><span class="mw-headline" id="hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)">hello <a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> (<a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex"><font color="green"><i>talk</i></font></a>) 18:27, 2 November 2020 (UTC)</span><span class="mw-editsection"><span class="mw-editsection-bracket">[</span><a href="/w/index.php?title=Talk:Signature_in_heading&amp;action=edit&amp;section=1" title="Edit section: hello Matma Rex (talk) 18:27, 2 November 2020 (UTC)">edit source</a><span class="mw-editsection-bracket">]</span></span></h2>
<p>hello <a href="/wiki/User:Matma_Rex" title="User:Matma Rex">Matma Rex</a> (<a href="/wiki/User_talk:Matma_Rex" title="User talk:Matma Rex"><font color="green"><i>talk</i></font></a>) 18:28, 2 November 2020 (UTC)
</p><dl><dd data-parsoid="{}">Reply to c|Matma Rex|2020-11-02T18:28:00.000Z|hello_Matma_Rex_(talk)_18:27,_2_November_2020_(UTC)</dd></dl>
Reference in a new issue Copy permalink