wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-11-28 10:11:45 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-extensions-Discus.../tests/cases/linearWalk/simple.json

159 lines
2.7 KiB
JSON
Raw Normal View History

Fix skipping to the end of paragraph, now it considers nested tags Add yet another tree walking utility: CommentUtils::linearWalk(). Unlike TreeWalker, it allows handling the beginnings and ends of nodes separately – kind of like parsing a XML token stream, or kind of like VisualEditor's linear model. (Add unit tests for this utility. The simple.html test case is copied from [VisualEditor/VisualEditor]/demos/ve/pages/simple.html.) Use this utility to stop skipping when we reach either a closing or opening block node tag. Previously we'd skip over such tags inside nested "transparent" nodes (like <a>, <del>, or apparently <font>). Bug: T271385 Change-Id: I201a942eb3a56335e84d94e150ec2c33f8b4f4e0
2021-01-08 19:20:33 +00:00
[
Ship HTML test files for JS using 'packageFiles' instead of 'templates' We originally used 'templates' because it seemed like an obvious choice for HTML files, and because 'packageFiles' requires extra code to include anything that isn't a .js or .json file. However, the templates are expected to be HTML fragments rather than whole documents, and they are parsed in a particular way that takes a lot of code to clean up (which we needed to do, because we use the same test files for testing PHP code). I tried doing it in the 'packageFiles' way, and the extra code doesn't seem that bad in comparison after all. Moreover, the 'templates' mechanism (when used the intended way) feels vaguely deprecated in favor of Vue.js, and I'd rather move away from it. This makes the tests faster too (probably mostly thanks to the removal of the clean up code) – on my machine they go from 1800ms to 1500ms. (Simplify linearWalk tests, as we no longer need to do weird things with document fragments to get consistent outputs in PHP and JS.) Change-Id: I39f9b994ce5636d70fea2e935a7c87c7d56dcb26
2022-10-12 20:03:23 +00:00
"enter #document(9)",
"enter html(1)",
"enter head(1)",
"leave head(1)",
"enter body(1)",
Use tabs for indentation in JSON test files Change-Id: I1d8f8b33b19bcff249ad08dfe687f87f5e5bf9bf
2021-01-26 23:55:15 +00:00
"enter p(1)",
"enter b(1)",
"enter a(1)",
"enter #text(3)",
"leave #text(3)",
"leave a(1)",
"leave b(1)",
"enter #text(3)",
"leave #text(3)",
"enter a(1)",
"enter #text(3)",
"leave #text(3)",
"leave a(1)",
"enter #text(3)",
"leave #text(3)",
"leave p(1)",
"enter #text(3)",
"leave #text(3)",
"enter h2(1)",
"enter b(1)",
"enter #text(3)",
"leave #text(3)",
"leave b(1)",
"enter #text(3)",
"leave #text(3)",
"enter i(1)",
"enter #text(3)",
"leave #text(3)",
"leave i(1)",
"leave h2(1)",
"enter #text(3)",
"leave #text(3)",
"enter p(1)",
"enter #text(3)",
"leave #text(3)",
"enter a(1)",
"enter #text(3)",
"leave #text(3)",
"leave a(1)",
"enter #text(3)",
"leave #text(3)",
"enter a(1)",
"enter #text(3)",
"leave #text(3)",
"leave a(1)",
"enter #text(3)",
"leave #text(3)",
"leave p(1)",
"enter #text(3)",
"leave #text(3)",
"enter h3(1)",
"enter b(1)",
"enter #text(3)",
"leave #text(3)",
"leave b(1)",
"enter #text(3)",
"leave #text(3)",
"enter i(1)",
"enter #text(3)",
"leave #text(3)",
"leave i(1)",
"leave h3(1)",
"enter #text(3)",
"leave #text(3)",
"enter p(1)",
"enter #text(3)",
"leave #text(3)",
"leave p(1)",
"enter #text(3)",
"leave #text(3)",
"enter h2(1)",
"enter b(1)",
"enter #text(3)",
"leave #text(3)",
"leave b(1)",
"enter #text(3)",
"leave #text(3)",
"enter i(1)",
"enter #text(3)",
"leave #text(3)",
"leave i(1)",
"leave h2(1)",
"enter #text(3)",
"leave #text(3)",
"enter ul(1)",
"enter #text(3)",
"leave #text(3)",
"enter li(1)",
"enter #text(3)",
"leave #text(3)",
"enter p(1)",
"enter b(1)",
"enter #text(3)",
"leave #text(3)",
"leave b(1)",
"leave p(1)",
"enter #text(3)",
"leave #text(3)",
"leave li(1)",
"enter #text(3)",
"leave #text(3)",
"enter li(1)",
"enter #text(3)",
"leave #text(3)",
"enter p(1)",
"enter #text(3)",
"leave #text(3)",
"enter i(1)",
"enter #text(3)",
"leave #text(3)",
"leave i(1)",
"leave p(1)",
"enter #text(3)",
"leave #text(3)",
"leave li(1)",
"enter #text(3)",
"leave #text(3)",
"enter li(1)",
"enter #text(3)",
"leave #text(3)",
"enter p(1)",
"enter #text(3)",
"leave #text(3)",
"enter u(1)",
"enter #text(3)",
"leave #text(3)",
"leave u(1)",
"leave p(1)",
"enter #text(3)",
"leave #text(3)",
"leave li(1)",
"enter #text(3)",
"leave #text(3)",
"leave ul(1)",
"enter #text(3)",
"leave #text(3)",
"enter h2(1)",
"enter #text(3)",
"leave #text(3)",
"leave h2(1)",
"enter #text(3)",
"leave #text(3)",
"enter p(1)",
"enter #text(3)",
"leave #text(3)",
"leave p(1)",
Ship HTML test files for JS using 'packageFiles' instead of 'templates' We originally used 'templates' because it seemed like an obvious choice for HTML files, and because 'packageFiles' requires extra code to include anything that isn't a .js or .json file. However, the templates are expected to be HTML fragments rather than whole documents, and they are parsed in a particular way that takes a lot of code to clean up (which we needed to do, because we use the same test files for testing PHP code). I tried doing it in the 'packageFiles' way, and the extra code doesn't seem that bad in comparison after all. Moreover, the 'templates' mechanism (when used the intended way) feels vaguely deprecated in favor of Vue.js, and I'd rather move away from it. This makes the tests faster too (probably mostly thanks to the removal of the clean up code) – on my machine they go from 1800ms to 1500ms. (Simplify linearWalk tests, as we no longer need to do weird things with document fragments to get consistent outputs in PHP and JS.) Change-Id: I39f9b994ce5636d70fea2e935a7c87c7d56dcb26
2022-10-12 20:03:23 +00:00
"enter #text(3)",
"leave #text(3)",
"leave body(1)",
"leave html(1)",
"leave #document(9)"
Fix skipping to the end of paragraph, now it considers nested tags Add yet another tree walking utility: CommentUtils::linearWalk(). Unlike TreeWalker, it allows handling the beginnings and ends of nodes separately – kind of like parsing a XML token stream, or kind of like VisualEditor's linear model. (Add unit tests for this utility. The simple.html test case is copied from [VisualEditor/VisualEditor]/demos/ve/pages/simple.html.) Use this utility to stop skipping when we reach either a closing or opening block node tag. Previously we'd skip over such tags inside nested "transparent" nodes (like <a>, <del>, or apparently <font>). Bug: T271385 Change-Id: I201a942eb3a56335e84d94e150ec2c33f8b4f4e0
2021-01-08 19:20:33 +00:00
]
Reference in a new issue Copy permalink