mediawiki-extensions-Discus.../tests/qunit/modifier.test.js

144 lines
4.5 KiB
JavaScript
Raw Normal View History

var
testUtils = require( './testUtils.js' ),
Parser = require( 'ext.discussionTools.init' ).Parser,
modifier = require( 'ext.discussionTools.init' ).modifier;
Change CommentParser into a service Goal: ----- To have a method like CommentParser::parse(), which just takes a node to parse and a title and returns plain data, so that we don't need to keep track of the config to construct a CommentParser object (the required config like content language is provided by services) and we don't need to keep that object around after parsing. Changes: -------- CommentParser.php: * …is now a service. Constructor only takes services as arguments. The node and title are passed to a new parse() method. * parse() should return plain data, but I split this part to a separate patch for ease of review: I49bfe019aa460651447fd383f73eafa9d7180a92. * CommentParser still cheats and accesses global state in a few places, e.g. calling Title::makeTitleSafe or CommentUtils::getTitleFromUrl, so we can't turn its tests into true unit tests. This work is left for future commits. LanguageData.php: * …is now a service, instead of a static class. Parser.js: * …is not a real service, but it's changed to behave in a similar way. Constructor takes only the required config as argument, and node and title are instead passed to a new parse() method. CommentParserTest.php: parser.test.js: * Can be simplified, now that we don't need a useless node and title to test internal methods that don't use them. testUtils.js: * Can be simplified, now that we don't need to override internal ResourceLoader stuff just to change the parser config. Change-Id: Iadb7757debe000025e52770ca51ebcf24ca8ee66
2022-02-19 02:43:21 +00:00
QUnit.module( 'mw.dt.modifier', QUnit.newMwEnvironment() );
require( '../cases/modified.json' ).forEach( function ( caseItem ) {
var testName = '#addListItem/#removeAddedListItem (' + caseItem.name + ')';
// This should be one test with many cases, rather than multiple tests, but the cases are large
// enough that processing all of them at once causes timeouts in Karma test runner.
// FIXME: Actually, even single test cases cause timeouts now. Skip the slowest ones.
var skipTests = [
'enwiki oldparser',
'enwiki parsoid',
'enwiki oldparser (bullet indentation)',
'enwiki parsoid (bullet indentation)'
];
if ( skipTests.indexOf( caseItem.name ) !== -1 ) {
QUnit.skip( testName );
return;
}
QUnit.test( testName, function ( assert ) {
var dom = ve.createDocumentFromHtml( require( '../' + caseItem.dom ) ),
expected = ve.createDocumentFromHtml( require( '../' + caseItem.expected ) ),
config = require( caseItem.config ),
data = require( caseItem.data );
testUtils.overrideMwConfig( config );
var expectedHtml = testUtils.getThreadContainer( expected ).innerHTML;
var reverseExpectedHtml = testUtils.getThreadContainer( dom ).innerHTML;
var container = testUtils.getThreadContainer( dom );
var title = mw.Title.newFromText( caseItem.title );
var threadItemSet = new Parser( data ).parse( container, title );
var comments = threadItemSet.getCommentItems();
// Add a reply to every comment. Note that this inserts *all* of the replies, unlike the real
// thing, which only deals with one at a time. This isn't ideal but resetting everything after
// every reply would be super slow.
var nodes = [];
comments.forEach( function ( comment ) {
var node = modifier.addListItem( comment, caseItem.replyIndentation || 'invisible' );
node.textContent = 'Reply to ' + comment.id;
nodes.push( node );
} );
// Uncomment this to get updated content for the "modified HTML" files, for copy/paste:
// console.log( container.innerHTML );
var actualHtml = container.innerHTML;
assert.strictEqual(
actualHtml,
expectedHtml,
comments.length + ' replies added'
);
// Now discard the replies and verify we get the original document back.
nodes.forEach( function ( node ) {
modifier.removeAddedListItem( node );
} );
var reverseActualHtml = container.innerHTML;
assert.strictEqual(
reverseActualHtml,
reverseExpectedHtml,
nodes.length + ' replies removed'
);
} );
} );
QUnit.test( '#addReplyLink', function ( assert ) {
var cases = require( '../cases/reply.json' );
cases.forEach( function ( caseItem ) {
var dom = ve.createDocumentFromHtml( require( '../' + caseItem.dom ) ),
expected = ve.createDocumentFromHtml( require( '../' + caseItem.expected ) ),
config = require( caseItem.config ),
data = require( caseItem.data );
testUtils.overrideMwConfig( config );
var expectedHtml = testUtils.getThreadContainer( expected ).innerHTML;
var container = testUtils.getThreadContainer( dom );
var title = mw.Title.newFromText( caseItem.title );
var threadItemSet = new Parser( data ).parse( container, title );
var comments = threadItemSet.getCommentItems();
// Add a reply link to every comment.
comments.forEach( function ( comment ) {
var linkNode = document.createElement( 'a' );
linkNode.textContent = 'Reply';
linkNode.href = '#';
modifier.addReplyLink( comment, linkNode );
} );
// Uncomment this to get updated content for the "reply HTML" files, for copy/paste:
// console.log( container.innerHTML );
var actualHtml = container.innerHTML;
assert.strictEqual(
actualHtml,
expectedHtml,
caseItem.name
);
} );
} );
QUnit.test( '#unwrapList', function ( assert ) {
var cases = require( '../cases/unwrap.json' );
cases.forEach( function ( caseItem ) {
var container = document.createElement( 'div' );
container.innerHTML = caseItem.html;
modifier.unwrapList( container.childNodes[ caseItem.index || 0 ] );
assert.strictEqual(
container.innerHTML,
caseItem.expected,
caseItem.name
);
} );
} );
QUnit.test( 'sanitizeWikitextLinebreaks', function ( assert ) {
var cases = require( '../cases/sanitize-wikitext-linebreaks.json' );
cases.forEach( function ( caseItem ) {
assert.strictEqual(
modifier.sanitizeWikitextLinebreaks( caseItem.wikitext ),
caseItem.expected,
caseItem.msg
);
} );
} );
// TODO:
// * addSiblingListItem