mediawiki-extensions-Discus.../includes/ApiDiscussionToolsTrait.php

159 lines
4.4 KiB
PHP
Raw Normal View History

<?php
namespace MediaWiki\Extension\DiscussionTools;
use ApiMain;
use ApiResult;
use DerivativeContext;
use DerivativeRequest;
use IContextSource;
Change CommentParser into a service Goal: ----- To have a method like CommentParser::parse(), which just takes a node to parse and a title and returns plain data, so that we don't need to keep track of the config to construct a CommentParser object (the required config like content language is provided by services) and we don't need to keep that object around after parsing. Changes: -------- CommentParser.php: * …is now a service. Constructor only takes services as arguments. The node and title are passed to a new parse() method. * parse() should return plain data, but I split this part to a separate patch for ease of review: I49bfe019aa460651447fd383f73eafa9d7180a92. * CommentParser still cheats and accesses global state in a few places, e.g. calling Title::makeTitleSafe or CommentUtils::getTitleFromUrl, so we can't turn its tests into true unit tests. This work is left for future commits. LanguageData.php: * …is now a service, instead of a static class. Parser.js: * …is not a real service, but it's changed to behave in a similar way. Constructor takes only the required config as argument, and node and title are instead passed to a new parse() method. CommentParserTest.php: parser.test.js: * Can be simplified, now that we don't need a useless node and title to test internal methods that don't use them. testUtils.js: * Can be simplified, now that we don't need to override internal ResourceLoader stuff just to change the parser config. Change-Id: Iadb7757debe000025e52770ca51ebcf24ca8ee66
2022-02-19 02:43:21 +00:00
use MediaWiki\MediaWikiServices;
use MediaWiki\Revision\RevisionRecord;
use Title;
use TitleValue;
use Wikimedia\Parsoid\Utils\DOMCompat;
use Wikimedia\Parsoid\Utils\DOMUtils;
/**
* Random methods we want to share between API modules.
*/
trait ApiDiscussionToolsTrait {
/**
* @param RevisionRecord $revision
* @return ContentThreadItemSet
*/
protected function parseRevision( RevisionRecord $revision ): ContentThreadItemSet {
$response = $this->requestRestbasePageHtml( $revision );
$doc = DOMUtils::parseHTML( $response['body'] );
$container = DOMCompat::getBody( $doc );
CommentUtils::unwrapParsoidSections( $container );
$title = TitleValue::newFromPage( $revision->getPage() );
Change CommentParser into a service Goal: ----- To have a method like CommentParser::parse(), which just takes a node to parse and a title and returns plain data, so that we don't need to keep track of the config to construct a CommentParser object (the required config like content language is provided by services) and we don't need to keep that object around after parsing. Changes: -------- CommentParser.php: * …is now a service. Constructor only takes services as arguments. The node and title are passed to a new parse() method. * parse() should return plain data, but I split this part to a separate patch for ease of review: I49bfe019aa460651447fd383f73eafa9d7180a92. * CommentParser still cheats and accesses global state in a few places, e.g. calling Title::makeTitleSafe or CommentUtils::getTitleFromUrl, so we can't turn its tests into true unit tests. This work is left for future commits. LanguageData.php: * …is now a service, instead of a static class. Parser.js: * …is not a real service, but it's changed to behave in a similar way. Constructor takes only the required config as argument, and node and title are instead passed to a new parse() method. CommentParserTest.php: parser.test.js: * Can be simplified, now that we don't need a useless node and title to test internal methods that don't use them. testUtils.js: * Can be simplified, now that we don't need to override internal ResourceLoader stuff just to change the parser config. Change-Id: Iadb7757debe000025e52770ca51ebcf24ca8ee66
2022-02-19 02:43:21 +00:00
$parser = MediaWikiServices::getInstance()->getService( 'DiscussionTools.CommentParser' );
return $parser->parse( $container, $title );
}
/**
* Given parameters describing a reply or new topic, transform them into wikitext using Parsoid,
* then preview the wikitext using the legacy parser.
*
* @param string $type 'topic' or 'reply'
* @param Title $title Context title for wikitext transformations
* @param array $params Associative array with the following keys:
* - `wikitext` (string|null) Content of the message, mutually exclusive with `html`
* - `html` (string|null) Content of the message, mutually exclusive with `wikitext`
* - `sectiontitle` (string) Content of the title, when `type` is 'topic'
* - `signature` (string|null) Wikitext signature to add to the message
* @param array $originalParams Original params from the source API call
* @return ApiResult action=parse API result
*/
protected function previewMessage(
string $type, Title $title, array $params, array $originalParams = []
): ApiResult {
$wikitext = $params['wikitext'] ?? null;
$html = $params['html'] ?? null;
$signature = $params['signature'] ?? null;
switch ( $type ) {
case 'topic':
if ( $wikitext !== null ) {
$wikitext = CommentUtils::htmlTrim( $wikitext );
if ( $signature !== null ) {
$wikitext .= $signature;
}
} else {
$doc = DOMUtils::parseHTML( '' );
$container = DOMUtils::parseHTMLToFragment( $doc, $html );
if ( $signature !== null ) {
CommentModifier::appendSignature( $container, $signature );
}
$html = DOMUtils::getFragmentInnerHTML( $container );
$wikitext = $this->transformHTML( $title, $html )[ 'body' ];
}
if ( $params['sectiontitle'] ) {
$wikitext = "== " . $params['sectiontitle'] . " ==\n" . $wikitext;
}
break;
case 'reply':
$doc = DOMUtils::parseHTML( '' );
if ( $wikitext !== null ) {
$container = CommentModifier::prepareWikitextReply( $doc, $wikitext );
} else {
$container = CommentModifier::prepareHtmlReply( $doc, $html );
}
if ( $signature !== null ) {
CommentModifier::appendSignature( $container, $signature );
}
$list = CommentModifier::transferReply( $container );
$html = DOMCompat::getOuterHTML( $list );
$wikitext = $this->transformHTML( $title, $html )[ 'body' ];
break;
}
$apiParams = [
'action' => 'parse',
'title' => $title->getPrefixedText(),
'text' => $wikitext,
'pst' => '1',
'preview' => '1',
'disableeditsection' => '1',
'prop' => 'text|modules|jsconfigvars',
];
if ( isset( $originalParams['useskin'] ) ) {
$apiParams['useskin'] = $originalParams['useskin'];
}
if ( isset( $originalParams['mobileformat'] ) && $originalParams['mobileformat'] ) {
$apiParams['mobileformat'] = '1';
}
$context = new DerivativeContext( $this->getContext() );
$context->setRequest(
new DerivativeRequest(
$context->getRequest(),
$apiParams,
/* was posted? */ true
)
);
$api = new ApiMain(
$context,
/* enable write? */ false
);
$api->execute();
return $api->getResult();
}
/**
* @param RevisionRecord $revision
* @return array
*/
abstract protected function requestRestbasePageHtml( RevisionRecord $revision ): array;
/**
* @param Title $title
* @param string $html
* @param int|null $oldid
* @param string|null $etag
* @return array
*/
abstract protected function transformHTML(
Title $title, string $html, int $oldid = null, string $etag = null
): array;
/**
* @return IContextSource
*/
abstract public function getContext();
}