mediawiki-extensions-Discus.../.phpcs.xml

24 lines
1 KiB
XML
Raw Permalink Normal View History

<?xml version="1.0"?>
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude name="Generic.CodeAnalysis.AssignmentInCondition.Found" />
<exclude name="Generic.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition" />
<!--
Code such as this:
while ( ( $foo = $foo->nextSibling ) && someCondition( $foo ) ) { … }
is often convenient when working on DOM tree structures, which we do a lot of in this extension.
It's particularly helpful in combination with Phan, which can infer that `$foo` is non-null from
the code above, but it can't infer that `$foo->nextSibling` is non-null in code like this:
while ( $foo->nextSibling && someCondition( $foo->nextSibling ) ) { … }
When the variable is the only condition, we add extra parentheses to indicate that it isn't a
typo for `==`, which is a convention borrowed from C:
while ( ( $foo = $foo->nextSibling ) ) { … }
-->
</rule>
<file>.</file>
<arg name="extensions" value="php" />
<arg name="encoding" value="UTF-8" />
</ruleset>