mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/CookieWarning
synced 2024-11-27 15:40:16 +00:00
37c6d7d217
If geolocation is done at client-side, it was displaying the warning without checking the dismissed cookie. Now the main module will remove it if the cookie exists, and the geolocation service won't display it again. The idea of doing geolocation at client side rather than server side is to allow more pages cached at varnish/squid, but it still required to let the dismissed cookie break the cache. With this change, the dismissed cookie can be blocked at the varnish/squid level, all pages will contain the cookie warning notice, but it will be left hidden by the client-side script instead of displaying it. In addition, the click handler for .mw-cookiewarning-dismiss has been put inside a DOMready handler to prevent this code fire before the element becomes available. Bug: T183657 Change-Id: I5f7505dbd650867155485d17fff58fb92800581b |
||
---|---|---|
.. | ||
ext.CookieWarning | ||
ext.CookieWarning.geolocation |