There's a lot of things going on here, so a quick summary:
* Moved the warning outside sitenotice to avoid reflows and all
kinds of other issues, including those with dismissable notices.
* Placed the warning on the bottom of the page, on all skins, for
consistency and to avoid obstructing vital UI elements such as
site name, user tools, search box.
* Changed the UI to use OOUI for, again, consistency and to avoid
reinventing the wheel with button styling.
* Removed the cookie emoji as it was only taking up valuable space
on mobile and making designing a sensible layout much harder.
* Merged the mobile and desktop RL modules into a single, responsive
one. The warning will work correctly for any skin and screen width.
* The integration tests are truly horrible, I tried to at least
make them work. They deserve a proper rewrite, but that should be
done after the extension switches to the new hook system.
I will post screenshots of this in action in the first of the linked
tasks.
Bug: T271047
Bug: T173335
Change-Id: I6e2a3d7aeccc0d4df1b3238e52c67e72099d27d8
The service was shutdown in 2018 and is not reachable anymore. Having a
default value in the extension to a service that doesn't exist anymore
seems awkward.
Bug: T201752
Change-Id: I998926f17a462909773f7121771deaa4b4b1c2c7
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPrivate
Additional changes:
* Dropped .php5 and .inc files from .phpcs.xml (T200956).
* Added the `wikimedia/mediawiki` profile in .eslintrc.json (T262222).
Change-Id: Ibaf2ade250d030974492a05c839ad2adf9765572
Use an anonymous class to implement QuickTemplate instead of relying on a
specific implementation that no longer exists.
Change-Id: Ifbd47e6fa3aff8c1969e8510edbfd16507025ed2
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.FunctionComment.NoParamType
The following sniffs now pass and were enabled:
* MediaWiki.Commenting.FunctionComment.MissingParamName
* MediaWiki.Commenting.FunctionComment.MissingParamTag
Additional changes:
* Replaced "jakub-onderka" packages with "php-parallel-lint".
Change-Id: Ia29758a25f3aee903130481495071fcdf6e5033d
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.FunctionComment.MissingParamName
* MediaWiki.Commenting.FunctionComment.MissingParamTag
Change-Id: I2bf1056772f560b6f4ead4d1794c6f7c50eec59d
* eslint-config-wikimedia: 0.5.0 → 0.15.0
The following rules are failing and were disabled:
* no-prototype-builtins
* grunt-eslint: 20.1.0 → 22.0.0
* grunt-stylelint: 0.10.1 → 0.13.0
* stylelint-config-wikimedia: 0.4.3 → 0.8.0
The following rules are failing and were disabled:
* rule-empty-line-before
Additional changes:
* Remove direct "stylelint" dependency in favor of "grunt-stylelint".
* Also sorted "composer fix" command to run phpcbf last.
* Removing manual reportUnusedDisableDirectives for eslint.
Change-Id: I5218ef05353b85925bff7fdd4d5eeae0a71ccac2
