Commit graph

6 commits

Author SHA1 Message Date
Ostrzyciel 4f3981580d Move the warning outside sitenotice, tidy up code
There's a lot of things going on here, so a quick summary:
* Moved the warning outside sitenotice to avoid reflows and all
  kinds of other issues, including those with dismissable notices.
* Placed the warning on the bottom of the page, on all skins, for
  consistency and to avoid obstructing vital UI elements such as
  site name, user tools, search box.
* Changed the UI to use OOUI for, again, consistency and to avoid
  reinventing the wheel with button styling.
* Removed the cookie emoji as it was only taking up valuable space
  on mobile and making designing a sensible layout much harder.
* Merged the mobile and desktop RL modules into a single, responsive
  one. The warning will work correctly for any skin and screen width.
* The integration tests are truly horrible, I tried to at least
  make them work. They deserve a proper rewrite, but that should be
  done after the extension switches to the new hook system.

I will post screenshots of this in action in the first of the linked
tasks.

Bug: T271047
Bug: T173335
Change-Id: I6e2a3d7aeccc0d4df1b3238e52c67e72099d27d8
(cherry picked from commit edd0a7d949)
2021-02-01 17:56:50 +00:00
Paladox 48f795df08 Replace deprecated hook
Bug: T254302
Change-Id: I140af90b5f175974eb20873f2c1c6449be5a6669
(cherry picked from commit 0dc0e795a1)
2020-11-29 23:46:51 +00:00
Kunal Mehta fc561f35cc Don't double escape $moreLink
Html::element() automatically escapes all attribute values.

Spotted by the phan-taint-check-plugin.

Change-Id: Iad90d48ccba5b7008f5869c7c9f2b280400df749
2018-08-25 00:59:19 -07:00
Zoranzoki21 cfa56cdcb3 Fix 'Retrun' typo
Bug: T201491
Change-Id: I54ae64595d6ef393c60f112695d6d866b653c780
2018-08-14 09:40:40 +00:00
Fomafix 42fca811c6 Use \u{00A0} instead of   or  
Directly use the UTF-8 encoding of the 'NO-BREAK SPACE' (U+00A0) instead of
the HTML/XML entitiy  .

Also use \u{1F36A} instead of 🍪 for Unicode Character 'COOKIE'
(U+1F36A).

Bug: T154300
Change-Id: I13536589a4c183215785fe3352f4fc081571451b
2018-08-10 20:58:11 +02:00
Florian Schmidt 90d2e58096 Move classes into CookieWarning namespace
This should make the code a bit more structured and easier to navigate
through. It also removes some lines from extension.json as the autoload
classes list is replaced by an autoload namespaces property.

This also changes the minimum requirement of MediaWiki to 1.31 for this
extension to work.

Change-Id: I249ccc3035297c99202a5f83fcc8d3fda68b682c
2018-07-19 12:57:52 +02:00
Renamed from includes/CookieWarningHooks.php (Browse further)