The following sniffs are failing and were disabled:
* MediaWiki.Commenting.FunctionComment.MissingParamName
* MediaWiki.Commenting.FunctionComment.MissingParamTag
Change-Id: I2bf1056772f560b6f4ead4d1794c6f7c50eec59d
* eslint-config-wikimedia: 0.5.0 → 0.15.0
The following rules are failing and were disabled:
* no-prototype-builtins
* grunt-eslint: 20.1.0 → 22.0.0
* grunt-stylelint: 0.10.1 → 0.13.0
* stylelint-config-wikimedia: 0.4.3 → 0.8.0
The following rules are failing and were disabled:
* rule-empty-line-before
Additional changes:
* Remove direct "stylelint" dependency in favor of "grunt-stylelint".
* Also sorted "composer fix" command to run phpcbf last.
* Removing manual reportUnusedDisableDirectives for eslint.
Change-Id: I5218ef05353b85925bff7fdd4d5eeae0a71ccac2
Making GeoLocation an interface makes it easier to replace the underlying implementation
from the current Http backed method.
Change-Id: I2beb97772fd74ab08b2214c08d82dbc1ebfcdcd2
Also fix tests relying on MessageCache. MessageCache is enabled in setup,
however, as setMwGlobals is resetting services, it gets disabled again.
Instead of setting the configuration to enable the use of database
messages, let's enable the message cache after the last reset of services.
Change-Id: Iff670def50ab15054099f7a1ca3adc119bd877ce
This ensures that each repository's "npm test" command is fully
independent of wherever it might be in the filesystem.
Bug: T206485
Change-Id: I154827ec97a7d379a42e3fbb04d562b1a844975c
Removed old csslint package and added grunt-stylelint and stylelint
config for Wikimedia. Fixed the violations caused by this change.
Bug: T206506
Change-Id: Ieb1f087de859f5321c4f1fe65c0e3bf7b655ca15
Html::element() automatically escapes all attribute values.
Spotted by the phan-taint-check-plugin.
Change-Id: Iad90d48ccba5b7008f5869c7c9f2b280400df749
Directly use the UTF-8 encoding of the 'NO-BREAK SPACE' (U+00A0) instead of
the HTML/XML entitiy  .
Also use \u{1F36A} instead of 🍪 for Unicode Character 'COOKIE'
(U+1F36A).
Bug: T154300
Change-Id: I13536589a4c183215785fe3352f4fc081571451b
The change 4649d2110f requires 1.32+
because it depends on I0afdc8ab50bc1354bb5099bf39923c07eab0b665 from
core included in 1.32.
Change-Id: Ia2582b6598024dd229df615df50b7d1a9eb9116b
If any error occured during locating the IP address, the extension should
assume, that the user is in a configured region and show the cookie warning,
if not already dismissed.
Bug: T200077
Change-Id: Ib7f0dd0a135071924281a576ab24887d5e226435
This should make the code a bit more structured and easier to navigate
through. It also removes some lines from extension.json as the autoload
classes list is replaced by an autoload namespaces property.
This also changes the minimum requirement of MediaWiki to 1.31 for this
extension to work.
Change-Id: I249ccc3035297c99202a5f83fcc8d3fda68b682c
Instead of always looking up a single IP address, even for multiple
requests, cache the result of the first lookup. IP addresses usually
doesn't move that fast, caching the result should therefore be
reasonably ok.
Change-Id: Ice78ec08ff886e77c542a75086610498eaa6c6b4
This cleans up the hook file a lot and movesthe logic to seperate services
provided by MediaWikiServices. This also removes some setters and passed-
around variables and stuff. Also fixes the unit tests by not querying
external services anymore.
Change-Id: I0c3c0b7f2f5bd68aaad624e8e2dcad9bdcf97770
