Commit graph

19 commits

Author SHA1 Message Date
ZabeMath 7e23848ac9 Avoid using User::getBoolOption()
User::getBoolOption() is deprecated and should be replaced with UserOptionsLookup::getBoolOption()

Bug: T277600
Change-Id: I562b19ca41a7ef18be940ec398d58d6873b2555b
2021-03-30 20:31:57 +00:00
Ostrzyciel edd0a7d949 Move the warning outside sitenotice, tidy up code
There's a lot of things going on here, so a quick summary:
* Moved the warning outside sitenotice to avoid reflows and all
  kinds of other issues, including those with dismissable notices.
* Placed the warning on the bottom of the page, on all skins, for
  consistency and to avoid obstructing vital UI elements such as
  site name, user tools, search box.
* Changed the UI to use OOUI for, again, consistency and to avoid
  reinventing the wheel with button styling.
* Removed the cookie emoji as it was only taking up valuable space
  on mobile and making designing a sensible layout much harder.
* Merged the mobile and desktop RL modules into a single, responsive
  one. The warning will work correctly for any skin and screen width.
* The integration tests are truly horrible, I tried to at least
  make them work. They deserve a proper rewrite, but that should be
  done after the extension switches to the new hook system.

I will post screenshots of this in action in the first of the linked
tasks.

Bug: T271047
Bug: T173335
Change-Id: I6e2a3d7aeccc0d4df1b3238e52c67e72099d27d8
2021-02-01 11:23:53 +01:00
Paladox 0dc0e795a1 Replace deprecated hook
Bug: T254302
Change-Id: I140af90b5f175974eb20873f2c1c6449be5a6669
2020-11-22 15:48:59 +00:00
Kunal Mehta 2729a661c3 Unbreak tests
Use an anonymous class to implement QuickTemplate instead of relying on a
specific implementation that no longer exists.

Change-Id: Ifbd47e6fa3aff8c1969e8510edbfd16507025ed2
2020-07-13 12:54:21 -07:00
Florian Schmidt 6634e8c829 Enable GeoLocation service being replaced by other providers
Making GeoLocation an interface makes it easier to replace the underlying implementation
from the current Http backed method.

Change-Id: I2beb97772fd74ab08b2214c08d82dbc1ebfcdcd2
2019-11-21 17:31:23 +01:00
Paladox 6ecc3fd4fc Fix tests to be compatible with master again
Also fix tests relying on MessageCache. MessageCache is enabled in setup,
however, as setMwGlobals is resetting services, it gets disabled again.
Instead of setting the configuration to enable the use of database
messages, let's enable the message cache after the last reset of services.

Change-Id: Iff670def50ab15054099f7a1ca3adc119bd877ce
2019-11-19 00:40:51 +01:00
Fomafix 42fca811c6 Use \u{00A0} instead of   or  
Directly use the UTF-8 encoding of the 'NO-BREAK SPACE' (U+00A0) instead of
the HTML/XML entitiy  .

Also use \u{1F36A} instead of 🍪 for Unicode Character 'COOKIE'
(U+1F36A).

Bug: T154300
Change-Id: I13536589a4c183215785fe3352f4fc081571451b
2018-08-10 20:58:11 +02:00
Florian Schmidt 1a2dd83c15 Use wgUseMediaWikiUIEverywhere true in tests
This seems to be the default for Jenkins CI.

Bug: T201359
Change-Id: Ie436c601a95957b3c3fc2bfcce6d12bdef69e76a
2018-08-06 22:22:32 +02:00
Florian Schmidt 90d2e58096 Move classes into CookieWarning namespace
This should make the code a bit more structured and easier to navigate
through. It also removes some lines from extension.json as the autoload
classes list is replaced by an autoload namespaces property.

This also changes the minimum requirement of MediaWiki to 1.31 for this
extension to work.

Change-Id: I249ccc3035297c99202a5f83fcc8d3fda68b682c
2018-07-19 12:57:52 +02:00
Florian Schmidt 6f519c9618 Add caching functionality for IP lookup
Instead of always looking up a single IP address, even for multiple
requests, cache the result of the first lookup. IP addresses usually
doesn't move that fast, caching the result should therefore be
reasonably ok.

Change-Id: Ice78ec08ff886e77c542a75086610498eaa6c6b4
2018-07-18 16:03:29 +02:00
Florian Schmidt fed15fd7a5 Refactor Hooks code and move it to separate services
This cleans up the hook file a lot and movesthe logic to seperate services
provided by MediaWikiServices. This also removes some setters and passed-
around variables and stuff. Also fixes the unit tests by not querying
external services anymore.

Change-Id: I0c3c0b7f2f5bd68aaad624e8e2dcad9bdcf97770
2018-07-18 12:59:17 +02:00
jdlrobson 60929abb69 Drop Minerva LESS dependency
* Instead of repeating CSS already in Minerva instead use an element
"banner-container" already in use by CentralNotice (given this is also a banner)
This removes the need for positioning styles at Minerva is delegated to handle that.
* Rewrite existing rules using mediawiki ui variables to make clearer line-height
relates to iconography

Bug: T140807
Change-Id: I1bd3fb164bbb7866e5d32367c66afae5c1933bcb
2018-05-19 11:51:16 +02:00
Fomafix eb27449d70 Fix phpcs exclude rules
Change-Id: Ia39e6189d666af7d6fe1ccd14e8e7cae277a4428
2018-03-30 22:59:10 +02:00
Kunal Mehta 3675acc182 Add @covers tag
Change-Id: Ie424a310f6a30c820cb692fa2ddcb25087868837
2018-01-23 16:24:33 -08:00
Florian Schmidt 9b342e875b Redesign mobile CookieWarning banner
Based on design input from Reading web team (Nirzar).

Bug: T146077
Change-Id: I99aa74842486c4c397462dd51f55c272ae17ad07
2017-01-11 23:06:25 +01:00
Florian Schmidt c35b78fae8 Add option to limit the cookie warning to specific regions
With this change, CookieWarning gets two new ways to limit the warning
bar to users of specific (configurable) regions. Based on the geo location
service (which can be configured, too, defaults to freegeoip.net), the
extension will try to get the region of the user (based on the IP address)
and checks it against the configured regions.

With the configuration variable $wgCookieWarningGeoIPLookup, the wiki sysadmin
can configure, if the lookup should be done with PHP (the timeout for the
request is hardcoded to 2 sedonds max), which will save the paylod sent to
the user, or with JavaScript, which will be asynchronous.

Deactivating this feature is easily done by simply setting the configured regions
to false, instead of an object.

Bug: T145780
Change-Id: I4d9371b8608ef270c11c42bdb3a773675977ab3a
2016-10-07 23:51:18 +02:00
Florian Schmidt 12137c66d8 Use short array syntax instead of array()
Change-Id: I22f24bf047ff8bb476000bfbf879cc7612c10c27
2016-09-18 00:36:56 +02:00
Paladox 828d31625c Fix tests
Change-Id: I761c8eea6c0ecc55f02ce86259c5afc83d6a96a9
2016-09-18 00:18:56 +02:00
Florian Schmidt dcebb9bb04 Add the possibility to edit the more information link on-wiki
Instead of just the configuration variable $wgCookieWarningMoreUrl,
CookirWarning now allows also to set the link on-wiki using the interface
message MediaWiki:Cookiewarning-more-link. It also "listens" for the
MediaWiki:Cookie-policy-link interface message, which is introduced by
Cookie Policy as a first step for merging these both extensions.

Bug: T145781
Change-Id: I818008b2da6d9acd4295857e2916cd1b4637bee9
2016-09-15 23:53:27 +02:00