wikimedia/mediawiki-extensions-CookieWarning
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/CookieWarning synced 2024-11-23 22:03:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't double escape $moreLink

Browse source 
Html::element() automatically escapes all attribute values.

Spotted by the phan-taint-check-plugin.

Change-Id: Iad90d48ccba5b7008f5869c7c9f2b280400df749
This commit is contained in:
Kunal Mehta 2018-08-25 00:59:19 -07:00
parent cfa56cdcb3
commit fc561f35cc
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
includes/Hooks.php
View file

@ -141,12 +141,12 @@ class Hooks {
$cookieWarningMessage = wfMessage( 'cookiewarning-more-link' );
if ( $cookieWarningMessage->exists() && !$cookieWarningMessage->isDisabled() ) {
return $cookieWarningMessage->escaped();
return $cookieWarningMessage->text();
}
$cookiePolicyMessage = wfMessage( 'cookie-policy-link' );
if ( $cookiePolicyMessage->exists() && !$cookiePolicyMessage->isDisabled() ) {
return $cookiePolicyMessage->escaped();
return $cookiePolicyMessage->text();
}
return null;