mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/ConfirmEdit
synced 2024-12-22 12:52:45 +00:00
da22e2c767
* Reduces use of whitelist * Deprecates and provides new $wg to replace $wgCaptchaWhitelistIP and $wgCaptchaWhitelist Bug: T277936 Change-Id: I9c4a572321bb06e5a1d4208a295e21b73e75b787
192 lines
5.6 KiB
PHP
192 lines
5.6 KiB
PHP
<?php
|
|
|
|
use MediaWiki\Config\HashConfig;
|
|
use MediaWiki\Context\RequestContext;
|
|
use MediaWiki\Extension\ConfirmEdit\CaptchaTriggers;
|
|
use MediaWiki\Extension\ConfirmEdit\SimpleCaptcha\SimpleCaptcha;
|
|
use MediaWiki\Registration\ExtensionRegistry;
|
|
use MediaWiki\Request\WebRequest;
|
|
use MediaWiki\Title\Title;
|
|
use MediaWiki\User\User;
|
|
use Wikimedia\ScopedCallback;
|
|
use Wikimedia\TestingAccessWrapper;
|
|
|
|
/**
|
|
* @covers \MediaWiki\Extension\ConfirmEdit\SimpleCaptcha\SimpleCaptcha
|
|
*/
|
|
class CaptchaTest extends MediaWikiIntegrationTestCase {
|
|
|
|
/** @var ScopedCallback[] */
|
|
private $hold = [];
|
|
|
|
public function tearDown(): void {
|
|
// Destroy any ScopedCallbacks being held
|
|
$this->hold = [];
|
|
parent::tearDown();
|
|
}
|
|
|
|
/**
|
|
* @dataProvider provideSimpleTriggersCaptcha
|
|
*/
|
|
public function testTriggersCaptcha( $action, $expectedResult ) {
|
|
$captcha = new SimpleCaptcha();
|
|
$this->overrideConfigValue( 'CaptchaTriggers', [
|
|
$action => $expectedResult,
|
|
] );
|
|
$this->assertEquals( $expectedResult, $captcha->triggersCaptcha( $action ) );
|
|
}
|
|
|
|
public static function provideSimpleTriggersCaptcha() {
|
|
$data = [];
|
|
$captchaTriggers = new ReflectionClass( CaptchaTriggers::class );
|
|
$constants = $captchaTriggers->getConstants();
|
|
foreach ( $constants as $const ) {
|
|
$data[] = [ $const, true ];
|
|
$data[] = [ $const, false ];
|
|
}
|
|
return $data;
|
|
}
|
|
|
|
/**
|
|
* @dataProvider provideBooleans
|
|
*/
|
|
public function testNamespaceTriggersOverwrite( bool $expected ) {
|
|
$trigger = 'edit';
|
|
$captcha = new SimpleCaptcha();
|
|
$this->overrideConfigValues( [
|
|
'CaptchaTriggers' => [
|
|
$trigger => !$expected,
|
|
],
|
|
'CaptchaTriggersOnNamespace' => [
|
|
0 => [
|
|
$trigger => $expected,
|
|
],
|
|
],
|
|
] );
|
|
$title = Title::newFromText( 'Main' );
|
|
$this->assertEquals( $expected, $captcha->triggersCaptcha( $trigger, $title ) );
|
|
}
|
|
|
|
private function setCaptchaTriggersAttribute( $trigger, $value ) {
|
|
// Avoid clobbering captcha triggers registered by other extensions
|
|
$this->overrideConfigValue( 'CaptchaTriggers', $GLOBALS['wgCaptchaTriggers'] );
|
|
|
|
$this->hold[] = ExtensionRegistry::getInstance()->setAttributeForTest(
|
|
'CaptchaTriggers', [ $trigger => $value ]
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @dataProvider provideBooleans
|
|
*/
|
|
public function testCaptchaTriggersAttributeSetTrue( bool $value ) {
|
|
$trigger = 'test';
|
|
$this->setCaptchaTriggersAttribute( $trigger, $value );
|
|
$captcha = new SimpleCaptcha();
|
|
$this->assertEquals( $value, $captcha->triggersCaptcha( $trigger ) );
|
|
}
|
|
|
|
/**
|
|
* @dataProvider provideBooleans
|
|
*/
|
|
public function testCaptchaTriggersAttributeGetsOverwritten( bool $expected ) {
|
|
$trigger = 'edit';
|
|
$this->overrideConfigValue( 'CaptchaTriggers', [ $trigger => $expected ] );
|
|
$this->setCaptchaTriggersAttribute( $trigger, !$expected );
|
|
$captcha = new SimpleCaptcha();
|
|
$this->assertEquals( $expected, $captcha->triggersCaptcha( $trigger ) );
|
|
}
|
|
|
|
/**
|
|
* @dataProvider provideBooleans
|
|
*/
|
|
public function testCanSkipCaptchaUserright( bool $userIsAllowed ) {
|
|
$testObject = new SimpleCaptcha();
|
|
$user = $this->createMock( User::class );
|
|
$user->method( 'isAllowed' )->willReturn( $userIsAllowed );
|
|
|
|
$actual = $testObject->canSkipCaptcha( $user, RequestContext::getMain()->getConfig() );
|
|
|
|
$this->assertEquals( $userIsAllowed, $actual );
|
|
}
|
|
|
|
public static function provideBooleans() {
|
|
yield [ true ];
|
|
yield [ false ];
|
|
}
|
|
|
|
/**
|
|
* @dataProvider provideCanSkipCaptchaMailconfirmed
|
|
*/
|
|
public function testCanSkipCaptchaMailconfirmed( $allowUserConfirmEmail,
|
|
$userIsMailConfirmed, $expected ) {
|
|
$testObject = new SimpleCaptcha();
|
|
$user = $this->createMock( User::class );
|
|
$user->method( 'isEmailConfirmed' )->willReturn( $userIsMailConfirmed );
|
|
$config = new HashConfig( [ 'AllowConfirmedEmail' => $allowUserConfirmEmail ] );
|
|
|
|
$actual = $testObject->canSkipCaptcha( $user, $config );
|
|
|
|
$this->assertEquals( $expected, $actual );
|
|
}
|
|
|
|
public static function provideCanSkipCaptchaMailconfirmed() {
|
|
return [
|
|
[ false, false, false ],
|
|
[ false, true, false ],
|
|
[ true, false, false ],
|
|
[ true, true, true ],
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @dataProvider provideCanSkipCaptchaBypassIPList
|
|
*/
|
|
public function testCanSkipCaptchaBypassIP( $requestIP, $list, $expected ) {
|
|
$testObject = new SimpleCaptcha();
|
|
$config = new HashConfig( [ 'AllowConfirmedEmail' => false ] );
|
|
$request = $this->createMock( WebRequest::class );
|
|
$request->method( 'getIP' )->willReturn( $requestIP );
|
|
|
|
$this->setMwGlobals( [
|
|
'wgRequest' => $request,
|
|
] );
|
|
$this->overrideConfigValue( 'CaptchaBypassIPs', $list );
|
|
|
|
$actual = $testObject->canSkipCaptcha( RequestContext::getMain()->getUser(), $config );
|
|
|
|
$this->assertEquals( $expected, $actual );
|
|
}
|
|
|
|
public static function provideCanSkipCaptchaBypassIPList() {
|
|
return ( [
|
|
[ '127.0.0.1', [ '127.0.0.1', '127.0.0.2' ], true ],
|
|
[ '127.0.0.1', [], false ]
|
|
]
|
|
);
|
|
}
|
|
|
|
public function testTriggersCaptchaReturnsEarlyIfCaptchaSolved() {
|
|
$this->overrideConfigValue( 'CaptchaTriggers', [
|
|
'edit' => true,
|
|
] );
|
|
$testObject = new SimpleCaptcha();
|
|
/** @var SimpleCaptcha $wrapper */
|
|
$wrapper = TestingAccessWrapper::newFromObject( $testObject );
|
|
$wrapper->captchaSolved = true;
|
|
$this->assertFalse( $testObject->triggersCaptcha( 'edit' ), 'CAPTCHA is not triggered if already solved' );
|
|
}
|
|
|
|
public function testForceShowCaptcha() {
|
|
$this->overrideConfigValue( 'CaptchaTriggers', [
|
|
'edit' => false,
|
|
] );
|
|
$testObject = new SimpleCaptcha();
|
|
$this->assertFalse(
|
|
$testObject->triggersCaptcha( 'edit' ), 'CAPTCHA is not triggered by edit action in this configuration'
|
|
);
|
|
$testObject->setForceShowCaptcha( true );
|
|
$this->assertTrue( $testObject->triggersCaptcha( 'edit' ), 'Force showing a CAPTCHA if flag is set' );
|
|
}
|
|
}
|