mediawiki-extensions-Confir.../tests/phpunit/SimpleCaptcha/CaptchaTest.php
Eddie Greiner-Petter 2848a699db Move "can user skip captchas" check to own function
As a direct effect
- sending emails and creating accounts now respects $wgAllowConfirmedEmail
- log messages get a bit less verbose for mail sending and creating
  accounts (but should be clear from the context what action was
  performed)
- less code duplication \o/

Indirectly, this should make solving the attached bug easy(tm), because it
just needs to add a hook to the canSkipCaptcha function.

Bug: T176589
Change-Id: Id27b0eadbab7300b9e6969d406fa6f00ef0888bf
2018-05-19 13:27:04 +00:00

197 lines
5 KiB
PHP

<?php
/**
* @covers SimpleCaptcha
*/
class CaptchaTest extends MediaWikiTestCase {
/**
* @dataProvider provideSimpleTriggersCaptcha
*/
public function testTriggersCaptcha( $action, $expectedResult ) {
$captcha = new SimpleCaptcha();
$this->setMwGlobals( [
'wgCaptchaTriggers' => [
$action => $expectedResult,
]
] );
$this->assertEquals( $expectedResult, $captcha->triggersCaptcha( $action ) );
}
public function provideSimpleTriggersCaptcha() {
$data = [];
$captchaTriggers = new ReflectionClass( CaptchaTriggers::class );
$constants = $captchaTriggers->getConstants();
foreach ( $constants as $const ) {
$data[] = [ $const, true ];
$data[] = [ $const, false ];
}
return $data;
}
/**
* @dataProvider provideNamespaceOverwrites
*/
public function testNamespaceTriggersOverwrite( $trigger, $expected ) {
$captcha = new SimpleCaptcha();
$this->setMwGlobals( [
'wgCaptchaTriggers' => [
$trigger => !$expected,
],
'wgCaptchaTriggersOnNamespace' => [
0 => [
$trigger => $expected,
],
],
] );
$title = Title::newFromText( 'Main' );
$this->assertEquals( $expected, $captcha->triggersCaptcha( $trigger, $title ) );
}
public function provideNamespaceOverwrites() {
return [
[ 'edit', true ],
[ 'edit', false ],
];
}
private function setCaptchaTriggersAttribute( $trigger, $value ) {
$info = [
'globals' => [],
'callbacks' => [],
'defines' => [],
'credits' => [],
'attributes' => [
'CaptchaTriggers' => [
$trigger => $value
]
],
'autoloaderPaths' => []
];
$registry = new ExtensionRegistry();
$class = new ReflectionClass( 'ExtensionRegistry' );
$instanceProperty = $class->getProperty( 'instance' );
$instanceProperty->setAccessible( true );
$instanceProperty->setValue( $registry );
$method = $class->getMethod( 'exportExtractedData' );
$method->setAccessible( true );
$method->invokeArgs( $registry, [ $info ] );
}
/**
* @dataProvider provideAttributeSet
*/
public function testCaptchaTriggersAttributeSetTrue( $trigger, $value ) {
$this->setCaptchaTriggersAttribute( $trigger, $value );
$captcha = new SimpleCaptcha();
$this->assertEquals( $value, $captcha->triggersCaptcha( $trigger ) );
}
public function provideAttributeSet() {
return [
[ 'test', true ],
[ 'test', false ],
];
}
/**
* @dataProvider provideAttributeOverwritten
*/
public function testCaptchaTriggersAttributeGetsOverwritten( $trigger, $expected ) {
$this->setMwGlobals( [
'wgCaptchaTriggers' => [
$trigger => $expected
]
] );
$this->setCaptchaTriggersAttribute( $trigger, !$expected );
$captcha = new SimpleCaptcha();
$this->assertEquals( $expected, $captcha->triggersCaptcha( $trigger ) );
}
public function provideAttributeOverwritten() {
return [
[ 'edit', true ],
[ 'edit', false ],
];
}
/**
* @dataProvider provideCanSkipCaptchaUserright
*/
public function testCanSkipCaptchaUserright( $userIsAllowed, $expected ) {
$testObject = new SimpleCaptcha();
$user = $this->getMock( User::class );
$user->method( 'isAllowed' )->willReturn( $userIsAllowed );
$actual = $testObject->canSkipCaptcha( $user, RequestContext::getMain()->getConfig() );
$this->assertEquals( $expected, $actual );
}
public function provideCanSkipCaptchaUserright() {
return [
[ true, true ],
[ false, false ]
];
}
/**
* @param $allowUserConfirmEmail
* @param $userIsMailConfirmed
* @param $expected
* @throws ConfigException
* @dataProvider provideCanSkipCaptchaMailconfirmed
*/
public function testCanSkipCaptchaMailconfirmed( $allowUserConfirmEmail,
$userIsMailConfirmed, $expected ) {
$testObject = new SimpleCaptcha();
$user = $this->getMock( User::class );
$user->method( 'isEmailConfirmed' )->willReturn( $userIsMailConfirmed );
$config = $this->getMock( Config::class );
$config->method( 'get' )->willReturn( $allowUserConfirmEmail );
$actual = $testObject->canSkipCaptcha( $user, $config );
$this->assertEquals( $expected, $actual );
}
public function provideCanSkipCaptchaMailconfirmed() {
return [
[ false, false, false ],
[ false, true, false ],
[ true, false, false ],
[ true, true, true ],
];
}
/**
* @param $requestIP
* @param $IPWhitelist
* @param $expected
* @throws ConfigException
* @dataProvider provideCanSkipCaptchaIPWhitelisted
*/
public function testCanSkipCaptchaIPWhitelisted( $requestIP, $IPWhitelist, $expected ) {
$testObject = new SimpleCaptcha();
$config = $this->getMock( Config::class );
$request = $this->getMock( WebRequest::class );
$request->method( 'getIP' )->willReturn( $requestIP );
$this->setMwGlobals( [
'wgRequest' => $request,
'wgCaptchaWhitelistIP' => $IPWhitelist
] );
$actual = $testObject->canSkipCaptcha( RequestContext::getMain()->getUser(), $config );
$this->assertEquals( $expected, $actual );
}
public function provideCanSkipCaptchaIPWhitelisted() {
return ( [
[ '127.0.0.1', [ '127.0.0.1', '127.0.0.2' ], true ],
[ '127.0.0.1', [], false ]
]
);
}
}