Commit graph

3329 commits

Author SHA1 Message Date
Amir Sarabadani bfbf0fb327 GenerateFancyCaptchas: Add ->disableSandbox() to shell command
->restrict( Shell::RESTRICT_NONE ) that was removed was by my mistake.

It ::restrict() is deprecated but the internal call, calls
->disableSandbox() when the value is zero.

Follows-Up: I7b71c2f6b1bf05a4f00f2367a795db093dc00867
Change-Id: I6c8ff91aca183bdaa2473d86a029561440ed2ab3
(cherry picked from commit a84d6f0fc2)
2024-01-24 11:20:06 +00:00
Amir Sarabadani 1e1e9e89ba GenerateFancyCaptchas: Use Shell::params() instead of ::unsafeParams()
::unsafeParams() is for when the params are raw strings while we turned
these into proper array which means they need proper quoting while being
appended to the main bash command.

Follows-Up: Iae3fdea224d896c1a7b53ce1fe7d849cb35a0401
Change-Id: I7b71c2f6b1bf05a4f00f2367a795db093dc00867
2024-01-22 14:56:22 +01:00
jenkins-bot 3935691f2f Merge "Turnstile: Minor cleanup" 2024-01-19 11:05:08 +00:00
Translation updater bot a754620fd5 Localisation updates from https://translatewiki.net.
Change-Id: Ie61b6d4d10cadb1e667bc01facd0c5f294d26606
2024-01-19 09:16:37 +01:00
Translation updater bot 602b8779c8 Localisation updates from https://translatewiki.net.
Change-Id: Ib6879b6b4b3bc8b0f1fa7ce52fc650222d3a0c02
2024-01-18 09:25:05 +01:00
Translation updater bot 89394063e9 Localisation updates from https://translatewiki.net.
Change-Id: I0b65c94cc5f7126bc9a5f77ed9aee8c2466468f2
2024-01-17 08:37:07 +01:00
jenkins-bot e8c7e95c28 Merge "Revert "Drop various class aliases"" 2024-01-17 05:19:47 +00:00
Gergő Tisza b52d63ee9d Revert "Drop various class aliases"
This reverts commit 3798d424e2.

Bug: T355198
Change-Id: I99ecee703cdfa06198eeede96e6c3bdda2d457e0
2024-01-17 04:46:58 +00:00
James D. Forrester 5d6a6aaedf *.py: Auto-fix using black
Change-Id: I4645717df655ac570c1fe6e69058082a1fa7ee6b
2024-01-16 12:26:13 -05:00
Amir Sarabadani e1c7392a8e Migrate away from deprecated wfShellExec
Change-Id: Iae3fdea224d896c1a7b53ce1fe7d849cb35a0401
2024-01-16 15:19:58 +00:00
Reedy 28f297f1f7 Add tox.ini for python linting
Base file from:
c4790b589b/tox.ini

Most failing rules disabled, rather than fixing now

Bug: T355090
Change-Id: Ie0f499809d84b94b95dddac9abd433c8f81e04ce
2024-01-16 15:18:51 +00:00
jenkins-bot 78d2312cb2 Merge "catpcha.py: Use opts.output" 2024-01-16 13:17:39 +00:00
Kosta Harlan d1bc02e2fb catpcha.py: Use opts.output
Script fails on macOS Python 3.9.2 otherwise, with "name 'output' is not
defined".

Change-Id: Id3df19b4a4dedf69f860f1a41348770ac1207377
2024-01-16 12:56:50 +00:00
Reedy 3798d424e2 Drop various class aliases
Move manual wgAutoloadClasses entries into TestAutoloadClasses

Change-Id: I4c85a2042ae591732b48bbf872277909a90675b4
2024-01-16 10:49:21 +00:00
jenkins-bot c60beba52d Merge "captcha.py: Increase number and position of random lines in the text" 2024-01-15 21:51:34 +00:00
Amir Sarabadani 172b3b53bf captcha.py: Increase number and position of random lines in the text
The current one doesn't add that many lines, this is making it much
better.

Bug: T141490
Change-Id: I25589457c9f7d5871b86b7c70747074b0ef98170
2024-01-15 21:00:07 +00:00
jenkins-bot a9cc16855e Merge "captcha(-old).py: Fix undefined variables and remove some unused ones" 2024-01-15 20:23:25 +00:00
Reedy 8d3afbd390 Turnstile: Minor cleanup
Bug: T319068
Follows-Up: I0d5a74655619975f0bf61b5b672159afe5f4fb00
Change-Id: I15c26957158f22a0b6d6abb9def0e84e73c63ddc
2024-01-15 20:04:49 +00:00
Jayden Bailey fbf6c1c7ea Add Turnstile support
This is a rudimentary implementation of Cloudflare's Turnstile captcha alternative.

Since it is fairly similar to ReCaptchaNoCaptcha, there is some duplicate code used here. I opted not to use the migration path that CF has for reCAPTCHA v2 and build this as a separate implementation. After T324925, it should be easy to refactor this code.

Users should set $wgTurnstileSiteKey and $wgTurnstileSecretKey as appropriate, based on details from the Cloudflare dashboard.

Bug: T319068
Change-Id: I0d5a74655619975f0bf61b5b672159afe5f4fb00
2024-01-15 19:31:24 +00:00
Reedy 1a305a40ee captcha(-old).py: Fix undefined variables and remove some unused ones
Change-Id: I13b46cceb68a0118274a1fe9d3547b193f62b53d
2024-01-15 19:05:27 +00:00
jenkins-bot 11213652b6 Merge "ApiFancyCaptchaReload: Mark as internal" 2024-01-15 17:50:20 +00:00
Reedy b2b1fd4c98 ApiFancyCaptchaReload: Mark as internal
Change-Id: I3477f762309ff6e276afee0c38d731cb05ed8ed6
2024-01-15 17:24:36 +00:00
Reedy 88320d3d3d FancyCaptcha: Fix default for $wgCaptchaClass
Follows-Up: I2933639f9cb50db2101c4765ce9d8f9069d253b8
Change-Id: Iebe8858e3d5fa6b32de9c1be7a0b6cb22355e6a3
2024-01-15 17:03:09 +00:00
Reedy 041d827799 captcha-old.py: Remove trailing semicolon
Change-Id: I7b6458fe24485c995c47c249d6572be37e39d1a1
2024-01-15 14:54:00 +00:00
Amir Sarabadani 69c7a8dbdc Add negative kerning and lines to captcha
This should throw off many off-the-shelf OCRs.

Credit for this patch is Brian Wolff, I just found the code and turned
it into a patch. License: GPL V2.

Examples of output of the patch: T141490#9459799

Bug: T141490
Co-authored-by: Brian Wolff <bawolff+wn@gmail.com>
Change-Id: Ia17157d45995b78c6a73f844dfe7d20d09564748
2024-01-15 14:56:54 +01:00
Translation updater bot cf1c91a174 Localisation updates from https://translatewiki.net.
Change-Id: If377340245c4bc82c7aec179303a6bec66de0ed0
2024-01-15 08:24:05 +01:00
James D. Forrester e620b3f4e9 build: Upgrade grunt-banana-checker from 0.11.0 to 0.11.1
Change-Id: Ia6fdcdaf930bc83278019dff529d52a929702486
2024-01-12 22:34:24 +00:00
James D. Forrester fc760b1c35 build: Upgrade eslint-config-wikimedia from 0.25.1 to 0.26.0
Change-Id: I492bb4215522bdb72967108f5cd11adfa37e59bb
2024-01-12 22:34:15 +00:00
James D. Forrester 96f458cdd6 */extension.json: Drop RL targets definitions, no longer honoured
Bug: T328497
Change-Id: Id8501de1d372b7eca8e49c669d401322b2a51371
2024-01-12 22:33:04 +00:00
James D. Forrester c171047dcb build: Update MediaWiki requirement to 1.42
All extensions in the MediaWiki tarball are expected to track MediaWiki's release directly.

Change-Id: Ia86fec849d2bcf7df66ae18bdf84b902524cec75
2024-01-12 14:10:15 -05:00
Translation updater bot b30f444b02 Localisation updates from https://translatewiki.net.
Change-Id: Ie487052545b8738946f4d007add2dc45f4f2a520
2024-01-12 08:59:59 +01:00
Translation updater bot f37281f439 Localisation updates from https://translatewiki.net.
Change-Id: I2f3bfccda18b0918b80df48be73fa0ce7e1de76c
2024-01-11 10:02:55 +01:00
Translation updater bot 09a8539b3d Localisation updates from https://translatewiki.net.
Change-Id: Ic767295b540e959b3e9f896f7a9da84fb267b027
2024-01-09 08:59:18 +01:00
Translation updater bot 1aceed5432 Localisation updates from https://translatewiki.net.
Change-Id: I714dbd48d5abf5b802bb39d4f2a730f51d6550e5
2024-01-08 09:15:04 +01:00
jenkins-bot d538bb701b Merge "captcha(-old).py: Support Pillow 10" 2024-01-05 04:47:08 +00:00
Translation updater bot 745c9d5158 Localisation updates from https://translatewiki.net.
Change-Id: I949b7ba42d217bb50b12e6c9321eee5d3a549d0d
2024-01-04 09:55:26 +01:00
Translation updater bot cabab2b499 Localisation updates from https://translatewiki.net.
Change-Id: Iabe9e0cbc23e38f14f132080dcf0e8d49dce803e
2024-01-02 10:15:50 +01:00
Reedy fbf8d90063 captcha(-old).py: Support Pillow 10
getsize() function was removed in version 10

Bug: T354099
Change-Id: I019a5a89de4340d73a938c907c0a6f5cc22a659c
2024-01-02 02:56:54 +00:00
Translation updater bot 2b15ffbb94 Localisation updates from https://translatewiki.net.
Change-Id: Ie5f89ec59cd5d7ded9d841df5893fdabe8657ac4
2023-12-29 19:21:47 +01:00
Translation updater bot 49acf503d7 Localisation updates from https://translatewiki.net.
Change-Id: Id76a2f7d8560c9ffc29aab1fa4cc32b3ed474487
2023-12-28 14:49:39 +01:00
Translation updater bot bace2bb2cf Localisation updates from https://translatewiki.net.
Change-Id: Iba2a398d49ed799a43172bfde3fc8faa89f718f3
2023-12-22 17:45:38 +01:00
jenkins-bot 99d4eed4c9 Merge "Store: Use the MicroStash store only and drop dead code" 2023-12-19 15:09:11 +00:00
Derick Alangi 6f2fbd1d00 Store: Use the MicroStash store only and drop dead code
In this patch, we can now make use of MicroStash only and
drop dead code.

At this point, we're sure that there are no captchas in the
main stash, freeing up this memory for other requests to use.

Bug: T336004
Change-Id: I6aa69636f2f94e3bd18afc66eac37146d00771d1
2023-12-19 14:45:50 +00:00
Translation updater bot 6761bd3c1d Localisation updates from https://translatewiki.net.
Change-Id: Iba77a826899b65f40adcdca891321f930a3a581c
2023-12-18 18:16:48 +01:00
Translation updater bot 055770fe76 Localisation updates from https://translatewiki.net.
Change-Id: Ie2f05ac3a729c19752d58540e126c3e8677fdf37
2023-12-14 08:27:17 +01:00
Bartosz Dziewoński 2c6fe24521
Move login attempt counting to a separate class
This has nothing to do with CAPTCHA generation, and the only thing it
needs from the SimpleCaptcha class is checking whether a CAPTCHA on
bad login is enabled at all.

Also improve comments in CaptchaPreAuthenticationProvider. I found the
session flag business really difficult to understand.

Change-Id: I8200531718aaa11effcb07539204e1a05ed432e0
2023-12-13 15:18:39 -08:00
Translation updater bot 8110ce02f8 Localisation updates from https://translatewiki.net.
Change-Id: I1c666855fe5e3e395242203981012599f743ea94
2023-12-13 08:40:39 +01:00
Translation updater bot a6a470d209 Localisation updates from https://translatewiki.net.
Change-Id: I8db4596aa54db65b9eeb5072c6319d5b956adfe7
2023-12-11 10:42:58 +01:00
Umherirrender 92bc1f3d2f Use namespaced classes
Changes to the use statements done automatically via script
Addition of missing use statements done manually

Change-Id: Id44f211320e56bc83e4c8f243369dc4eb562cf37
2023-12-11 00:07:55 +01:00
Translation updater bot c0e4d03c0f Localisation updates from https://translatewiki.net.
Change-Id: If4bda909769f47a797b82aa01dfe1c7d92862eb4
2023-12-08 14:45:16 +01:00