Commit graph

13 commits

Author SHA1 Message Date
Platonides c7b3019852 Don't check badlogin attempts in memcached if we are not configured to show captchas on bad login.
Solves problem reported in http://www.mediawiki.org/w/index.php?title=Extension_talk:ConfirmEdit&offset=20111218172150#Banned_user_got_banned_until_he_logs_in_9982
where "$wgCaptchaTriggers['badlogin'] = false was set to disable that captcha, but as the user had already passed the threshold, it still was shown.
2011-12-21 23:39:53 +00:00
Jeroen De Dauw 485ae0e303 kill wfGetIP 2011-12-13 21:24:03 +00:00
Amir E. Aharoni 5dfbdb2fb7 Followup to r102105. Removed dir="ltr" from the math expression so as not to force LTR direction, because in some contexts it can be right-to-left, for example with Eastern Arabic digits. Instead, I removed the spaces before and after the operator so that the Unicode algorithm will set the direction automatically. 2011-12-08 14:22:41 +00:00
Sam Reed 9e4951f262 Fix hook copy paste fail
Move rest of captcha params out of api/ApiEditPage.php
2011-11-23 20:37:13 +00:00
Sam Reed 80e9b337ee Kill the abstract Captcha class
Not used anywhere, everything else uses the SimpleCaptcha class as the base
2011-11-23 19:21:12 +00:00
Sam Reed 0a66fd76f1 MW_SUPPORTS_EDITFILTERMERGED has been in since r27416
Kill the alternate EditFilter hook usage (underlying code still used, probably wants refactoring at somepoint)

Simplify a boolean return
2011-11-23 19:18:30 +00:00
Sam Reed 64b6239348 * (bug 32609) API: Move captchaid/captchaword of action=edit from core to Captcha extension(s)
Left setting of wpCaptchaId and wpCaptchaWord in core. Can't think of a sane way to check and set them via an extension (subclass and override, or a hook). Annoyingly APIEditBeforeSave doesn't pass the params array
2011-11-23 19:09:57 +00:00
Amir E. Aharoni beb6a182eb FU r102105, escaped the quotes. 2011-11-05 16:54:21 +00:00
Amir E. Aharoni 3c9daa44ab Adding dir="ltr" to the label, to prevent wrong appearance of the arithmetic expression. 2011-11-05 16:50:55 +00:00
Happy-melon f856872f83 File missing from r86820. Actually these changes should have been committed in r86813... 2011-04-24 17:33:41 +00:00
Happy-melon 86f875a58a Beginnings of a rewrite of the captcha system in a more object-oriented fashion; currently although there are classes for different types of captcha, they don't actually represent a single captcha object, they're just confused frontend/backend messes. With the places captchas are inserted increasingly using HTMLForm, it makes eminent sense to introduce a HTMLCaptchaField, but that needs a more OOP implementation of the actual captcha, which I've started here. This is not finished and isn't actually implemented anywhere, but a) it's harmless, b) I don't want it to bitrot, and c) some feedback would always be appreciated, so here it is. 2011-04-24 11:47:03 +00:00
Happy-melon 54fa154b40 Introduce a CaptchaStore abstract class that CaptchaSessionStore and CaptchaCacheStore can extend. Some tidying, documentation and type hinting. 2011-04-24 11:41:49 +00:00
Happy-melon 1bbd72e5fd Reorganise files in ConfirmEdit 2011-04-23 11:44:47 +00:00
Renamed from ConfirmEdit_body.php (Browse further)