This broke account creation for apps.
< anomie>bd808: Very likely $wgRequest !==
$loginForm->getContext()->getRequest() in SimpleCaptcha::addNewAccountApiForm(), so when it
uses $wgRequest to check later on it doesn't see the parameter renames made by that hook
function.
This reverts commit 23c6f2f04f.
Change-Id: I793e7a987944d14c3be0eba4c4361793183a62b9
A missing captchaId usually isn't a server error, it's a request error, so return
an appropriate status code (400).
Bug: T92827
Change-Id: Ia04da583858a8450b8445ad69bc1ef2b7d05f061
Captcha.php inserts captcha in the header of Userlogin and Usercreate template.
This leads to inconsistent view because js,if enabled, moves the captcha before
submit button. Now the captcha is inserted at the 'extrafields' parameter just
before submit button in both the templates,for uniformity of view.
JS functionality in
resources/src/mediawiki.special/mediawiki.special.userlogin.common.js migrated
to backed in FancyCaptcha.class.php, so that the FancyCaptch is already styled
and positioned before 'submit'.
Depends on I82c68814e79cbc5aa250a308862c59fcbb6fd527
Depends on Ie95305b2e6dcbf527a23c92613755092185e6a05
Bug: T85192
Bug: T87190
Change-Id: If9a68aaee2cf98d63647816ccc8fc0bad12ca3d3
Modified getBackend() function to add values for WikiID and
lockmanager( array() )
Fixed spacing
Bug: 58614
Change-Id: I448579ac71809365d9f8c64eccfd2e08949f149d
This changes the CSS of the .fancycaptcha-image-container to allow
positioning within it, and repositions .fancycaptcha-reload at its
lower-right. The container is taller than nearly all images, but
there's a chance the ↻Refresh link might obscure part of a captcha
image.
This is compatible with the new Create account form's repositioning of
the FancyCaptcha inside a gray frame using JS, though gerrit I003c5f1b75
improves Create account once this is deployed.
Bug: 47699
Change-Id: I57be0bc8aa80b9ea6148db979ad28397d2107b86
This makes the icon and text a single item, so they don't split across
lines, and reduces code and messages.
Bug: 47398
Change-Id: If81313b9fe03693dcdc06d5d682f0ef9a9994f76
This adds HTML, CSS, and JS to FancyCaptcha output to refresh the image,
which requests it via a new fancycaptchareload API.
It also cleans up the Asirra class a little.
Bug: 14230
Change-Id: I4e476f32de199534c9798fc78e8490b3ef91dd45
* Added $wgCaptchaFileBackend configuration setting.
This causes captchas to be stored in the registered backend.
* Added $wgMemc usage to reduce directory operation I/O.
* Improved $wgCaptchaDeleteOnSolve in terms of race conditions.
* Added maintenance script to create and store new captchas based
on the total amount desired and the current number remaining.
Change-Id: Iac490503fb94a8f003e3b7e1474a949b037af5df
Warning: mt_rand() [<a href='function.mt-rand'>function.mt-rand</a>]: max(-1) is smaller than min(0) in /usr/local/apache/common-local/php-1.20wmf10/extensions/ConfirmEdit/FancyCaptcha.class.php on
line 135
Change-Id: I344504c133c84aea24ce38a4a4c05c2a0c12041b
* Removed unused globals and local variables.
* Use Message class.
* Remove PHP4-ism from recaptchalib.php.
* Remove superfluous newlines.
* Add missing semi-colon in ext.confirmedit.asirra.js.
* Fix up some documentation.
Change-Id: I8916003d083a8c00aeabc9e485cc9a50030f0982
Every field should have a descriptive label to clarify what is expected
to be entered.
Though users who are using screen readers are not able to retype the
text shown by the captcha image at least they know what the application
is expecting and may get help from other people.
The label text is also added to the translation arrays for English and
German language as well as the descriptive array 'qqq'.
Removed trailing whitespaces and redundant internationalization
according to reviewer's comment.
Removed usage of global $wgOut;
Change-Id: I975dddb60891b162a62e547bb83669c13cb133a1
* Hooking into the APIEditBeforeSave hook (which will appear in the ApiEdit_Vodafone branch in the next revision)
* Moved general CAPTCHA generation in SimpleCaptcha to getCaptcha()
* Moved general confirmEdit() functionality to doConfirmEdit() to facilitate differtiating between UI and API handling
* Adding SimpleCaptcha::addCaptchaAPI() method that adds CAPTCHA information to an API result array. Other CAPTCHA implementations should override this method with a function that does the same (did this for FancyCaptcha and MathCaptcha)
