thiemowmde
50f533c9e9
A few very minor code cleanups
...
A bunch of very minor code cleanups I collected in my local dev
environment the past months:
* Remove dead code.
* Make use of the ??= operator where possible.
* Fix inconsistent @var syntax.
Change-Id: Ie8de34f15503eb2bf0f6df855af55c212235dff3
2024-09-13 13:04:53 +02:00
Reedy
ec6f8c5fee
GenerateFancyCaptchas: Include stderr result if captcha.py returns an error code
...
Bug: T360653
Change-Id: Ie998180e5a74441c76e236074961cf0d34aaecaf
2024-03-21 16:40:49 +00:00
Reedy
86af079ed9
Deprecate use of captcha-old.py
...
Bug: T357930
Change-Id: I69a2e68d430d7a5769fb8b4391f1163ee99ad8fb
2024-02-19 19:11:43 +00:00
Reedy
cbbe6611b4
FancyCaptcha: Remove deprecated blacklist parameter
...
Bug: T277936
Depends-On: Ia467c4fb56e9920826a2e4e505e277683ab154b8
Change-Id: Ia64c20bf4638cdba85860dbd2852ee04f9498561
2024-01-27 15:07:32 +00:00
jenkins-bot
9625c91e18
Merge "FancyCaptcha: Allow configuration of the actual directory captchas are stored in"
2024-01-26 16:18:10 +00:00
Amir Sarabadani
a84d6f0fc2
GenerateFancyCaptchas: Add ->disableSandbox() to shell command
...
->restrict( Shell::RESTRICT_NONE ) that was removed was by my mistake.
It ::restrict() is deprecated but the internal call, calls
->disableSandbox() when the value is zero.
Follows-Up: I7b71c2f6b1bf05a4f00f2367a795db093dc00867
Change-Id: I6c8ff91aca183bdaa2473d86a029561440ed2ab3
2024-01-23 01:00:02 +01:00
Amir Sarabadani
1e1e9e89ba
GenerateFancyCaptchas: Use Shell::params() instead of ::unsafeParams()
...
::unsafeParams() is for when the params are raw strings while we turned
these into proper array which means they need proper quoting while being
appended to the main bash command.
Follows-Up: Iae3fdea224d896c1a7b53ce1fe7d849cb35a0401
Change-Id: I7b71c2f6b1bf05a4f00f2367a795db093dc00867
2024-01-22 14:56:22 +01:00
Amir Sarabadani
e1c7392a8e
Migrate away from deprecated wfShellExec
...
Change-Id: Iae3fdea224d896c1a7b53ce1fe7d849cb35a0401
2024-01-16 15:19:58 +00:00
Reedy
36bd54e4ec
FancyCaptcha: Allow configuration of the actual directory captchas are stored in
...
Change-Id: Iecc48db5237adc5b89c99019faac0af425e4eb5d
2024-01-15 15:43:46 +00:00
Umherirrender
92bc1f3d2f
Use namespaced classes
...
Changes to the use statements done automatically via script
Addition of missing use statements done manually
Change-Id: Id44f211320e56bc83e4c8f243369dc4eb562cf37
2023-12-11 00:07:55 +01:00
Reedy
a0feac27b0
Namespace captchas
...
Change-Id: I2933639f9cb50db2101c4765ce9d8f9069d253b8
2022-12-13 21:40:30 +00:00
Reedy
30cd1d8a23
Namespace base classes
...
Change-Id: I3fa9747e0ea970c5de39e2da8603e1bba9388a69
2022-07-30 18:13:03 +00:00
Reedy
db06ec876b
FancyCaptcha: Deprecate and add alternative for blacklist parameter in generation
...
Bug: T277936
Change-Id: I8e758023b38a4d450a0bf02b3bfc0b5033959be7
2022-07-04 16:16:20 +00:00
Reedy
5876e3bd38
DeleteOldFancyCaptchas: Add some simple chunking to actual delete operation
...
Change-Id: Ia8f7dcc170a1e9a72313d72ac22ad7e6b3c97aa8
2021-11-16 14:53:30 +00:00
Reedy
3b9ab99b1d
Make GenerateFancyCaptchas.php execute captcha(-old)?.py via python3
...
Bug: T268468
Change-Id: I3d5113d1a83eea9f711ee2bb206fe9423431b887
2020-12-01 18:28:00 +00:00
Reedy
297897220c
Use $this->fatalError() where $this->error() is called with $die > 1
...
Change-Id: Ia8cf34437661f53a2c28bc9e2077fe5c7c8103de
2020-09-18 17:11:56 +01:00
libraryupgrader
d481d0c8db
build: Updating mediawiki/mediawiki-phan-config to 0.9.0
...
Additional changes:
* Added .eslintcache to .gitignore.
* Fix wrong types
Change-Id: I833b061c62b82f3c88d968c70bae8317641aaa3d
2019-12-27 14:42:40 +00:00
Umherirrender
071ce05bfe
Use correct default value for Status::getWikiText
...
Change-Id: If9e4f297ce8435bd9001b5a8f5b15f9b127749e3
2019-12-12 19:59:33 +01:00
jenkins-bot
1a3875db83
Merge "Output some leading newlines and specify script being run"
2019-10-18 00:41:47 +00:00
Reedy
33351c2392
Make the description for --delete more specific
...
s/captches/captchas/ too
Point out verbose only affects captcha python script
Change-Id: I97f89427a62a7b8d26fb09641422433ded81f594
2019-10-16 21:31:43 +00:00
Reedy
0f5f6e44af
Output some leading newlines and specify script being run
...
Change-Id: Ic51bdcd656297491fc6f0f09a3b5c2474d2e07a8
2019-10-16 22:08:07 +01:00
jenkins-bot
1b98b8f6c1
Merge "Pass 'adviseStat' => true to ->getFileList() in DeleteOldFancyCaptchas.php"
2019-10-16 15:56:45 +00:00
Reedy
330d59feba
Output number of captchas to be deleted before actually deleting
...
Change-Id: If9cbabe2097f32129ed3ea383b7c86552392e4cb
2019-10-16 00:10:35 +01:00
Reedy
50f8738984
Pass 'adviseStat' => true to ->getFileList() in DeleteOldFancyCaptchas.php
...
As ->getFileTimestamp() presumably counts as 'stat'-ing the files
Change-Id: Ia187dbc369ff56f154cae2ee46e3e9cd20def933
2019-10-16 00:06:22 +01:00
Umherirrender
19e6d4d902
Use Maintenance::addDescription
...
It is better to use a setter function than setting a property
Change-Id: I173b3f4af54cf8f6427895e1e170ec97e10d4f3d
2019-08-19 19:03:36 +02:00
Umherirrender
911086980b
Improve error messages on deleteOldFancyCaptchas maintenance script
...
StatusValue::getErrors returns an array of messages, not strings.
It cannot be use on implode(). Use wikitext as it the most readable on
the console
Change-Id: I4b794597f9bf35d3bc34c7d2c7691ee53d43b017
2019-05-10 18:23:40 +02:00
Umherirrender
f96b1eda5b
Use ::class for class name resolution
...
Available since php5.5
Change-Id: I9b072c487b84e04fbb7e9ad8ed4b9db46d805ee8
2019-03-02 19:39:36 +01:00
Zoranzoki21
6e7c48e667
Fix "Suceeded" typo in code
...
Bug: T201491
Change-Id: I89d3fa4667efee45daee9816814f1a7b067f50c4
2018-08-27 20:10:28 +00:00
Umherirrender
1d60bc25d2
build: Updating mediawiki/mediawiki-codesniffer to 0.10.0
...
Change-Id: I8d107ad6801fe1a5ce7b8feb8e1e730d504a2fb3
2017-07-08 16:04:35 +02:00
Florian Schmidt
66152162fe
Add threads parameter to captcha.py for multithread CAPTCHA generation
...
Bug: T157734
Change-Id: If4f6bc9048aceacc41538c001255425e848fd8e9
2017-06-12 17:11:58 +01:00
Reedy
40e831d464
Remove implode erroneously left
...
Swap some output calls to error
Don't attempt to delete if the store has had any sort of errors
Remove try/catch and unindent
Follows up Ib8d5ddf4ca95defe705a6f7db01dc6f43ca5d9db
Change-Id: I982c4ee5e7d48a07c5d8d0211d1e618d83065536
2017-03-23 01:08:19 +00:00
jenkins-bot
7e98f888fe
Merge "Remove entirely pointless directory iteration in GenerateFancyCaptchas"
2017-03-08 18:30:51 +00:00
Gergő Tisza
ba936103c3
Remove entirely pointless directory iteration in GenerateFancyCaptchas
...
Bug: T159606
Change-Id: Ic03a0e83878cd75235095a942400aca4293e791c
2017-03-07 11:35:01 -08:00
Gergő Tisza
508a3d8545
Fix error output
...
Bug: T159581
Bug: T159831
Change-Id: Ib8d5ddf4ca95defe705a6f7db01dc6f43ca5d9db
2017-03-07 18:12:35 +00:00
Gergő Tisza
175486431b
Warn when some of the captcha generation operations fail
...
Change-Id: If0567186410673137b08633205c3322753985412
2017-03-03 19:24:48 -08:00
jenkins-bot
c160aa909a
Merge "Switch file store/delete operations to batch operations"
2017-02-26 17:28:08 +00:00
Reedy
a1bdde2631
Add a script to delete old fancy captchas
...
Bug: T158327
Change-Id: I42ed3e0ee2cf274648cf637164e0ebaed036f4d7
2017-02-17 16:27:18 +00:00
Reedy
7de460c289
Switch file store/delete operations to batch operations
...
Bug: T157738
Change-Id: Ief109d78788fc9f6346e08661b973d65a035cafe
2017-02-16 21:13:16 +00:00
Reedy
1381924e7c
Fix class name to match file
...
More text tweaks to include fancy
Change-Id: I998ec3fa9268cff8fdb27de916903a573b6e46f1
2017-02-16 16:27:10 +00:00
jenkins-bot
3a802c6efb
Merge "Add timing instrumentation"
2017-02-10 21:17:55 +00:00
Reedy
cff6e0f359
Add timing instrumentation
...
Move some code closer to relevant usage
Tweak some output of newlines
Bug: T157737
Change-Id: I3a4d9c74a3a93fe0474e78c9c0913dd85dec4bb6
2017-02-10 19:27:19 +00:00
Reedy
f5e37ee92e
Estimated amount is now useless, as it returns actual
...
Change-Id: I995dc0ac22099917e89ee0fceb20b57b869f4c8d
2017-02-09 20:05:25 +00:00
Reedy
a2fc069174
Use an accurate number of captchas
...
Change-Id: Ice434235687aa68ccf37a0219d379beb97e5a8ec
2017-02-08 18:05:49 +00:00
jenkins-bot
0cbcb020fa
Merge "Add script for counting captchas"
2017-02-08 18:02:07 +00:00
Reedy
424f490e64
Add script for counting captchas
...
Change-Id: I4d22c4e1e46586f039ee9d9fac4c5cc68fa6e307
2017-02-08 17:49:21 +00:00
Reedy
b15d5827d3
Fix class description for maintenance script
...
Change-Id: I552c9e5e200def239e2894f67183e7e47d202ea4
2017-02-07 15:34:29 +00:00
Reedy
3bf3f53576
Fix inclusion of Maintenance.php
...
Follows up I9c33c65c913d891739b913d5363abba66c2cd0dd
Change-Id: I6d0bdf25a14f284b0eef71748008cd43b332d7b6
2017-02-01 20:40:06 +00:00
Ed Sanders
ae85f2ac6b
Replace jshint/jscs with eslint and add stylelint
...
Change-Id: I9c33c65c913d891739b913d5363abba66c2cd0dd
2017-01-18 16:53:09 -08:00
divadsn
2dc4472e04
Update Maintenance scripts to use $this->requireExtension()
...
Bug: T152139
Change-Id: I987c75233c8c1d02b240c1f2644aacd43dfff252
2017-01-01 17:34:33 +00:00
Reedy
18849474b9
Add --delete to GenerateFancyCaptchas
...
Bug: T151244
Change-Id: I722b507dc76da4d7f0970e40bb777137b1c0b327
2016-11-21 20:57:57 +00:00
