Commit graph

50 commits

Author SHA1 Message Date
Reedy a260173c06 GenerateFancyCaptchas: Include stderr result if captcha.py returns an error code
Bug: T360653
Change-Id: Ie998180e5a74441c76e236074961cf0d34aaecaf
2024-03-21 17:19:40 +00:00
Amir Sarabadani 439e4130cc GenerateFancyCaptchas: Add ->disableSandbox() to shell command
->restrict( Shell::RESTRICT_NONE ) that was removed was by my mistake.

It ::restrict() is deprecated but the internal call, calls
->disableSandbox() when the value is zero.

Follows-Up: I7b71c2f6b1bf05a4f00f2367a795db093dc00867
Change-Id: I6c8ff91aca183bdaa2473d86a029561440ed2ab3
2024-03-21 17:19:34 +00:00
Amir Sarabadani 7a45d6c6d5 GenerateFancyCaptchas: Use Shell::params() instead of ::unsafeParams()
::unsafeParams() is for when the params are raw strings while we turned
these into proper array which means they need proper quoting while being
appended to the main bash command.

Follows-Up: Iae3fdea224d896c1a7b53ce1fe7d849cb35a0401
Change-Id: I7b71c2f6b1bf05a4f00f2367a795db093dc00867
2024-03-21 17:19:30 +00:00
Amir Sarabadani ed2e1f4421 Migrate away from deprecated wfShellExec
Change-Id: Iae3fdea224d896c1a7b53ce1fe7d849cb35a0401
2024-03-21 17:19:26 +00:00
Reedy 30cd1d8a23 Namespace base classes
Change-Id: I3fa9747e0ea970c5de39e2da8603e1bba9388a69
2022-07-30 18:13:03 +00:00
Reedy db06ec876b FancyCaptcha: Deprecate and add alternative for blacklist parameter in generation
Bug: T277936
Change-Id: I8e758023b38a4d450a0bf02b3bfc0b5033959be7
2022-07-04 16:16:20 +00:00
Reedy 5876e3bd38 DeleteOldFancyCaptchas: Add some simple chunking to actual delete operation
Change-Id: Ia8f7dcc170a1e9a72313d72ac22ad7e6b3c97aa8
2021-11-16 14:53:30 +00:00
Reedy 3b9ab99b1d Make GenerateFancyCaptchas.php execute captcha(-old)?.py via python3
Bug: T268468
Change-Id: I3d5113d1a83eea9f711ee2bb206fe9423431b887
2020-12-01 18:28:00 +00:00
Reedy 297897220c Use $this->fatalError() where $this->error() is called with $die > 1
Change-Id: Ia8cf34437661f53a2c28bc9e2077fe5c7c8103de
2020-09-18 17:11:56 +01:00
libraryupgrader d481d0c8db build: Updating mediawiki/mediawiki-phan-config to 0.9.0
Additional changes:
* Added .eslintcache to .gitignore.
* Fix wrong types

Change-Id: I833b061c62b82f3c88d968c70bae8317641aaa3d
2019-12-27 14:42:40 +00:00
Umherirrender 071ce05bfe Use correct default value for Status::getWikiText
Change-Id: If9e4f297ce8435bd9001b5a8f5b15f9b127749e3
2019-12-12 19:59:33 +01:00
jenkins-bot 1a3875db83 Merge "Output some leading newlines and specify script being run" 2019-10-18 00:41:47 +00:00
Reedy 33351c2392 Make the description for --delete more specific
s/captches/captchas/ too

Point out verbose only affects captcha python script

Change-Id: I97f89427a62a7b8d26fb09641422433ded81f594
2019-10-16 21:31:43 +00:00
Reedy 0f5f6e44af Output some leading newlines and specify script being run
Change-Id: Ic51bdcd656297491fc6f0f09a3b5c2474d2e07a8
2019-10-16 22:08:07 +01:00
jenkins-bot 1b98b8f6c1 Merge "Pass 'adviseStat' => true to ->getFileList() in DeleteOldFancyCaptchas.php" 2019-10-16 15:56:45 +00:00
Reedy 330d59feba Output number of captchas to be deleted before actually deleting
Change-Id: If9cbabe2097f32129ed3ea383b7c86552392e4cb
2019-10-16 00:10:35 +01:00
Reedy 50f8738984 Pass 'adviseStat' => true to ->getFileList() in DeleteOldFancyCaptchas.php
As ->getFileTimestamp() presumably counts as 'stat'-ing the files

Change-Id: Ia187dbc369ff56f154cae2ee46e3e9cd20def933
2019-10-16 00:06:22 +01:00
Umherirrender 19e6d4d902 Use Maintenance::addDescription
It is better to use a setter function than setting a property

Change-Id: I173b3f4af54cf8f6427895e1e170ec97e10d4f3d
2019-08-19 19:03:36 +02:00
Umherirrender 911086980b Improve error messages on deleteOldFancyCaptchas maintenance script
StatusValue::getErrors returns an array of messages, not strings.
It cannot be use on implode(). Use wikitext as it the most readable on
the console

Change-Id: I4b794597f9bf35d3bc34c7d2c7691ee53d43b017
2019-05-10 18:23:40 +02:00
Umherirrender f96b1eda5b Use ::class for class name resolution
Available since php5.5

Change-Id: I9b072c487b84e04fbb7e9ad8ed4b9db46d805ee8
2019-03-02 19:39:36 +01:00
Zoranzoki21 6e7c48e667 Fix "Suceeded" typo in code
Bug: T201491
Change-Id: I89d3fa4667efee45daee9816814f1a7b067f50c4
2018-08-27 20:10:28 +00:00
Umherirrender 1d60bc25d2 build: Updating mediawiki/mediawiki-codesniffer to 0.10.0
Change-Id: I8d107ad6801fe1a5ce7b8feb8e1e730d504a2fb3
2017-07-08 16:04:35 +02:00
Florian Schmidt 66152162fe Add threads parameter to captcha.py for multithread CAPTCHA generation
Bug: T157734
Change-Id: If4f6bc9048aceacc41538c001255425e848fd8e9
2017-06-12 17:11:58 +01:00
Reedy 40e831d464 Remove implode erroneously left
Swap some output calls to error

Don't attempt to delete if the store has had any sort of errors

Remove try/catch and unindent

Follows up Ib8d5ddf4ca95defe705a6f7db01dc6f43ca5d9db

Change-Id: I982c4ee5e7d48a07c5d8d0211d1e618d83065536
2017-03-23 01:08:19 +00:00
jenkins-bot 7e98f888fe Merge "Remove entirely pointless directory iteration in GenerateFancyCaptchas" 2017-03-08 18:30:51 +00:00
Gergő Tisza ba936103c3 Remove entirely pointless directory iteration in GenerateFancyCaptchas
Bug: T159606
Change-Id: Ic03a0e83878cd75235095a942400aca4293e791c
2017-03-07 11:35:01 -08:00
Gergő Tisza 508a3d8545 Fix error output
Bug: T159581
Bug: T159831
Change-Id: Ib8d5ddf4ca95defe705a6f7db01dc6f43ca5d9db
2017-03-07 18:12:35 +00:00
Gergő Tisza 175486431b Warn when some of the captcha generation operations fail
Change-Id: If0567186410673137b08633205c3322753985412
2017-03-03 19:24:48 -08:00
jenkins-bot c160aa909a Merge "Switch file store/delete operations to batch operations" 2017-02-26 17:28:08 +00:00
Reedy a1bdde2631 Add a script to delete old fancy captchas
Bug: T158327

Change-Id: I42ed3e0ee2cf274648cf637164e0ebaed036f4d7
2017-02-17 16:27:18 +00:00
Reedy 7de460c289 Switch file store/delete operations to batch operations
Bug: T157738
Change-Id: Ief109d78788fc9f6346e08661b973d65a035cafe
2017-02-16 21:13:16 +00:00
Reedy 1381924e7c Fix class name to match file
More text tweaks to include fancy

Change-Id: I998ec3fa9268cff8fdb27de916903a573b6e46f1
2017-02-16 16:27:10 +00:00
jenkins-bot 3a802c6efb Merge "Add timing instrumentation" 2017-02-10 21:17:55 +00:00
Reedy cff6e0f359 Add timing instrumentation
Move some code closer to relevant usage

Tweak some output of newlines

Bug: T157737
Change-Id: I3a4d9c74a3a93fe0474e78c9c0913dd85dec4bb6
2017-02-10 19:27:19 +00:00
Reedy f5e37ee92e Estimated amount is now useless, as it returns actual
Change-Id: I995dc0ac22099917e89ee0fceb20b57b869f4c8d
2017-02-09 20:05:25 +00:00
Reedy a2fc069174 Use an accurate number of captchas
Change-Id: Ice434235687aa68ccf37a0219d379beb97e5a8ec
2017-02-08 18:05:49 +00:00
jenkins-bot 0cbcb020fa Merge "Add script for counting captchas" 2017-02-08 18:02:07 +00:00
Reedy 424f490e64 Add script for counting captchas
Change-Id: I4d22c4e1e46586f039ee9d9fac4c5cc68fa6e307
2017-02-08 17:49:21 +00:00
Reedy b15d5827d3 Fix class description for maintenance script
Change-Id: I552c9e5e200def239e2894f67183e7e47d202ea4
2017-02-07 15:34:29 +00:00
Reedy 3bf3f53576 Fix inclusion of Maintenance.php
Follows up I9c33c65c913d891739b913d5363abba66c2cd0dd

Change-Id: I6d0bdf25a14f284b0eef71748008cd43b332d7b6
2017-02-01 20:40:06 +00:00
Ed Sanders ae85f2ac6b Replace jshint/jscs with eslint and add stylelint
Change-Id: I9c33c65c913d891739b913d5363abba66c2cd0dd
2017-01-18 16:53:09 -08:00
divadsn 2dc4472e04 Update Maintenance scripts to use $this->requireExtension()
Bug: T152139
Change-Id: I987c75233c8c1d02b240c1f2644aacd43dfff252
2017-01-01 17:34:33 +00:00
Reedy 18849474b9 Add --delete to GenerateFancyCaptchas
Bug: T151244
Change-Id: I722b507dc76da4d7f0970e40bb777137b1c0b327
2016-11-21 20:57:57 +00:00
Reedy c82a903e6f Allow usage of old captcha script
To be reverted at a later date when improved script is allowable for
usage on WMF wikis.

Change-Id: Id23483286ae2549bfd6f1377c6a0d0c0898b88c4
2016-11-04 19:01:15 +00:00
Kunal Mehta 9ea898ba2a build: Updating mediawiki/mediawiki-codesniffer to 0.7.1
Also added "composer fix" command.

Change-Id: Ibda3fd002c577c7f7c41920d67ec44fedbd27cb8
2016-05-09 16:41:17 -07:00
Paladox 30490fba52 Add php code sniffer
Change-Id: I298b8b936a2b86deea75c302d88a7391cdb221c9
2015-10-28 21:46:29 +00:00
Aaron Schulz 0e761f3325 Merge "Disable ulimit time limit for long-running captcha.py script." 2013-01-02 18:27:41 +00:00
Aaron Schulz 82cc98f128 Disable ulimit time limit for long-running captcha.py script.
Change-Id: I367120a1746ac329d675c0a31c9ddb4ef10e3b0f
2012-12-18 15:18:11 -08:00
Aaron Schulz 099b318d61 Actually create directories before using store operations.
Change-Id: I69a6b84f2f989fbe4cdd35ba75f25a4a26406347
2012-12-18 14:25:37 -08:00
Aaron Schulz 13d62bf9c7 File backend support for Captchas.
* Added $wgCaptchaFileBackend configuration setting.
  This causes captchas to be stored in the registered backend.
* Added $wgMemc usage to reduce directory operation I/O.
* Improved $wgCaptchaDeleteOnSolve in terms of race conditions.
* Added maintenance script to create and store new captchas based
  on the total amount desired and the current number remaining.

Change-Id: Iac490503fb94a8f003e3b7e1474a949b037af5df
2012-09-25 23:22:04 -07:00