wikimedia/mediawiki-extensions-ConfirmEdit
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/ConfirmEdit synced 2024-11-23 15:56:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Unset CaptchaStore instance before test

Browse source 
Caught while tests were running for core.

Fatal error:
Call to undefined method CaptchaSessionStore::clearAll() in
ConfirmEdit/tests/CaptchaAuthenticationRequestTest.php
on line 13

Change-Id: I3a9f5b315eb114cb12ea4071f8da9079f797fcf6
This commit is contained in:
addshore 2016-07-28 14:51:51 +01:00
parent d1ef7ab717
commit eedab34d3d
3 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
includes/CaptchaStore.php
View file

@ -53,6 +53,13 @@ abstract class CaptchaStore {
return self::$instance;
}
final public static function unsetInstanceForTests() {
if ( !defined( 'MW_PHPUNIT_TEST' ) ) {
throw new MWException( 'Cannot unset ' . __CLASS__ . ' instance in operation.' );
}
self::$instance = null;
}
/**
* Protected constructor: no creating instances except through the factory method above
*/

1
tests/CaptchaAuthenticationRequestTest.php
View file

@ -10,6 +10,7 @@ class CaptchaAuthenticationRequestTest extends AuthenticationRequestTestCase {
'wgCaptchaClass' => 'SimpleCaptcha',
'wgCaptchaStorageClass' => CaptchaHashStore::class,
] );
CaptchaStore::unsetInstanceForTests();
CaptchaStore::get()->clearAll();
CaptchaStore::get()->store( '345', [ 'question' => '2+2', 'answer' => '4' ] );
}

1
tests/CaptchaPreAuthenticationProviderTest.php
View file

@ -21,6 +21,7 @@ class CaptchaPreAuthenticationProviderTest extends MediaWikiTestCase {
'wgCaptchaStorageClass' => CaptchaHashStore::class,
'wgMainCacheType' => __METHOD__,
] );
CaptchaStore::unsetInstanceForTests();
CaptchaStore::get()->clearAll();
ObjectCache::$instances[__METHOD__] = new HashBagOStuff();
}