wikimedia/mediawiki-extensions-ConfirmEdit
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/ConfirmEdit synced 2024-11-27 17:40:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add explicit parentheses around mixed boolean operator

Browse source 
Mixing different binary boolean operators within an expression
without using parentheses to clarify precedence is not allowed (T358966)

Change-Id: I908691348d259d868f39a7737614be82c9ce0c75
This commit is contained in:
Umherirrender 2024-03-23 00:33:23 +01:00
parent a1a566a1c1
commit bcdde67ebd
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
includes/Auth/CaptchaPreAuthenticationProvider.php
View file

@ -59,7 +59,7 @@ class CaptchaPreAuthenticationProvider extends AbstractPreAuthenticationProvider
if ( if (
$loginCounter->isBadLoginTriggered() $loginCounter->isBadLoginTriggered()
|| $userProbablyNeedsCaptcha || $userProbablyNeedsCaptcha
|| $suggestedUsername && $loginCounter->isBadLoginPerUserTriggered( $suggestedUsername ) || ( $suggestedUsername && $loginCounter->isBadLoginPerUserTriggered( $suggestedUsername ) )
) { ) {
$needed = true; $needed = true;
$captcha->setAction( 'badlogin' ); $captcha->setAction( 'badlogin' );