wikimedia/mediawiki-extensions-ConfirmEdit
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/ConfirmEdit synced 2024-11-24 00:04:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Swap ternary check for if statement

Browse source 
isset is not needed to check for null
and if is used, because the else branch is not needed

Change-Id: I3069ac43911101aa500c4897d419dca68f968040
This commit is contained in:
Umherirrender 2019-03-12 20:08:56 +01:00
parent 40cc11817a
commit 9bc797453e
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
SimpleCaptcha/SimpleCaptcha.php
View file

@ -593,7 +593,9 @@ class SimpleCaptcha {
} }
} else { } else {
// Get link changes in the slowest way known to man // Get link changes in the slowest way known to man
$oldtext = isset( $oldtext ) ? $oldtext : $this->loadText( $title, $section ); if ( $oldtext === null ) {
$oldtext = $this->loadText( $title, $section );
}
$oldLinks = $this->findLinks( $title, $oldtext ); $oldLinks = $this->findLinks( $title, $oldtext );
$newLinks = $this->findLinks( $title, $newtext ); $newLinks = $this->findLinks( $title, $newtext );
} }
@ -621,7 +623,9 @@ class SimpleCaptcha {
); );
} }
// Custom regex checks. Reuse $oldtext if set above. // Custom regex checks. Reuse $oldtext if set above.
$oldtext = isset( $oldtext ) ? $oldtext : $this->loadText( $title, $section ); if ( $oldtext === null ) {
$oldtext = $this->loadText( $title, $section );
}
foreach ( $wgCaptchaRegexes as $regex ) { foreach ( $wgCaptchaRegexes as $regex ) {
$newMatches = []; $newMatches = [];