diff --git a/ReCaptchaNoCaptcha/includes/HTMLReCaptchaNoCaptchaField.php b/ReCaptchaNoCaptcha/includes/HTMLReCaptchaNoCaptchaField.php index e1a39a60e..83cd0a33a 100644 --- a/ReCaptchaNoCaptcha/includes/HTMLReCaptchaNoCaptchaField.php +++ b/ReCaptchaNoCaptcha/includes/HTMLReCaptchaNoCaptchaField.php @@ -41,7 +41,7 @@ class HTMLReCaptchaNoCaptchaField extends HTMLFormField { $output = Html::element( 'div', [ 'class' => [ 'g-recaptcha', - 'mw-confirmedit-captcha-fail' => !!$this->error, + 'mw-confirmedit-captcha-fail' => (bool)$this->error, ], 'data-sitekey' => $this->key, ] ); diff --git a/ReCaptchaNoCaptcha/includes/ReCaptchaNoCaptcha.php b/ReCaptchaNoCaptcha/includes/ReCaptchaNoCaptcha.php index 8006f354e..a9dcccccc 100644 --- a/ReCaptchaNoCaptcha/includes/ReCaptchaNoCaptcha.php +++ b/ReCaptchaNoCaptcha/includes/ReCaptchaNoCaptcha.php @@ -20,7 +20,7 @@ class ReCaptchaNoCaptcha extends SimpleCaptcha { $output = Html::element( 'div', [ 'class' => [ 'g-recaptcha', - 'mw-confirmedit-captcha-fail' => !!$this->error, + 'mw-confirmedit-captcha-fail' => (bool)$this->error, ], 'data-sitekey' => $wgReCaptchaSiteKey ] ); diff --git a/SimpleCaptcha/SimpleCaptcha.php b/SimpleCaptcha/SimpleCaptcha.php index 2672ca745..f4645c6fb 100644 --- a/SimpleCaptcha/SimpleCaptcha.php +++ b/SimpleCaptcha/SimpleCaptcha.php @@ -320,7 +320,7 @@ class SimpleCaptcha { * Check if a bad login has already been registered for this * IP address. If so, require a captcha. * @return bool - * @access private + * @private */ public function isBadLoginTriggered() { global $wgCaptchaBadLoginAttempts; @@ -683,7 +683,7 @@ class SimpleCaptcha { * Build regex from whitelist * @param string $lines string from [[MediaWiki:Captcha-addurl-whitelist]] * @return array Regexes - * @access private + * @private */ private function buildRegexes( $lines ) { # Code duplicated from the SpamBlacklist extension (r19197) @@ -1081,7 +1081,7 @@ class SimpleCaptcha { * @param string $section * @param int $flags Flags for Revision loading methods * @return string - * @access private + * @private */ private function loadText( $title, $section, $flags = Revision::READ_LATEST ) { global $wgParser; diff --git a/composer.json b/composer.json index edad2b43e..8d8396094 100644 --- a/composer.json +++ b/composer.json @@ -1,7 +1,7 @@ { "require-dev": { "jakub-onderka/php-parallel-lint": "1.0.0", - "mediawiki/mediawiki-codesniffer": "23.0.0", + "mediawiki/mediawiki-codesniffer": "24.0.0", "jakub-onderka/php-console-highlighter": "0.3.2", "mediawiki/minus-x": "0.3.1" },