build: Upgrade mediawiki-codesniffer to v28.0.0

Change-Id: I12c3660e74e42937f6cfb31ec4771a67d8651f42
This commit is contained in:
James D. Forrester 2019-10-09 15:45:51 -07:00
parent 4adce79b8d
commit 86246f0172
6 changed files with 7 additions and 6 deletions

View file

@ -2,6 +2,7 @@
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
<exclude name="PSR12.Properties.ConstantVisibility.NotFound" />
</rule>
<file>.</file>
<arg name="extensions" value="php,php5,inc"/>

View file

@ -1,7 +1,7 @@
{
"require-dev": {
"jakub-onderka/php-parallel-lint": "1.0.0",
"mediawiki/mediawiki-codesniffer": "26.0.0",
"mediawiki/mediawiki-codesniffer": "28.0.0",
"jakub-onderka/php-console-highlighter": "0.3.2",
"mediawiki/minus-x": "0.3.1",
"mediawiki/mediawiki-phan-config": "0.6.1"

View file

@ -6,7 +6,7 @@ use MediaWiki\Auth\AuthenticationRequestTestCase;
* @covers CaptchaAuthenticationRequest
*/
class CaptchaAuthenticationRequestTest extends AuthenticationRequestTestCase {
public function setUp() {
public function setUp() : void {
parent::setUp();
$this->setMwGlobals( [
'wgCaptchaClass' => SimpleCaptcha::class,

View file

@ -9,7 +9,7 @@ use Wikimedia\TestingAccessWrapper;
* @group Database
*/
class CaptchaPreAuthenticationProviderTest extends MediaWikiTestCase {
public function setUp() {
public function setUp() : void {
parent::setUp();
$this->setMwGlobals( [
'wgCaptchaClass' => SimpleCaptcha::class,
@ -28,7 +28,7 @@ class CaptchaPreAuthenticationProviderTest extends MediaWikiTestCase {
}
}
public function tearDown() {
public function tearDown() : void {
parent::tearDown();
// make sure $wgCaptcha resets between tests
TestingAccessWrapper::newFromClass( ConfirmEditHooks::class )->instanceCreated = false;

View file

@ -5,7 +5,7 @@
*/
class QuestyCaptchaTest extends MediaWikiTestCase {
public function setUp() {
public function setUp() : void {
parent::setUp();
$this->mergeMwGlobalArrayValue(

View file

@ -11,7 +11,7 @@ class CaptchaTest extends MediaWikiTestCase {
/** @var ScopedCallback[] */
private $hold = [];
public function tearDown() {
public function tearDown() : void {
// Destroy any ScopedCallbacks being held
$this->hold = [];
parent::tearDown();