mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/ConfirmEdit
synced 2024-11-24 08:13:53 +00:00
The EditPage object is not passed by reference in the EditFilter hooks
This commit is contained in:
parent
a24dd2d43b
commit
73cfd41936
|
@ -15,11 +15,11 @@ class ConfirmEditHooks {
|
|||
return $wgCaptcha;
|
||||
}
|
||||
|
||||
static function confirmEdit( &$editPage, $newtext, $section ) {
|
||||
static function confirmEdit( $editPage, $newtext, $section ) {
|
||||
return self::getInstance()->confirmEdit( $editPage, $newtext, $section );
|
||||
}
|
||||
|
||||
static function confirmEditMerged( &$editPage, $newtext ) {
|
||||
static function confirmEditMerged( $editPage, $newtext ) {
|
||||
return self::getInstance()->confirmEditMerged( $editPage, $newtext );
|
||||
}
|
||||
|
||||
|
@ -467,7 +467,7 @@ class SimpleCaptcha {
|
|||
* Backend function for confirmEdit() and confirmEditAPI()
|
||||
* @return bool false if the CAPTCHA is rejected, true otherwise
|
||||
*/
|
||||
private function doConfirmEdit( &$editPage, $newtext, $section, $merged = false ) {
|
||||
private function doConfirmEdit( $editPage, $newtext, $section, $merged = false ) {
|
||||
if( $this->shouldCheck( $editPage, $newtext, $section, $merged ) ) {
|
||||
if( $this->passCaptcha() ) {
|
||||
return true;
|
||||
|
@ -488,7 +488,7 @@ class SimpleCaptcha {
|
|||
* @param bool $merged
|
||||
* @return bool true to continue saving, false to abort and show a captcha form
|
||||
*/
|
||||
function confirmEdit( &$editPage, $newtext, $section, $merged = false ) {
|
||||
function confirmEdit( $editPage, $newtext, $section, $merged = false ) {
|
||||
if( defined('MW_API') ) {
|
||||
# API mode
|
||||
# The CAPTCHA was already checked and approved
|
||||
|
@ -506,7 +506,7 @@ class SimpleCaptcha {
|
|||
* @param EditPage $editPage
|
||||
* @param string $newtext
|
||||
*/
|
||||
function confirmEditMerged( &$editPage, $newtext ) {
|
||||
function confirmEditMerged( $editPage, $newtext ) {
|
||||
return $this->confirmEdit( $editPage, $newtext, false, true );
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue