Rename $ceAllowConfirmedEmail to $wgAllowConfirmedEmail

The value of $ceAllowConfirmedEmail is copied to $wgAllowConfirmedEmail if
set in LocalSettings.php for backward-compatibility. However, a deprecation
warning is emitted in this case.

Bug: T162641
Change-Id: If4daf6f25f0d2b2c0f1e173ee3903063a39978bb
This commit is contained in:
Florian Schmidt 2017-04-14 16:15:58 +02:00
parent 2bfdd274b4
commit 37f2dcfd23
2 changed files with 27 additions and 16 deletions

View file

@ -91,11 +91,10 @@
}
},
"config": {
"_prefix": "",
"wgCaptchaWhitelistIP": false,
"wgCaptcha": null,
"wgCaptchaClass": "SimpleCaptcha",
"wgCaptchaTriggers": {
"CaptchaWhitelistIP": false,
"Captcha": null,
"CaptchaClass": "SimpleCaptcha",
"CaptchaTriggers": {
"edit": false,
"create": false,
"sendemail": false,
@ -105,18 +104,18 @@
"badloginperuser": true,
"_merge_strategy": "array_plus"
},
"wgCaptchaTriggersOnNamespace": {
"CaptchaTriggersOnNamespace": {
"_merge_strategy": "array_plus_2d"
},
"wgCaptchaStorageClass": "CaptchaSessionStore",
"wgCaptchaSessionExpiration": 1800,
"wgCaptchaBadLoginExpiration": 300,
"wgCaptchaBadLoginPerUserExpiration": 600,
"ceAllowConfirmedEmail": false,
"wgCaptchaBadLoginAttempts": 3,
"wgCaptchaBadLoginPerUserAttempts": 20,
"wgCaptchaWhitelist": false,
"wgCaptchaRegexes": []
"CaptchaStorageClass": "CaptchaSessionStore",
"CaptchaSessionExpiration": 1800,
"CaptchaBadLoginExpiration": 300,
"CaptchaBadLoginPerUserExpiration": 600,
"AllowConfirmedEmail": false,
"CaptchaBadLoginAttempts": 3,
"CaptchaBadLoginPerUserAttempts": 20,
"CaptchaWhitelist": false,
"CaptchaRegexes": []
},
"manifest_version": 1
}

View file

@ -87,12 +87,24 @@ class ConfirmEditHooks {
* Set up $wgWhitelistRead
*/
public static function confirmEditSetup() {
global $wgCaptchaTriggers, $wgWikimediaJenkinsCI;
// @codingStandardsIgnoreStart MediaWiki.NamingConventions.ValidGlobalName.wgPrefix
global $wgCaptchaTriggers, $wgWikimediaJenkinsCI, $ceAllowConfirmedEmail,
$wgAllowConfirmedEmail;
// @codingStandardsIgnoreEnd
// There is no need to run (core) tests with enabled ConfirmEdit - bug T44145
if ( isset( $wgWikimediaJenkinsCI ) && $wgWikimediaJenkinsCI === true ) {
$wgCaptchaTriggers = array_fill_keys( array_keys( $wgCaptchaTriggers ), false );
}
// $ceAllowConfirmedEmail is deprecated and should be replaced by $wgAllowConfirmedEmail.
// For backward-compatibility, keep the value for some time. T162641
if ( isset( $ceAllowConfirmedEmail ) ) {
wfDeprecated(
'Using $ceAllowConfirmedEmail is deprecated, ' .
'please migrate to $wgAllowConfirmedEmail as a replacement.' );
$wgAllowConfirmedEmail = $ceAllowConfirmedEmail;
}
}
/**