Remove unused return values and reduce code complexity

Changes:
* Do not return anything in a method that is not expected to return
  something.
* Inline some previously hard to read code.
* More specific type hints, if possible.

Change-Id: I0e460899eea07d8733f638a11133adc3000f0542

SimpleCaptcha/SimpleCaptcha.php

@@ -749,7 +749,7 @@ class SimpleCaptcha {
 			}
 			foreach ( $build as $key => $value ) {
 				$regexes[] = $regexStart[$key] .
-					str_replace( '/', '\/', preg_replace( '|\\\*/|', '/', $build[$key] ) ) .
+					str_replace( '/', '\/', preg_replace( '|\\\*/|', '/', $value ) ) .
 					$regexEnd[$key];
 			}
 			return $regexes;
@@ -1111,7 +1111,7 @@ class SimpleCaptcha {
 	 * Extract a list of all recognized HTTP links in the text.
 	 * @param Title $title
 	 * @param string $text
-	 * @return array of strings
+	 * @return string[]
 	 */
 	private function findLinks( $title, $text ) {
 		$parser = MediaWikiServices::getInstance()->getParser();

includes/ConfirmEditHooks.php

@@ -13,12 +13,9 @@ class ConfirmEditHooks {
 	public static function getInstance() {
 		global $wgCaptcha, $wgCaptchaClass;
 
-		$class = $wgCaptchaClass;
-		if ( $class == null ) {
-			$class = 'SimpleCaptcha';
-		}
 		if ( !static::$instanceCreated ) {
 			static::$instanceCreated = true;
+			$class = $wgCaptchaClass ?: SimpleCaptcha::class;
 			$wgCaptcha = new $class;
 		}
 

includes/auth/CaptchaAuthenticationRequest.php

@@ -83,8 +83,7 @@ class CaptchaAuthenticationRequest extends AuthenticationRequest {
 	}
 
 	public function getMetadata() {
-		$captcha = ConfirmEditHooks::getInstance();
-		return $captcha->describeCaptchaType();
+		return ( ConfirmEditHooks::getInstance() )->describeCaptchaType();
 	}
 
 	public static function __set_state( $data ) {

includes/specials/SpecialCaptcha.php

@@ -10,16 +10,13 @@ class SpecialCaptcha extends UnlistedSpecialPage {
 
 		$instance = ConfirmEditHooks::getInstance();
 
-		switch ( $par ) {
-			case "image":
-				if ( method_exists( $instance, 'showImage' ) ) {
-					// @todo: Do this in a more OOP way
-					/** @phan-suppress-next-line PhanUndeclaredMethod */
-					return $instance->showImage();
-				}
-			case "help":
-			default:
-				return $instance->showHelp();
+		if ( $par === 'image' && method_exists( $instance, 'showImage' ) ) {
+			// @todo: Do this in a more OOP way
+			/** @phan-suppress-next-line PhanUndeclaredMethod */
+			$instance->showImage();
+			return;
 		}
+
+		$instance->showHelp();
 	}
 }

includes/store/CaptchaCacheStore.php

@@ -25,12 +25,7 @@ class CaptchaCacheStore extends CaptchaStore {
 
 	public function retrieve( $index ) {
 		$cache = $this->cache;
-		$info = $cache->get( $cache->makeKey( 'captcha', $index ) );
-		if ( $info ) {
-			return $info;
-		} else {
-			return false;
-		}
+		return $cache->get( $cache->makeKey( 'captcha', $index ) ) ?: false;
 	}
 
 	public function clear( $index ) {