wikimedia/mediawiki-extensions-ConfirmEdit
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/ConfirmEdit synced 2024-11-24 00:04:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't use logging reserved word 'ip' as parameter

Browse source 
Bug: T245280
Change-Id: I368724e9e6de85df45fd8734668789e8d524214f
Follows-up: I5f602bc08902b63acbb0752093b418d0ab063493
This commit is contained in:
Reedy 2020-02-27 15:10:29 +00:00
parent 9a7ec1d0fe
commit 035e073ddb
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
includes/auth/CaptchaPreAuthenticationProvider.php
View file

@ -52,11 +52,11 @@ class CaptchaPreAuthenticationProvider extends AbstractPreAuthenticationProvider
$needed = true;
$captcha->setAction( 'badlogin' );
LoggerFactory::getInstance( 'captcha' )
->info( 'Captcha shown on login by {ip} for {suggestedUser}', [
->info( 'Captcha shown on login by {clientip} for {suggestedUser}', [
'event' => 'captcha.display',
'eventType' => 'accountcreation',
'suggestedUser' => $suggestedUsername,
'ip' => $this->manager->getRequest()->getIP()
'clientip' => $this->manager->getRequest()->getIP()
] );
break;
}
@ -87,7 +87,7 @@ class CaptchaPreAuthenticationProvider extends AbstractPreAuthenticationProvider
'eventType' => 'login',
'successful' => $success,
'user' => $username,
'ip' => $ip
'clientip' => $ip
] );
}
@ -116,7 +116,7 @@ class CaptchaPreAuthenticationProvider extends AbstractPreAuthenticationProvider
'eventType' => 'accountcreation',
'successful' => $success,
'user' => $username,
'ip' => $ip
'clientip' => $ip
]
);
if ( !$success ) {