mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/CodeMirror
synced 2024-11-30 17:04:14 +00:00
880c690a10
Add a new $wgCodeMirrorV6 temporary feature flag that when enabled, will load the 'ext.CodeMirror.v6.WikiEditor' module that is built against CodeMirror 6. You can also pass in the ?cm6enable=1 query parameter to force use of CodeMirror 6. This is currently only implemented for the 2010 editor. Due to packaging constraints with CodeMirror 6, we now use Webpack to bundle the files, which are then used by ResourceLoader. This is similar to what is done for Extension:Popups, MobileFrontend, among other extensions. A new generic class CodeMirror can be used on other areas where syntax highlighting is desirable, but not necessarily for editing (i.e. without WikiEditor). This commit merely lays the foundation for CodeMirror 6 and updates WikiEditor to use it. The actual MediaWiki syntax highlighting will come with a future commit. With the new Webpack build, the Gruntfile was removed and the tasks moved to npm commands. Bug: T317243 Change-Id: I2239d2449b2db3b638551f847eb4eff1aafa6276
77 lines
2.5 KiB
PHP
77 lines
2.5 KiB
PHP
<?php
|
|
|
|
namespace MediaWiki\Extension\CodeMirror\Tests;
|
|
|
|
use MediaWiki\Extension\CodeMirror\Hooks;
|
|
use MediaWiki\MediaWikiServices;
|
|
use MediaWiki\Request\WebRequest;
|
|
use MediaWiki\Title\Title;
|
|
use MediaWiki\User\UserOptionsLookup;
|
|
use MediaWikiIntegrationTestCase;
|
|
use OutputPage;
|
|
use RequestContext;
|
|
use Skin;
|
|
|
|
/**
|
|
* @group CodeMirror
|
|
* @group Database
|
|
* @coversDefaultClass \MediaWiki\Extension\CodeMirror\Hooks
|
|
*/
|
|
class HookTest extends MediaWikiIntegrationTestCase {
|
|
|
|
/**
|
|
* @covers ::isCodeMirrorOnPage
|
|
* @covers ::onBeforePageDisplay
|
|
* @param bool $useCodeMirrorV6
|
|
* @param int $expectedAddModuleCalls
|
|
* @param string $expectedFirstModule
|
|
* @dataProvider provideOnBeforePageDisplay
|
|
*/
|
|
public function testOnBeforePageDisplay(
|
|
bool $useCodeMirrorV6, int $expectedAddModuleCalls, string $expectedFirstModule
|
|
) {
|
|
$this->overrideConfigValues( [
|
|
'CodeMirrorV6' => $useCodeMirrorV6,
|
|
] );
|
|
$userOptionsLookup = $this->createMock( UserOptionsLookup::class );
|
|
$userOptionsLookup->method( 'getOption' )->willReturn( true );
|
|
$this->setService( 'UserOptionsLookup', $userOptionsLookup );
|
|
|
|
$out = $this->createMock( OutputPage::class );
|
|
$out->method( 'getModules' )->willReturn( [] );
|
|
$out->method( 'getUser' )->willReturn( $this->createMock( \User::class ) );
|
|
$out->method( 'getActionName' )->willReturn( 'edit' );
|
|
$out->method( 'getTitle' )->willReturn( Title::makeTitle( NS_MAIN, __METHOD__ ) );
|
|
$request = $this->createMock( WebRequest::class );
|
|
$request->method( 'getRawVal' )->willReturn( null );
|
|
$out->method( 'getRequest' )->willReturn( $request );
|
|
$out->expects( $this->exactly( $expectedAddModuleCalls ) )
|
|
->method( 'addModules' )
|
|
->withConsecutive( [ $this->equalTo( $expectedFirstModule ) ] );
|
|
|
|
( new Hooks( $userOptionsLookup, MediaWikiServices::getInstance()->getMainConfig() ) )
|
|
->onBeforePageDisplay( $out, $this->createMock( Skin::class ) );
|
|
}
|
|
|
|
/**
|
|
* @return array[]
|
|
*/
|
|
public function provideOnBeforePageDisplay(): array {
|
|
return [
|
|
[ false, 2, 'ext.CodeMirror.WikiEditor' ],
|
|
[ true, 1, 'ext.CodeMirror.v6.WikiEditor' ]
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @covers ::onGetPreferences
|
|
*/
|
|
public function testPreferenceRegistered() {
|
|
$user = self::getTestUser()->getUser();
|
|
$this->setMwGlobals( 'wgTitle', Title::newFromText( __METHOD__ ) );
|
|
$kinds = $this->getServiceContainer()->getUserOptionsManager()
|
|
->getOptionKinds( $user, RequestContext::getMain(), [ 'usecodemirror' => 1 ] );
|
|
self::assertEquals( 'registered', $kinds['usecodemirror'] );
|
|
}
|
|
}
|