mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/CodeMirror
synced 2024-11-23 22:03:28 +00:00
27b6aaebcc
For years, users have complained that the CodeMirror toggle button is confusing and concealed. The icon looked too similar to the edit icon, when it was supposed to be a highlighter. The new icon is similar but has a highlighted line to help clarify what it is. We also now have the text 'Syntax' accompanying the icon. Translators are instructed to try to be brief to conserve space in the toolbar. "Syntax highlighting" is the full correct term, and remains the text for the button's tooltip. The new icon is ~0.3KB uncompressed, just meeting performance guidelines for using @embed <https://w.wiki/AsPW>. This is also only temporary until the icon is upstreamed in Codex/OOUI. New icon courtesy of Thiemo Kreuz (WMDE) A corresponding change for the 2017 editor will follow I15453b33e7. Bug: T174145 Change-Id: Ib6dbfc261214ed6672c1a54738e3401fa2f5d262
255 lines
7.1 KiB
JavaScript
255 lines
7.1 KiB
JavaScript
const {
|
|
EditorSelection,
|
|
EditorView,
|
|
Extension,
|
|
LanguageSupport
|
|
} = require( 'ext.CodeMirror.v6.lib' );
|
|
const CodeMirror = require( 'ext.CodeMirror.v6' );
|
|
|
|
/**
|
|
* CodeMirror integration with
|
|
* [WikiEditor](https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:WikiEditor).
|
|
*
|
|
* Use this class if you want WikiEditor's toolbar. If you don't need the toolbar,
|
|
* using {@link CodeMirror} directly will be considerably more efficient.
|
|
*
|
|
* @example
|
|
* mw.loader.using( [
|
|
* 'ext.wikiEditor',
|
|
* 'ext.CodeMirror.v6.WikiEditor',
|
|
* 'ext.CodeMirror.v6.mode.mediawiki'
|
|
* ] ).then( ( require ) => {
|
|
* mw.addWikiEditor( myTextarea );
|
|
* const CodeMirrorWikiEditor = require( 'ext.CodeMirror.v6.WikiEditor' );
|
|
* const mediawikiLang = require( 'ext.CodeMirror.v6.mode.mediawiki' );
|
|
* const cmWe = new CodeMirrorWikiEditor( myTextarea );
|
|
* cmWe.initialize( [ cmWe.defaultExtensions, mediawikiLang() ] );
|
|
* cmWe.addCodeMirrorToWikiEditor();
|
|
* } );
|
|
* @extends CodeMirror
|
|
*/
|
|
class CodeMirrorWikiEditor extends CodeMirror {
|
|
/**
|
|
* @constructor
|
|
* @param {jQuery} $textarea The textarea to replace with CodeMirror.
|
|
* @param {LanguageSupport|Extension} langExtension Language support and its extension(s).
|
|
* @stable to call and override
|
|
*/
|
|
constructor( $textarea, langExtension ) {
|
|
super( $textarea );
|
|
/**
|
|
* Language support and its extension(s).
|
|
*
|
|
* @type {LanguageSupport|Extension}
|
|
*/
|
|
this.langExtension = langExtension;
|
|
/**
|
|
* Whether CodeMirror is currently enabled.
|
|
*
|
|
* @type {boolean}
|
|
*/
|
|
this.useCodeMirror = mw.user.options.get( 'usecodemirror' ) > 0;
|
|
/**
|
|
* The [Realtime Preview](https://w.wiki/9XgX) handler.
|
|
*
|
|
* @type {Function|null}
|
|
*/
|
|
this.realtimePreviewHandler = null;
|
|
}
|
|
|
|
/**
|
|
* @inheritDoc
|
|
*/
|
|
setCodeMirrorPreference( prefValue ) {
|
|
// Save state for function updateToolbarButton()
|
|
this.useCodeMirror = prefValue;
|
|
super.setCodeMirrorPreference( prefValue );
|
|
}
|
|
|
|
/**
|
|
* Replaces the default textarea with CodeMirror.
|
|
*
|
|
* @fires CodeMirrorWikiEditor~'ext.CodeMirror.switch'
|
|
* @stable to call
|
|
*/
|
|
enableCodeMirror() {
|
|
// If CodeMirror is already loaded, abort.
|
|
if ( this.view ) {
|
|
return;
|
|
}
|
|
|
|
const selectionStart = this.$textarea.prop( 'selectionStart' ),
|
|
selectionEnd = this.$textarea.prop( 'selectionEnd' ),
|
|
scrollTop = this.$textarea.scrollTop(),
|
|
hasFocus = this.$textarea.is( ':focus' );
|
|
|
|
/*
|
|
* Default configuration, which we may conditionally add to later.
|
|
* @see https://codemirror.net/docs/ref/#state.Extension
|
|
*/
|
|
const extensions = [
|
|
this.defaultExtensions,
|
|
this.langExtension,
|
|
EditorView.updateListener.of( ( update ) => {
|
|
if ( update.docChanged && typeof this.realtimePreviewHandler === 'function' ) {
|
|
this.realtimePreviewHandler();
|
|
}
|
|
} )
|
|
];
|
|
|
|
this.initialize( extensions );
|
|
this.addRealtimePreviewHandler();
|
|
|
|
// Sync scroll position, selections, and focus state.
|
|
requestAnimationFrame( () => {
|
|
this.view.scrollDOM.scrollTop = scrollTop;
|
|
} );
|
|
if ( selectionStart !== 0 || selectionEnd !== 0 ) {
|
|
const range = EditorSelection.range( selectionStart, selectionEnd ),
|
|
scrollEffect = EditorView.scrollIntoView( range );
|
|
scrollEffect.value.isSnapshot = true;
|
|
this.view.dispatch( {
|
|
selection: EditorSelection.create( [ range ] ),
|
|
effects: scrollEffect
|
|
} );
|
|
}
|
|
if ( hasFocus ) {
|
|
this.view.focus();
|
|
}
|
|
|
|
/**
|
|
* Called after CodeMirror is enabled or disabled in WikiEditor.
|
|
*
|
|
* @event CodeMirrorWikiEditor~'ext.CodeMirror.switch'
|
|
* @param {boolean} enabled Whether CodeMirror is enabled.
|
|
* @param {jQuery} $textarea The current "editor", either the
|
|
* original textarea or the `.cm-editor` element.
|
|
* @stable to use
|
|
*/
|
|
mw.hook( 'ext.CodeMirror.switch' ).fire( true, $( this.view.dom ) );
|
|
}
|
|
|
|
/**
|
|
* Adds the Realtime Preview handler. Realtime Preview reads from the textarea
|
|
* via jQuery.textSelection, which will bubble up to CodeMirror automatically.
|
|
*
|
|
* @private
|
|
*/
|
|
addRealtimePreviewHandler() {
|
|
mw.hook( 'ext.WikiEditor.realtimepreview.enable' ).add( ( realtimePreview ) => {
|
|
this.realtimePreviewHandler = realtimePreview.getEventHandler().bind( realtimePreview );
|
|
} );
|
|
mw.hook( 'ext.WikiEditor.realtimepreview.disable' ).add( () => {
|
|
this.realtimePreviewHandler = null;
|
|
} );
|
|
}
|
|
|
|
/**
|
|
* Adds the CodeMirror button to WikiEditor.
|
|
*
|
|
* @stable to call
|
|
*/
|
|
addCodeMirrorToWikiEditor() {
|
|
const context = this.$textarea.data( 'wikiEditor-context' );
|
|
const toolbar = context && context.modules && context.modules.toolbar;
|
|
|
|
// Guard against something having removed WikiEditor (T271457)
|
|
if ( !toolbar ) {
|
|
return;
|
|
}
|
|
|
|
this.$textarea.wikiEditor(
|
|
'addToToolbar',
|
|
{
|
|
section: 'main',
|
|
groups: {
|
|
codemirror: {
|
|
tools: {
|
|
CodeMirror: {
|
|
type: 'element',
|
|
element: () => {
|
|
// OOUI has already been loaded by WikiEditor.
|
|
const button = new OO.ui.ToggleButtonWidget( {
|
|
label: mw.msg( 'codemirror-toggle-label-short' ),
|
|
icon: 'syntax-highlight',
|
|
value: this.useCodeMirror,
|
|
framed: false,
|
|
classes: [ 'tool', 'cm-mw-toggle-wikieditor' ]
|
|
} );
|
|
button.on( 'change', this.switchCodeMirror.bind( this ) );
|
|
return button.$element;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
);
|
|
|
|
const $codeMirrorButton = toolbar.$toolbar.find( '.tool[rel=CodeMirror]' );
|
|
$codeMirrorButton.attr( 'id', 'mw-editbutton-codemirror' );
|
|
|
|
// Hide non-applicable buttons until WikiEditor better supports a read-only mode (T188817).
|
|
if ( this.readOnly ) {
|
|
this.$textarea.data( 'wikiEditor-context' ).$ui.addClass( 'ext-codemirror-readonly' );
|
|
}
|
|
|
|
if ( this.useCodeMirror ) {
|
|
this.enableCodeMirror();
|
|
}
|
|
this.updateToolbarButton();
|
|
|
|
this.logUsage( {
|
|
editor: 'wikitext',
|
|
enabled: this.useCodeMirror,
|
|
toggled: false,
|
|
// eslint-disable-next-line no-jquery/no-global-selector,camelcase
|
|
edit_start_ts_ms: parseInt( $( 'input[name="wpStarttime"]' ).val(), 10 ) * 1000 || 0
|
|
} );
|
|
}
|
|
|
|
/**
|
|
* Updates CodeMirror button on the toolbar according to the current state (on/off).
|
|
*
|
|
* @private
|
|
*/
|
|
updateToolbarButton() {
|
|
// eslint-disable-next-line no-jquery/no-global-selector
|
|
const $button = $( '#mw-editbutton-codemirror' );
|
|
$button.toggleClass( 'mw-editbutton-codemirror-active', this.useCodeMirror );
|
|
|
|
// WikiEditor2010 OOUI ToggleButtonWidget
|
|
if ( $button.data( 'setActive' ) ) {
|
|
$button.data( 'setActive' )( this.useCodeMirror );
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Enables or disables CodeMirror.
|
|
*
|
|
* @fires CodeMirrorWikiEditor~'ext.CodeMirror.switch'
|
|
* @stable to call
|
|
*/
|
|
switchCodeMirror() {
|
|
if ( this.view ) {
|
|
this.setCodeMirrorPreference( false );
|
|
this.destroy();
|
|
mw.hook( 'ext.CodeMirror.switch' ).fire( false, this.$textarea );
|
|
} else {
|
|
this.enableCodeMirror();
|
|
this.setCodeMirrorPreference( true );
|
|
}
|
|
this.updateToolbarButton();
|
|
|
|
this.logUsage( {
|
|
editor: 'wikitext',
|
|
enabled: this.useCodeMirror,
|
|
toggled: true,
|
|
// eslint-disable-next-line no-jquery/no-global-selector,camelcase
|
|
edit_start_ts_ms: parseInt( $( 'input[name="wpStarttime"]' ).val(), 10 ) * 1000 || 0
|
|
} );
|
|
}
|
|
}
|
|
|
|
module.exports = CodeMirrorWikiEditor;
|