mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/CodeMirror
synced 2024-11-23 22:03:28 +00:00
13c9eae26e
This is toggled by pressing Mod-Shift-, (or Command-Shift-, on MacOS), which then puts focus on the preferences panel. It can be closed with the Escape key, just like other CM panels. The CodeMirror class comes with these extension which can be toggled in preferences: * Bracket matching * Line numbering * Line wrapping * Highlight the active line * Show special characters Only bracket matching, line numbering, and line wrapping are available in the 2017 editor. The bidi isolation and template folding extensions are registered in CodeMirrorModeMediaWiki as they are MW-specific. CodeMirrorPreferences' new registerExtension() method allows any consumer of CodeMirror to add any arbitrary extensions to the preferences panel. This is expected to be called *after* CodeMirror has finished initializing. The 'ext.CodeMirror.ready' hook now passes the CodeMirror instance to accommodate this. The preferences are stored as a single user option in the database, called 'codemirror-preferences'. The defaults can be configured with the $wgCodeMirrorDefaultPreferences configuration setting. The sysadmin-facing values are the familiar boolean, but since CodeMirror is widely used, we make extra efforts to reduce the storage footprint (see T54777). This includes only storing preferences that differ from the defaults, and using binary representation instead of boolean values, since the user option is stored as a string. For now, all preferences are ignored in the 2017 editor. In a future patch, we may add some as toggleable Tools in the VE toolbar. Other changes: * Refactor CSS to use a .darkmode() mixin * Add a method to create a CSS-only fieldset in CodeMirrorPanel * Fix Jest tests now that there are more calls to mw.user.options.get() * Adjust Selenium tests to always use CM6 * Adjust Selenium tests to delete test pages (useful for local dev) * Remove unused code Bug: T359498 Change-Id: I70dcf2f49418cea632c452c1266440effad634f3
41 lines
1.3 KiB
JavaScript
41 lines
1.3 KiB
JavaScript
'use strict';
|
|
|
|
const assert = require( 'assert' ),
|
|
EditPage = require( '../pageobjects/edit.page' ),
|
|
FixtureContent = require( '../fixturecontent' ),
|
|
UserPreferences = require( '../userpreferences' ),
|
|
Api = require( 'wdio-mediawiki/Api.js' ),
|
|
Util = require( 'wdio-mediawiki/Util' );
|
|
|
|
describe( 'CodeMirror bracket match highlighting for the wikitext 2010 editor', () => {
|
|
let title;
|
|
|
|
before( async () => {
|
|
title = Util.getTestString( 'CodeMirror-fixture1-' );
|
|
await UserPreferences.loginAsOther();
|
|
await FixtureContent.createFixturePage( title );
|
|
await UserPreferences.enableWikitext2010EditorWithCodeMirror();
|
|
} );
|
|
|
|
beforeEach( async () => {
|
|
await EditPage.openForEditing( title );
|
|
await EditPage.wikiEditorToolbar.waitForDisplayed();
|
|
await EditPage.clickText();
|
|
} );
|
|
|
|
it( 'highlights matching bracket', async () => {
|
|
await EditPage.cursorToPosition( 0 );
|
|
assert.strictEqual( await EditPage.getHighlightedMatchingBrackets(), '[]' );
|
|
} );
|
|
|
|
it( 'matches according to cursor movement', async () => {
|
|
await EditPage.cursorToPosition( 3 );
|
|
assert.strictEqual( await EditPage.getHighlightedMatchingBrackets(), '{}' );
|
|
} );
|
|
|
|
after( async () => {
|
|
const bot = await Api.bot();
|
|
bot.delete( title, 'Test cleanup' ).catch( ( e ) => console.error( e ) );
|
|
} );
|
|
} );
|