Derk-Jan Hartman
006d4ba9d8
Add comment to make usage of jquery.ui module discoverable
...
Change-Id: I79a54686024b22e2851bd396bb51101ca84626fa
2020-02-25 22:44:34 +00:00
Fomafix
b17c8b7557
Move check for 'usebetatoolbar' from JS to PHP
...
This change avoids useless loading of the module 'ext.CodeMirror'.
Change-Id: I2637487b72c028d272748f2891239401412f77b5
2020-02-23 20:50:17 +00:00
jenkins-bot
fc4d4b0c36
Merge "Do not load module 'ext.CodeMirror' when CodeEditor is active"
2019-03-20 21:31:03 +00:00
Fomafix
f0757cb0dc
Do not load module 'ext.CodeMirror' when CodeEditor is active
...
Change-Id: I8fd0de727f2ebb1bf9f23981438d6cafa962ad17
2019-03-20 21:01:35 +00:00
Derk-Jan Hartman
758523b65f
Conditionally load CodeMirror lib
...
Also remove two unneeded dependencies
Bug: T209824
Change-Id: I5b528bde346780ca5ae5d615c4ca0d617a6cd615
2019-03-14 23:31:18 +00:00
Ed Sanders
37b49bfdc4
build: Update eslint-config-wikimedia to 0.11.0
...
Change-Id: I7ca5276791d9add0709387422016d7193e8d9945
2019-03-06 12:10:29 +00:00
Fomafix
9c04302f23
Use 'wikiEditor-toolbar-doneInitialSections' as trigger
...
Also refactor out single use functions and call enableCodeMirror
from within addCodeMirrorToWikiEditor.
Change-Id: I77d37ae401483e187fe0bc355d7173b57fbe454b
2019-03-06 12:09:28 +00:00
Fomafix
4181729151
Wait for DOM ready before querying DOM
...
This avoids a race condition on loading.
Change-Id: I31c01f9c2b2025b4a46d5afc6ada5044f750eff7
2019-02-25 21:55:31 +01:00
Ed Sanders
7604581cc1
Remove obsolete aliases from closures
...
Bug: T208951
Change-Id: I64c2966b7c41d6b2b1911e2fb52e4c7364bf7964
2018-11-12 13:19:41 +00:00
James D. Forrester
8ac2d11b1b
Drop support for MediaWiki core's removed "2006 wikitext editor"
...
Change-Id: Ib8d104ddf104cfeeee1fc7a055293a03fe8e2d3d
2018-10-25 14:06:59 -07:00
Derk-Jan Hartman
d5124e2920
Make use of new WikiEditor 2010 toggle tool
...
Bug: T198781
Depends-On: I8b7fd41571a48fa4f6560790d94bb966972e740f
Change-Id: Id275142c0d50ca6a133129eebeee8cfc5c1ca99a
2018-07-25 01:12:28 +02:00
Derk-Jan Hartman
4ebe54a588
Focus before setting the cursor/selection
...
Bug: T197263
Change-Id: If5efed656746e3e40fcda118e487cdcb00e0114a
2018-06-26 21:55:09 +00:00
jenkins-bot
7fa197b2dc
Merge "Accessibility: mark syntaxhighlight button as a switch"
2018-06-18 16:04:35 +00:00
Derk-Jan Hartman
42e3dc7cdb
Accessibility: mark syntaxhighlight button as a switch
...
* Protect from setActive not being defined on the old toolbar button
* Use role is switch on the button, since WE only supports simple
buttons
* Add the checked attribute to reflect state of the toggle button
Bug: T196512
Bug: T197534
Change-Id: I48dfef1740f124105f65859ce4f51098f1157fd0
2018-06-18 15:53:37 +00:00
Derk-Jan Hartman
736c63fd0b
Accessibility: Disable both directions of tabbing in CodeMirror
...
Bug: T197534
Change-Id: Ia05c3ccbdb4baa8e701bf46478c42d2473777535
2018-06-17 19:24:14 +02:00
Max Semenik
f973652942
Disable ULS when CodeMirror is on
...
Bug: T194102
Change-Id: I25894d98a28e2c6096796ab912cc0ee04dd0a6e3
2018-05-30 13:07:07 -07:00
MusikAnimal
7d99bbefde
Remove 'Try syntax highlighting' popup for all users
...
A Node script was used to remove the now unused i18n messages.
This same script sorts the messages alphabetically, so it looks
like some unrelated messages were changed, but they weren't.
Bug: T191297
Change-Id: I69cce06133c1d055d31d12ebc8408123c187b574
2018-04-12 18:22:31 -04:00
Ed Sanders
6d92dd818d
Use upstream OOUI icons for WikiEditor toolbar
...
Also uses upstream tool-active styling, which was
based on cm-on.svg.
Depends-On: I3e6f65f6f290778d3fbfa22f5d212c26fee12a86
Change-Id: Ib42be9f8b87efe1387eb5c77698fd2f0af0a673d
2018-03-23 13:43:30 +00:00
Ed Sanders
cc611f4254
TextSelection: Make chainable methods chainable
...
Bug: T188119
Change-Id: I40030e1cbd3bc77a0db424d38cd61815deac2e12
2018-02-26 11:47:43 +00:00
Ed Sanders
3e0d9773d4
textSelection: Replace encapsulateSelection with replaceSelection
...
encapsulateSelection is now defined in terms of other methods,
so we don't need to duplicate it here.
Follows on from T185917.
Change-Id: I1f99b3140ed363658ed2724a58c8b34ef20769fa
2018-02-09 10:31:47 +00:00
Ed Sanders
b05b537744
Simplify textSelection overrides using 'register' and 'unregister'
...
Also add support for .textSelection() on the .CodeMirror element.
Change-Id: I46ac070ca141c3c2f993bee6ab898c96cb1edd4f
2018-01-30 06:38:50 +00:00
jenkins-bot
f3f82ae47a
Merge "Fix WikiEditor dependencies"
2018-01-04 16:30:22 +00:00
Ed Sanders
12d420b7e9
Fix WikiEditor dependencies
...
Change-Id: Ibaa17e581ada5fcb202217797e70f9fed2510ec4
2018-01-04 12:36:55 +00:00
Ed Sanders
9df6ec9df8
Expect that deprecated mediawiki.toolbar may not be available
...
Bug: T177098
Change-Id: Icaf51c234981b4572362a0d76bf0b4b6653f3854
2018-01-04 12:35:36 +00:00
Max Semenik
dee8f42080
Fix target detection for jquery.textSelection overrides
...
CM intercepted textSelection() globally but assumed
nobody will ever need to call it for anything but wpTexbox1.
Thus, attempts to get edit summary returned article text.
Lots of things can probably be fixed in this area, but here's
the beginning.
Bug: T177175
Bug: T179287
Depends-On: I113394a473e8fe534f17815676ec7014203db7d6
Change-Id: I72d7d72b2a891a0ad242a565dddc076fa6dd1bd1
2017-12-19 21:00:14 +00:00
Niharika Kohli
a6c9441490
Don't break codemirror if wikEdDiff is enabled, only if wikEd is enabled
...
Bug: T178348
Change-Id: If579d4da99f364e73dec5a7e6bed87019431386b
2017-12-05 19:15:12 +05:30
Fomafix
394a8b7183
Remove eslint-disable-next-line no-use-before-define
...
Since 7ac2322
this is not needed anymore.
Change-Id: I4cc5ea402286e418b30fd9ddba72c7ef434fbcb2
2017-11-25 23:07:57 +01:00
jenkins-bot
99b919f626
Merge "Execute codeMirror.save() on beforeunload"
2017-11-08 00:21:15 +00:00
jenkins-bot
5cd02ddca7
Merge "Moving code for adding the toolbar button to its own function"
2017-11-07 03:24:29 +00:00
jenkins-bot
d2855c76f4
Merge "Make textbox height flexible with CodeMirror"
2017-11-07 01:26:17 +00:00
Niharika Kohli
a0062e3100
Make textbox height flexible with CodeMirror
...
Bug: T170906
Bug: T176449 (hopefully)
Change-Id: Ic0ac663c413db5c29ae786d3c17f7396ad620226
2017-11-06 17:20:51 -08:00
Kaldari
a6e4f5c6d6
Prevent loading CodeMirror if wikEd gadget is enabled
...
Not a great solution, but will prevent most of the damage in the
meantime, for example, people losing their edits.
Bug: T178348
Change-Id: I434878a2325df01ad27f590f296738ff1f93320f
2017-11-06 14:48:50 -08:00
Kaldari
763e8cbf0b
Moving code for adding the toolbar button to its own function
...
This is to make the code more readable and easier to follow.
Change-Id: I6972038ca8a45bf3d0c119e93cf1af70dd424a82
2017-11-06 14:33:38 -08:00
Fomafix
7ac2322b23
Reorder functions to avoid forward references
...
The eslint-disable-next-line no-use-before-define are removed.
Change-Id: Ifad97ac467b7bf4b1051015129eca3e2f5a32807
2017-10-16 06:20:19 +02:00
jenkins-bot
36c096c86f
Merge "Remove call codeMirror.save()"
2017-10-13 01:55:20 +00:00
jenkins-bot
61bd4d7c92
Merge "Disable spellchecking for Firefox users on non-Mac systems"
2017-10-04 23:55:03 +00:00
jenkins-bot
02062173b6
Merge "Turn on native CodeMirror spellcheck feature"
2017-10-04 23:54:32 +00:00
Niharika Kohli
29f6b48eeb
Disable spellchecking for Firefox users on non-Mac systems
...
Bug: T95104
Change-Id: I86dbee82def94a38156f090d519f969f221c72e1
2017-10-04 15:37:02 -07:00
jenkins-bot
3f226d7223
Merge "Fix cursor position after extension loads"
2017-09-26 00:55:25 +00:00
Fomafix
058037bba2
Remove call codeMirror.save()
...
codeMirror.toTextArea() already calls codeMirror.save().
Change-Id: Ifeb8c482149540832d6389a9337baffbf9ec03fb
2017-09-19 14:10:34 +02:00
jenkins-bot
1b6637bd43
Merge "Fix for function mw.toolbar.insertTags in chrome and IE"
2017-09-15 23:00:20 +00:00
Niharika Kohli
150cf016b2
Turn on native CodeMirror spellcheck feature
...
It's not fullproof. There's bugs where it forgets a string is misspelled
after re-rendering. But it's better than nothing.
Bug: T95104
Change-Id: I33718a71ff5734912ac59be2cd9575dd662ec2f7
2017-09-14 12:59:44 -07:00
jenkins-bot
5128648e0b
Merge "i18n: use correct language and direction"
2017-09-13 18:45:12 +00:00
Ebrahim Byagowi
a3e4ea6789
i18n: use correct language and direction
...
Change-Id: I6fd368f923b52a299633acb361748317ec18bdd1
2017-09-13 22:32:46 +04:30
Pavel Astakhov
e727726d2a
Fix word jumping (option+arrow key) for Mac
...
Bug: T175378
Bug: T174055
Change-Id: I7f648691ec3b36f9abe1c5c7fbe5c97e142f500e
2017-09-11 13:56:00 -07:00
jenkins-bot
9ba136850c
Merge "Join the popup label into one message"
2017-09-11 20:19:03 +00:00
jenkins-bot
fdb006a17c
Merge "Fix home/end behavior"
2017-09-11 20:17:38 +00:00
jenkins-bot
dba972cf9c
Merge "Simplify setTimeout"
2017-09-11 18:57:43 +00:00
Fomafix
f740a5cb2f
Execute codeMirror.save() on beforeunload
...
This allows the browser to store the textarea on history changes.
Bug: T175509
Change-Id: I8cb2c492582e77bde0e666cd363d31e28bf960e4
2017-09-11 20:26:13 +02:00
Pavel Astakhov
701cdca90b
Fix home/end behavior
...
Bug: T174514
Change-Id: I0f07ac1f4f3bc3a42c620ce88be026fdf42450c6
2017-09-11 21:01:43 +06:00