Commit graph

791 commits

Author SHA1 Message Date
Ed Sanders 4d53bcbe09 VE: Don't load CodeMirror code until tool is activated
This saves about 300k uncompressed / 80k compressed whenever VE loads!

Change-Id: I7cf1c35292c2ea48cc15ceb4c22d4473a25484e9
2020-03-19 20:23:24 +00:00
libraryupgrader 2ea69d71ef build: Updating npm dependencies
* minimist: 0.0.8 → 1.2.5
  * https://npmjs.com/advisories/1179
* acorn: 7.1.1 → 7.1.1
  * https://npmjs.com/advisories/1488

Change-Id: I11461afeb50075494f9817203d4d41c079ec7a15
2020-03-18 05:13:57 +00:00
libraryupgrader cb036f3967 build: Updating acorn to 7.1.1
* https://npmjs.com/advisories/1488

Change-Id: If7ffdd683363d328fc63966e1ec1aa63c55ef3e9
2020-03-07 23:22:19 +00:00
jenkins-bot c48201dd17 Merge "Enable spellchecking on Firefox" 2020-03-07 11:10:54 +00:00
Translation updater bot c7728d6ffb Localisation updates from https://translatewiki.net.
Change-Id: Idd5c8f17805eac7792f2d7ae73034d96b93ab9cf
2020-03-05 08:37:52 +01:00
Derk-Jan Hartman 99db78cd23 CodeMirror: Add COPYING file and credit for CodeMirror authors
Bug: T234086
Change-Id: I44460b26fc367f0415073a7221226069799e1b1c
2020-03-02 21:34:06 +00:00
Fomafix 6075e4cb83 Enable spellchecking on Firefox
The spellchecking was disabled for Firefox on non-Mac systems because
Firefox had a bug and inserts characters (like B) into the content when
enter an access key combination (like Shift+Alt+B).

Firefox 65 fixed the problem by changing the default for
dom.keyboardevent.keypress.dispatch_non_printable_keys_only_system_group_in_content
from false to true.

The old behavior can activated in about:config by setting
dom.keyboardevent.keypress.dispatch_non_printable_keys_only_system_group_in_content = false

This change reverts 29f6b48eeb.

Bug: T177509
Change-Id: I23773b2ea2a154269a5b3064cd8d9e9132051c38
2020-02-29 22:54:43 +01:00
AronDemian d0418ae8bb Don't let CodeMirror set the font to monospace if it's set on an ancestor.
Bug: T245568
Change-Id: I135bf0f7bf73e0d9faaa43c565cef43c5c934a34
2020-02-29 18:01:27 +00:00
AronDemian d70bd9d1ae Unify monospace font stack. Avoid potential sizing bug caused by weird browser behavior with font-family: monospace;
Problem: browsers implicitly and unexpectedly set the font-size to something around 13px with `font-family: monospace;`, but not with `font-family: monospace,monospace;`.
See:  http://code.iamkate.com/html-and-css/fixing-browsers-broken-monospace-font-handling/

Bug: T176636
Change-Id: Ied24a0cde7db4a6092d2cd7a6207d0a361424c3f
Related: T245568
Related: T245476
2020-02-28 04:44:07 +00:00
Translation updater bot ba8da65530 Localisation updates from https://translatewiki.net.
Change-Id: Ia7a07cdcd3a71d8f1eed0a2c16a26a0f2395d1c3
2020-02-26 08:24:34 +01:00
Derk-Jan Hartman 006d4ba9d8 Add comment to make usage of jquery.ui module discoverable
Change-Id: I79a54686024b22e2851bd396bb51101ca84626fa
2020-02-25 22:44:34 +00:00
Fomafix b17c8b7557 Move check for 'usebetatoolbar' from JS to PHP
This change avoids useless loading of the module 'ext.CodeMirror'.

Change-Id: I2637487b72c028d272748f2891239401412f77b5
2020-02-23 20:50:17 +00:00
libraryupgrader 652c4585bd build: Updating npm dependencies
* grunt-stylelint: 0.13.0 → 0.14.0
* stylelint-config-wikimedia: 0.8.0 → 0.9.0

Change-Id: I21145215c3523a9b5923aa2a9b752f91b30a4dbc
2020-02-20 20:23:19 +00:00
AronDemian f0e689d203 Remove the unnecessary 1.5em padding in MinervaNeue skin that misaligns highlights.
Bug: T245532
Bug: T245568
Change-Id: Ib29678eb38ebb5a5d2975a087e55b2ddd2a4b35d
Related: I135bf0f7bf73e0d9faaa43c565cef43c5c934a34 - T245476
2020-02-19 15:00:43 +01:00
libraryupgrader af0eafb5b0 build: Updating composer dependencies
* mediawiki/minus-x: 0.3.2 → 1.0.0
* mediawiki/mediawiki-phan-config: 0.9.0 → 0.9.1

Change-Id: Ibf852b5e153cb7119ff356feea23c02a127c8467
2020-01-29 02:08:53 +00:00
libraryupgrader c03517c55e build: Updating jakub-onderka/php-console-highlighter to 0.4.0
Change-Id: I9a8119edf0c2cf595d63bf380512effa055c6be2
2020-01-28 07:25:19 +00:00
libraryupgrader c8b1a5b903 build: Updating mediawiki/mediawiki-codesniffer to 29.0.0
Additional changes:
* Also sorted "composer fix" command to run phpcbf last.

Change-Id: Iaab72bb924baab1d116ce2366b617cfa97a4ef31
2020-01-14 04:19:51 +00:00
libraryupgrader 8f250df41c build: Updating npm dependencies
* stylelint-config-wikimedia: 0.7.0 → 0.8.0
* grunt-stylelint: 0.12.0 → 0.13.0

Additional changes:
* Added .eslintcache to .gitignore.

Change-Id: Ie6e0ba151bb44cfbafe60e012d84f2c9ac9d3654
2020-01-09 04:54:00 +00:00
libraryupgrader 4edd5f7025 build: Updating mediawiki/mediawiki-phan-config to 0.9.0
Additional changes:
* Added .eslintcache to .gitignore.

Change-Id: I31fab756a474ced2557d0dccdb5dc181f9daa51e
2019-12-21 01:57:33 +00:00
libraryupgrader 6157d3807d build: Updating mediawiki/minus-x to 0.3.2
Change-Id: I5049a77d17fcdfd5a695145df5f63506efeaedfd
2019-12-16 21:11:13 +00:00
Bartosz Dziewoński 5a1501d46f VE: Update padding to match VisualEditor changes
See Ib7ffbf09d5aa23fddb894aa3b081ec993ddcee2d.

Bug: T238678
Change-Id: Ia9d38599e76b63147318c6604dbd9b9fabf35b16
2019-12-13 14:54:03 +00:00
Translation updater bot 1d9e814a32 Localisation updates from https://translatewiki.net.
Change-Id: If7cacd7f9db13a00f962c9a39f6ff76cc5710f58
2019-12-05 09:45:29 +01:00
Timo Tijhof 1bfbc6e045 Remove use of jquery.ui module aliases
This increases the extension's dependency to MW 1.34+.

Bug: T219604
Change-Id: Ic78f8eba5c18bfa6ee3e70277504cf7b17975387
2019-11-25 22:45:01 +00:00
jenkins-bot 796340ae08 Merge "Don't replace whitespace characters in VE" 2019-11-24 10:08:22 +00:00
Ed Sanders 4d8cca6473 build: Update linters
Change-Id: Icb1da99172253d5ccb7064885285dbb268e20fd3
2019-11-15 16:20:25 +00:00
Ed Sanders a134e66777 Don't replace whitespace characters in VE
Bug: T153434
Depends-On: Ic4a5ab803c89b3671f452579bca0da08b779bdfe
Change-Id: Ic3d848ff86cceceeeea9385bfc49ad2241e3801b
2019-11-14 22:30:32 +00:00
Ed Sanders cf9885b586 Match tabSize to surface view CSS property
For browsers that don't support the property, assume
the default value of 8 is used.

Change-Id: Icb9a97fa79e08458bf717903f1d7b68e433e7904
2019-11-14 22:30:32 +00:00
Umherirrender 7e571828a0 build: Updating mediawiki/mediawiki-phan-config to 0.8.0
Bug: T235049
Change-Id: Ibad5d500e94c7a9c824aa639d6b61b753b82a2cd
2019-11-01 23:58:39 +01:00
Translation updater bot d9123662b2 Localisation updates from https://translatewiki.net.
Change-Id: Ib987d95c68a2f5c5479e6cf5f3db58b17a41a7fb
2019-10-22 09:13:11 +02:00
James D. Forrester 58feba5454 build: Upgrade mediawiki-codesniffer to v28.0.0
Change-Id: I9a61017ab6d018482092cc3b418b17293555cdbb
2019-10-15 16:02:40 -07:00
Ed Sanders e65e832f73 build: Update linters
Change-Id: Ibfd882d833e6adde10606b3fd50ef8ec635e25bf
2019-10-07 16:53:12 +01:00
Translation updater bot ed7f1b7322 Localisation updates from https://translatewiki.net.
Change-Id: I7654cc3ab8fbd0f38332f1d1aca29f6c2e7bc52a
2019-10-02 09:20:27 +02:00
Ed Sanders 81ce8b33ee build: Update linters
Change-Id: I5a218a9099b3562b346bd8e96ee683d04bbaf85e
2019-09-17 14:47:54 +01:00
libraryupgrader 4436d9208b build: Updating eslint-utils to 1.4.2
* https://npmjs.com/advisories/1118

Additional changes:
* Added .eslintcache to .gitignore.

Change-Id: I9cd7461d6b5bc3994af4448c47fc5fbf5fd33164
2019-08-24 06:36:03 +00:00
Isarra 90ac9d3475 Remove Timeless VE styles, too many variables to do them properly here
Move this stuff to Timeless itself since we can just reuse the width cutoff
and padding variables directly there and don't need to worry about them
randomly changing.

Corresponding change: Ic64b9786cb7186dba3eb2042a3238149c3bb44c6

Bug: T230756
Change-Id: Ia7168341bcadbc60e307b58b67afc1975a2424f9
2019-08-20 20:26:45 +00:00
Translation updater bot 4b41fc6628 Localisation updates from https://translatewiki.net.
Change-Id: I7021d955b94c05edda365e9244298de4d96dcbe8
2019-08-05 09:40:25 +02:00
libraryupgrader a09dc1068c build: Updating lodash to 4.17.15
* https://npmjs.com/advisories/1065
* CVE-2019-10744

Change-Id: I0840ac125dfb8294c544de7c525ad0e3e2213f8c
2019-08-01 18:57:41 +00:00
Translation updater bot 2fe8083ad8 Localisation updates from https://translatewiki.net.
Change-Id: I17c06366f11358badda5b81dc2f62c121d2e4181
2019-07-26 08:55:03 +02:00
libraryupgrader dd036600a2 build: Updating dependencies
composer:
* mediawiki/mediawiki-codesniffer: 24.0.0 → 26.0.0

npm:
* set-value: 2.0.0 → 2.0.1
  * https://npmjs.com/advisories/1012
  * CVE-2019-10747
* union-value: 1.0.0 → 1.0.1
  * https://npmjs.com/advisories/1012
  * CVE-2019-10747
* mixin-deep: 1.3.1 → 1.3.2
  * https://npmjs.com/advisories/1013
  * CVE-2019-10746

Change-Id: Id1e7abc2694d127ea9654bbed738f4acf9766a92
2019-07-14 10:01:48 +00:00
James D. Forrester 3f695ac9e4 build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1
Change-Id: I03112a260fe167bceb13ad84bcd4dc410e2d4a6c
2019-07-09 14:01:11 -07:00
libraryupgrader 622e7e2540 build: Updating mediawiki/mediawiki-phan-config to 0.6.1
Change-Id: Id70cabf27fb06d9e14d1abb03b215a2e7347a340
2019-06-10 06:20:51 +00:00
libraryupgrader 617ef165ae build: Updating npm dependencies for security issues
* Updated grunt to 1.0.4, addressing:
  * https://npmjs.com/advisories/788
  * https://npmjs.com/advisories/813
* Updated stylelint-config-wikimedia to 0.6.0, addressing:
  * https://npmjs.com/advisories/786

Committed package-lock.json (T179229) too.

Change-Id: Ic8833f50c07bcc148b9925e62ae29a555517de3c
2019-06-08 02:20:21 +00:00
James D. Forrester f3b60f5742 build: Upgrade mediawiki/mediawiki-phan-config from 0.5.0 to 0.6.0
Change-Id: I3d82f025e21c552eb0cdf083db01c1bbdc949981
2019-05-19 13:11:02 +02:00
jenkins-bot 879f301e03 Merge "Highlight match end tag with different capitalization" 2019-05-15 21:25:47 +00:00
Translation updater bot f6f3c0d65a Localisation updates from https://translatewiki.net.
Change-Id: Id8812f15de531713a3ec7d71fd2ca4e119f53623
2019-05-10 09:18:46 +02:00
Derick Alangi 4b17eb952c Type hint &$defaultPreferences & clean onResourceLoaderTestModules
* Per https://www.mediawiki.org/wiki/Manual:Hooks/GetPreferences, it is
  strict on $preferences being an array, so type hinted it to conform.

* Remove legacy hook behavior for onResourceLoaderTestModules() hook in
  CodeMirrorHooks. See: https://w.wiki/3Az for more information. Also,
  added `@see` with link to the documentation of the hook used.

Change-Id: I0a2fac4b4d491abf8d2f661be32bf2e0d791c90b
2019-05-07 15:44:14 +01:00
James D. Forrester fdbf91ddeb build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
Change-Id: I72ecf30d45b6488971051140290e552094bc369f
2019-05-06 15:29:44 -07:00
Derk-Jan Hartman d1a3e49265 Highlight match end tag with different capitalization
This recoginizes <ref></Ref>

Bug: T179321
Change-Id: Ib1e501f97654a019281eddd6cc69ea3b979daec7
2019-04-14 01:25:40 +02:00
Umherirrender c9e1cc14a3 Add phan
Change-Id: I77ffd9a2f20c736a12528bd86ec6e2fa4425d167
2019-04-09 20:35:56 +02:00
Derick Alangi 5579001506 CodeMirrorHooks: Objects are passed by default as references
Documentation here: [[mw:Manual:Hooks/BeforePageDisplay]] also
says so about objects passed by defaults as references, no need
for the &.

Also, fixed onResourceLoaderTestModules() function header for the
$rl parameter, removed the & symbol and updated this hook's docs
here: [[mw:Manual:Hooks/ResourceLoaderTestModules]].

Change-Id: Ifdabc47a1a4f02aec4906edb800d360ca4febd76
2019-04-04 00:38:24 +01:00