Commit graph

873 commits

Author SHA1 Message Date
Thiemo Kreuz ff1c26e877 Add missing PHPUnit tests for better coverage
Change-Id: I242aa52a24a11de3db106e5e2c73bd6f2a95d80c
2020-10-08 10:18:45 +02:00
Translation updater bot effb782d7e Localisation updates from https://translatewiki.net.
Change-Id: Ie2e6d58dd457f5609a7c8c262f9a5f5730fdfeca
2020-09-30 08:41:22 +02:00
libraryupgrader 0a2f5ab225 build: Updating mediawiki/mediawiki-phan-config to 0.10.3
Change-Id: I1747ec159a73f783d87ef4b4714ba7426de4c7e5
2020-09-24 23:05:04 +00:00
Translation updater bot cd07272c23 Localisation updates from https://translatewiki.net.
Change-Id: I4353f595b3e17d01e291c738d41acc2802ec58c6
2020-09-21 08:29:02 +02:00
libraryupgrader 6588901edc build: Updating npm dependencies
* eslint-config-wikimedia: 0.16.2 → 0.17.0
* grunt: 1.2.1 → 1.3.0

Change-Id: I278fca1f9e622f1249f67e20dca8451a88095fbd
2020-09-05 11:09:53 +00:00
Thiemo Kreuz 3e9bb4fb08 Replace all .png images with rgba() background colors
The rgba() syntax is supported for a very, very long time now:
https://caniuse.com/#feat=mdn-css_types_color_alpha

Notes:

I realized the numbers in these file names are actually their
transparency in percent (more precisely their opaqueness).
4 is 4% which translates to 0.04 in the rgba() syntax.

I used Gimp to pick the opaque color values from the images.
Gimp makes this easy. No guesswork or calculations needed.

For multiple, stacked images I calculated the colors by
averaging their RGB values (considering how opaque each color
is). Note this is actually *more* precise than the stacked
images before. Stacking alpha colors is flawed. For example:
Let's say we have an rgba(255, 255, 255, 1) background.
Layering a half transparent rgba(255, 0, 0, 0.5) on top means
half the background shines through. This averages to
rgba( 255, 127, 127, 1). Now we stack rgba(0, 0, 0, 0.5) on
top. Again, half the background shines through, resulting in
rgba(127, 63, 63, 1).

When we apply the two colors the other way around, the result
is rgba(191, 63, 63, 1), a much brighter red.

This flaw doesn't happen when precalculating the averages, as
done in this patch.

Change-Id: I29026864714c5f90c2613af57f08693e7e2b996c
2020-08-11 14:24:20 +02:00
Translation updater bot eb2b184c47 Localisation updates from https://translatewiki.net.
Change-Id: I9c42dc0012b8dfda12aa7bffefdc2fc8eb59e32c
2020-07-21 09:10:49 +02:00
libraryupgrader 2e6df07619 build: Updating grunt to 1.2.1
Change-Id: I4c436acf28a54810bb7035c92bcaa66636daed6c
2020-07-18 02:49:18 +00:00
libraryupgrader d66ed8d702 build: Updating eslint-config-wikimedia to 0.16.2
Change-Id: Idfdc82e8ebc8981d58536bf3abd0a6e5b76cbc2a
2020-07-15 22:25:58 +00:00
jenkins-bot f40872ec83 Merge "Fix 'setSelection' in textSelection API" 2020-07-15 19:21:51 +00:00
Ed Sanders 9f566d6046 Fix 'setSelection' in textSelection API
focus needs to come after setSelection

Change-Id: Ib073ddad445e05c4bc042b9c382a7d74369e29e1
2020-07-12 15:10:58 +00:00
Pavel Astakhov a9da1fa59e Load pluginModules in CodeMirrorAction class
Change-Id: Ia698be63171868cf568b136df89ce3e48eab1340
2020-07-10 17:12:23 +06:00
libraryupgrader 35593d526e build: Updating lodash to 4.17.19
* https://npmjs.com/advisories/1523
* CVE-2019-10744

Change-Id: I1e138a3c826b4b5817f8ee612b9ac7cfec84257b
2020-07-09 04:43:40 +00:00
Ed Sanders 89f52f6fbb VE: Add explicit dependency on targetLoader
Change-Id: I3d67837b462e0b79e124eff158bd7f88b5aaf63e
2020-06-30 22:47:41 +01:00
Ed Sanders 2518861bc1 build: Update devDependencies
Change-Id: I2f2967a1525c6a66eba2f5fc225e74b89380c5dd
2020-06-12 22:51:38 +01:00
libraryupgrader e849f7feb2 build: Updating mediawiki/minus-x to 1.1.0
Change-Id: Ie2fc67295839fc54381427b68f0b2f4bccfd87ee
2020-06-08 06:50:27 +00:00
libraryupgrader 3f8a9e9f21 build: Updating mediawiki/mediawiki-phan-config to 0.10.2
Additional changes:
* Removed phan-taint-check-plugin from extra, now inherited from mediawiki-phan-config.

Change-Id: I71e11b4cb6129fb9ed4380686da8d96efa9b9fda
2020-06-02 10:37:08 +00:00
libraryupgrader 781dea919d build: Updating composer dependencies
* php-parallel-lint/php-console-highlighter: 0.4.0 → 0.5.0
* php-parallel-lint/php-parallel-lint: 1.0.0 → 1.2.0

Additional changes:
* Replaced "jakub-onderka" packages with "php-parallel-lint".

Change-Id: If172ac9a842ba5495374ac974349fa1d91d42b1b
2020-05-31 01:08:19 +00:00
libraryupgrader 2d843a31c3 build: Updating mediawiki/mediawiki-codesniffer to 31.0.0
Additional changes:
* Replaced "jakub-onderka" packages with "php-parallel-lint".

Change-Id: Ieff06ce69212205a73c29e80459f6ef9031e1488
2020-05-29 10:17:30 +00:00
Reedy 55e2bd0558 Move CodeMirrorPluginModules from config to attributes
Change-Id: I38c33f5d140a88f9eda1df7094a203fd7009412e
2020-05-12 18:29:44 +00:00
jenkins-bot 3a62cc522b Merge "Convert to manifest_version 2" 2020-05-12 17:43:30 +00:00
Reedy 58289325f4 Convert to manifest_version 2
Bug: T252470
Change-Id: I23fea7028e5adc0a95b783aa0a3caf80c04f6a00
2020-05-12 16:53:47 +00:00
Bartosz Dziewoński d23ffa17cb Update VisualEditor styles for Vector changes
Bug: T252471
Change-Id: I6ba64f2deaa27172842ee5f71363708758324aff
2020-05-12 00:42:03 +02:00
James D. Forrester 63e30576de extension.json: Simplify hook calls as we only ever use one
Change-Id: Idcf9725791cc9f861ca2708c0cd25f45f0d9d68f
2020-05-11 20:20:08 +00:00
James D. Forrester 85e56bb200 Use QUnitTestModule instead of deprecated ResourceLoaderTestModules
Bug: T232875
Change-Id: I84276ff7c30b9c1db5dd8e9532512d7f586ab401
2020-05-11 20:19:57 +00:00
Translation updater bot 8829e2335c Localisation updates from https://translatewiki.net.
Change-Id: Iafda988fbcd1c3479874eab0aed08c401720fb5f
2020-05-11 08:36:40 +02:00
libraryupgrader 32f0200ad4 build: Updating dependencies
composer:
* mediawiki/mediawiki-codesniffer: 29.0.0 → 30.0.0

npm:
* eslint-config-wikimedia: 0.15.0 → 0.15.3
  The following rules are failing and were disabled:
  * mediawiki/class-doc

* grunt-stylelint: 0.14.0 → 0.15.0
* stylelint-config-wikimedia: 0.9.0 → 0.10.1

Change-Id: Ib86ef0f1d74240a618b5694c2c749d63184d2956
2020-04-22 06:41:41 +00:00
libraryupgrader cf387d01e3 build: Updating grunt-banana-checker to 0.9.0
Change-Id: Iec901e0732834e33485de78d48ac49a5865d404c
2020-04-19 02:15:36 +00:00
Translation updater bot b1cfbd5c50 Localisation updates from https://translatewiki.net.
Change-Id: I66cb090f96a74c6ab7f1e3a896a913bdd390745a
2020-04-07 08:37:52 +02:00
libraryupgrader e67a7afea5 build: Updating gonzales-pe to 4.3.0
* https://npmjs.com/advisories/1179

Change-Id: Ie0d2c3157b438d18bfa6f4601cc6fd25bc6a1173
2020-03-31 01:45:39 +00:00
Translation updater bot 6658120c09 Localisation updates from https://translatewiki.net.
Change-Id: I22261db75a684615a7151cfde3b7e34009862b7c
2020-03-25 08:32:15 +01:00
libraryupgrader 0d0638ccdd build: Updating npm dependencies
* mkdirp: 0.5.1 → 0.5.3
  * https://npmjs.com/advisories/1179
* eslint: 6.4.0 → 6.8.0
  * https://npmjs.com/advisories/1179
* acorn: 7.1.1 → 7.1.1
  * https://npmjs.com/advisories/1488

Change-Id: I8a598755f021cf193929c88d3d64aa4add72b5e1
2020-03-20 21:04:34 +00:00
Ed Sanders 4d53bcbe09 VE: Don't load CodeMirror code until tool is activated
This saves about 300k uncompressed / 80k compressed whenever VE loads!

Change-Id: I7cf1c35292c2ea48cc15ceb4c22d4473a25484e9
2020-03-19 20:23:24 +00:00
libraryupgrader 2ea69d71ef build: Updating npm dependencies
* minimist: 0.0.8 → 1.2.5
  * https://npmjs.com/advisories/1179
* acorn: 7.1.1 → 7.1.1
  * https://npmjs.com/advisories/1488

Change-Id: I11461afeb50075494f9817203d4d41c079ec7a15
2020-03-18 05:13:57 +00:00
libraryupgrader cb036f3967 build: Updating acorn to 7.1.1
* https://npmjs.com/advisories/1488

Change-Id: If7ffdd683363d328fc63966e1ec1aa63c55ef3e9
2020-03-07 23:22:19 +00:00
jenkins-bot c48201dd17 Merge "Enable spellchecking on Firefox" 2020-03-07 11:10:54 +00:00
Translation updater bot c7728d6ffb Localisation updates from https://translatewiki.net.
Change-Id: Idd5c8f17805eac7792f2d7ae73034d96b93ab9cf
2020-03-05 08:37:52 +01:00
Derk-Jan Hartman 99db78cd23 CodeMirror: Add COPYING file and credit for CodeMirror authors
Bug: T234086
Change-Id: I44460b26fc367f0415073a7221226069799e1b1c
2020-03-02 21:34:06 +00:00
Fomafix 6075e4cb83 Enable spellchecking on Firefox
The spellchecking was disabled for Firefox on non-Mac systems because
Firefox had a bug and inserts characters (like B) into the content when
enter an access key combination (like Shift+Alt+B).

Firefox 65 fixed the problem by changing the default for
dom.keyboardevent.keypress.dispatch_non_printable_keys_only_system_group_in_content
from false to true.

The old behavior can activated in about:config by setting
dom.keyboardevent.keypress.dispatch_non_printable_keys_only_system_group_in_content = false

This change reverts 29f6b48eeb.

Bug: T177509
Change-Id: I23773b2ea2a154269a5b3064cd8d9e9132051c38
2020-02-29 22:54:43 +01:00
AronDemian d0418ae8bb Don't let CodeMirror set the font to monospace if it's set on an ancestor.
Bug: T245568
Change-Id: I135bf0f7bf73e0d9faaa43c565cef43c5c934a34
2020-02-29 18:01:27 +00:00
AronDemian d70bd9d1ae Unify monospace font stack. Avoid potential sizing bug caused by weird browser behavior with font-family: monospace;
Problem: browsers implicitly and unexpectedly set the font-size to something around 13px with `font-family: monospace;`, but not with `font-family: monospace,monospace;`.
See:  http://code.iamkate.com/html-and-css/fixing-browsers-broken-monospace-font-handling/

Bug: T176636
Change-Id: Ied24a0cde7db4a6092d2cd7a6207d0a361424c3f
Related: T245568
Related: T245476
2020-02-28 04:44:07 +00:00
Translation updater bot ba8da65530 Localisation updates from https://translatewiki.net.
Change-Id: Ia7a07cdcd3a71d8f1eed0a2c16a26a0f2395d1c3
2020-02-26 08:24:34 +01:00
Derk-Jan Hartman 006d4ba9d8 Add comment to make usage of jquery.ui module discoverable
Change-Id: I79a54686024b22e2851bd396bb51101ca84626fa
2020-02-25 22:44:34 +00:00
Fomafix b17c8b7557 Move check for 'usebetatoolbar' from JS to PHP
This change avoids useless loading of the module 'ext.CodeMirror'.

Change-Id: I2637487b72c028d272748f2891239401412f77b5
2020-02-23 20:50:17 +00:00
libraryupgrader 652c4585bd build: Updating npm dependencies
* grunt-stylelint: 0.13.0 → 0.14.0
* stylelint-config-wikimedia: 0.8.0 → 0.9.0

Change-Id: I21145215c3523a9b5923aa2a9b752f91b30a4dbc
2020-02-20 20:23:19 +00:00
AronDemian f0e689d203 Remove the unnecessary 1.5em padding in MinervaNeue skin that misaligns highlights.
Bug: T245532
Bug: T245568
Change-Id: Ib29678eb38ebb5a5d2975a087e55b2ddd2a4b35d
Related: I135bf0f7bf73e0d9faaa43c565cef43c5c934a34 - T245476
2020-02-19 15:00:43 +01:00
libraryupgrader af0eafb5b0 build: Updating composer dependencies
* mediawiki/minus-x: 0.3.2 → 1.0.0
* mediawiki/mediawiki-phan-config: 0.9.0 → 0.9.1

Change-Id: Ibf852b5e153cb7119ff356feea23c02a127c8467
2020-01-29 02:08:53 +00:00
libraryupgrader c03517c55e build: Updating jakub-onderka/php-console-highlighter to 0.4.0
Change-Id: I9a8119edf0c2cf595d63bf380512effa055c6be2
2020-01-28 07:25:19 +00:00
libraryupgrader c8b1a5b903 build: Updating mediawiki/mediawiki-codesniffer to 29.0.0
Additional changes:
* Also sorted "composer fix" command to run phpcbf last.

Change-Id: Iaab72bb924baab1d116ce2366b617cfa97a4ef31
2020-01-14 04:19:51 +00:00
libraryupgrader 8f250df41c build: Updating npm dependencies
* stylelint-config-wikimedia: 0.7.0 → 0.8.0
* grunt-stylelint: 0.12.0 → 0.13.0

Additional changes:
* Added .eslintcache to .gitignore.

Change-Id: Ie6e0ba151bb44cfbafe60e012d84f2c9ac9d3654
2020-01-09 04:54:00 +00:00