Fomafix
394a8b7183
Remove eslint-disable-next-line no-use-before-define
...
Since 7ac2322
this is not needed anymore.
Change-Id: I4cc5ea402286e418b30fd9ddba72c7ef434fbcb2
2017-11-25 23:07:57 +01:00
jenkins-bot
99b919f626
Merge "Execute codeMirror.save() on beforeunload"
2017-11-08 00:21:15 +00:00
jenkins-bot
5cd02ddca7
Merge "Moving code for adding the toolbar button to its own function"
2017-11-07 03:24:29 +00:00
jenkins-bot
d2855c76f4
Merge "Make textbox height flexible with CodeMirror"
2017-11-07 01:26:17 +00:00
Niharika Kohli
a0062e3100
Make textbox height flexible with CodeMirror
...
Bug: T170906
Bug: T176449 (hopefully)
Change-Id: Ic0ac663c413db5c29ae786d3c17f7396ad620226
2017-11-06 17:20:51 -08:00
Kaldari
a6e4f5c6d6
Prevent loading CodeMirror if wikEd gadget is enabled
...
Not a great solution, but will prevent most of the damage in the
meantime, for example, people losing their edits.
Bug: T178348
Change-Id: I434878a2325df01ad27f590f296738ff1f93320f
2017-11-06 14:48:50 -08:00
Kaldari
763e8cbf0b
Moving code for adding the toolbar button to its own function
...
This is to make the code more readable and easier to follow.
Change-Id: I6972038ca8a45bf3d0c119e93cf1af70dd424a82
2017-11-06 14:33:38 -08:00
Fomafix
7ac2322b23
Reorder functions to avoid forward references
...
The eslint-disable-next-line no-use-before-define are removed.
Change-Id: Ifad97ac467b7bf4b1051015129eca3e2f5a32807
2017-10-16 06:20:19 +02:00
jenkins-bot
36c096c86f
Merge "Remove call codeMirror.save()"
2017-10-13 01:55:20 +00:00
jenkins-bot
61bd4d7c92
Merge "Disable spellchecking for Firefox users on non-Mac systems"
2017-10-04 23:55:03 +00:00
jenkins-bot
02062173b6
Merge "Turn on native CodeMirror spellcheck feature"
2017-10-04 23:54:32 +00:00
Niharika Kohli
29f6b48eeb
Disable spellchecking for Firefox users on non-Mac systems
...
Bug: T95104
Change-Id: I86dbee82def94a38156f090d519f969f221c72e1
2017-10-04 15:37:02 -07:00
jenkins-bot
3f226d7223
Merge "Fix cursor position after extension loads"
2017-09-26 00:55:25 +00:00
Fomafix
058037bba2
Remove call codeMirror.save()
...
codeMirror.toTextArea() already calls codeMirror.save().
Change-Id: Ifeb8c482149540832d6389a9337baffbf9ec03fb
2017-09-19 14:10:34 +02:00
jenkins-bot
1b6637bd43
Merge "Fix for function mw.toolbar.insertTags in chrome and IE"
2017-09-15 23:00:20 +00:00
Niharika Kohli
150cf016b2
Turn on native CodeMirror spellcheck feature
...
It's not fullproof. There's bugs where it forgets a string is misspelled
after re-rendering. But it's better than nothing.
Bug: T95104
Change-Id: I33718a71ff5734912ac59be2cd9575dd662ec2f7
2017-09-14 12:59:44 -07:00
jenkins-bot
5128648e0b
Merge "i18n: use correct language and direction"
2017-09-13 18:45:12 +00:00
Ebrahim Byagowi
a3e4ea6789
i18n: use correct language and direction
...
Change-Id: I6fd368f923b52a299633acb361748317ec18bdd1
2017-09-13 22:32:46 +04:30
Pavel Astakhov
e727726d2a
Fix word jumping (option+arrow key) for Mac
...
Bug: T175378
Bug: T174055
Change-Id: I7f648691ec3b36f9abe1c5c7fbe5c97e142f500e
2017-09-11 13:56:00 -07:00
jenkins-bot
9ba136850c
Merge "Join the popup label into one message"
2017-09-11 20:19:03 +00:00
jenkins-bot
fdb006a17c
Merge "Fix home/end behavior"
2017-09-11 20:17:38 +00:00
jenkins-bot
dba972cf9c
Merge "Simplify setTimeout"
2017-09-11 18:57:43 +00:00
Fomafix
f740a5cb2f
Execute codeMirror.save() on beforeunload
...
This allows the browser to store the textarea on history changes.
Bug: T175509
Change-Id: I8cb2c492582e77bde0e666cd363d31e28bf960e4
2017-09-11 20:26:13 +02:00
Pavel Astakhov
701cdca90b
Fix home/end behavior
...
Bug: T174514
Change-Id: I0f07ac1f4f3bc3a42c620ce88be026fdf42450c6
2017-09-11 21:01:43 +06:00
Fomafix
eca881d11f
Simplify setTimeout
...
* Use setTimeout instead of window.setTimeout.
* Directly call function and avoid anonymous function.
Change-Id: Ic396ef744d58fb722761a66f38390d2bb4848c2d
2017-09-11 16:19:55 +02:00
Sam Wilson
b4b9da7e51
Join the popup label into one message
...
The popup label was being styled as two words from two different
i18n messages, each a different colour. This combines them into
one, moves the identifing class name up to the outer span, and
colours both words blue (the outer braces are left black).
Bug: T174219
Change-Id: Id1166f48ae4b3b8daff29be56dd92ef330dd9cef
2017-09-11 10:23:22 +08:00
Niharika Kohli
279103fea9
Render everything as long as user doesn't start typing/moving cursor
...
Bug: T174480
Change-Id: I106b1d0d2a68e8ba2b346fd6aaf06b530d18f8d4
2017-09-08 14:11:01 -07:00
jenkins-bot
94a08e27d6
Merge "Do not redefine the browser history navigation keys Alt-Left and Alt-Right"
2017-09-04 09:06:57 +00:00
Pavel Astakhov
f71d17d8d1
Fix for function mw.toolbar.insertTags in chrome and IE
...
Bug: T164905
Change-Id: I15b60944a95f94b4a2e3b929fe4d00fe757961bd
2017-09-04 14:54:26 +06:00
Pavel Astakhov
e1eaac762d
Fix cursor position after extension loads
...
Bug: T174547
Change-Id: I8ce2c61884410c4ca47bd8cbc11d0902df7f1d4a
2017-09-04 13:49:06 +06:00
Ed Sanders
41f57b2184
Don't assume action=edit/submit is the old wikitext editor
...
VE will hijack action=edit, and not render the textarea.
Instead check for the textarea directly.
Change-Id: I024d130cd64dd755321f044c372bdcc8b7cdb5f2
2017-08-25 15:14:37 +01:00
Fomafix
ae8696fea6
Do not redefine the browser history navigation keys Alt-Left and Alt-Right
...
Bug: T174055
Change-Id: I1e2acb927dfcc0799b78b2dc045c0208246ba111
2017-08-24 20:00:01 +02:00
Bartosz Dziewoński
3a1589d527
Remove a workaround to clear broken 'background-image'
...
No longer needed after Ib658651e04090ec4f5bc1f5bacbbfb0d7e7f893e
in WikiEditor.
Bug: T172500
Change-Id: I22e5a854ed6ee657d5f6c416cb4412184d10f1ac
2017-08-04 14:38:09 +02:00
Kaldari
28a9dd7fac
Only show popup if CodeMirror button exists
...
Bug: T170609
Change-Id: Ibe9aa1b7ffce2e7813aa9aa2ab45f349d8ad2082
2017-08-03 15:57:49 -07:00
jenkins-bot
bff703563d
Merge "Preserve scroll position when switching"
2017-07-24 16:35:28 +00:00
Ed Sanders
7fe9e2e762
Popup: Use built-in features of PopupWidget instead of custom CSS
...
* Use OOUI buttons for the actions.
* Make the widget wider to accommodate longer titles in
different languages.
* Don't show if CM already enabled
Change-Id: Ibde461a99929565c15b5e7c5ef3ad88e163fba05
2017-07-20 21:30:45 +00:00
Ed Sanders
60ab939b26
Popup: Build as DOM instead of HTML strings
...
Change-Id: Ib33b6b2a1f3e0f9c50398287822ae88305855a58
2017-07-20 21:30:37 +00:00
Ed Sanders
643faba0db
Preserve scroll position when switching
...
This will be slightly off when you have scrolled past
headers which have a different font size, but it's better
than jumping back to the top of the document.
Change-Id: I62a73c30932c3dc1e538484edead9c5d2ed6c72f
2017-07-20 19:12:38 +01:00
Kaldari
4fc52b7ba3
Make sure enhanced editing toolbar is loaded before adding button
...
Bug: T169943
Change-Id: Id8828b0d49ecec5124430d15445739d73795d164
2017-07-10 14:16:36 -07:00
Niharika29
55092521c3
Make sure popup appears for both classic and wikitext editors
...
Bug: T165003
Change-Id: I4b1c9498df7931643ea3c39d6d2afd9384e47de0
2017-07-04 00:15:56 +00:00
Niharika29
a1b41c6099
Fixes for Codemirror popup patch
...
Bug: T165003
Change-Id: I52e3cdb3afde242451e9cab68baecc1ab77868dc
2017-06-30 18:43:50 +00:00
Niharika29
99e31d152f
Show a popup for first time Codemirror users
...
Bug: T165003
Change-Id: I545a57bdb273ab6906711e2d65dc029293ecc02a
2017-06-29 00:20:14 +00:00
Pavel Astakhov
8ff5f6afee
Replace CodeMirror icons with new icons (#36C)
...
Bug: T164441
Change-Id: I2e185dfa468ede51bd1a0e41b3b4dcf43a74313c
2017-05-14 23:44:17 +06:00
Ed Sanders
59aed7d2e2
build: Update eslint to 0.4.0 and make a pass
...
Change-Id: I580e7a2ed7276dc3b9546b497ecf2f8f4efe1aa6
2017-05-08 16:54:10 +01:00
Ed Sanders
de6b08919b
Use consistent label for button across editors
...
Change-Id: I1a299522e95cdb4a6e5bdbdda1c65d4fcec22133
2017-05-08 16:54:10 +01:00
Pavel Astakhov
c9b4aa65fd
Refactor the Integration with other extensions (v 4.0.0)
...
This patch makes initialization easier and cheaper.
Since only the PhpTags extension uses the CodeMirrorGetAdditionalResources
hook it was removed. Instead, the CodeMirrorPluginModules and
CodeMirrorTagModes properties are used in extension.json file.
This patch adds ext.CodeMirror.lib.mode.php module for the PhpTags
extension (with dependences). In CodeMirror there are a lot of modes
they will be registered on request (if they will be requered for
extensions).
Examples of integration:
* Cite: I1bf156fa813af4d5f891619f692047bbdb8a1a86
* PhpTags: Ie339f0475e63885e603defaee2cdcccd6a95fafc
Bug: T163238
Change-Id: Idb7a1a5769a1047ef2f7cd25a7152f73a6613225
2017-05-04 21:20:21 +01:00
jenkins-bot
8f8a68f056
Merge "wikiEditorToolbarEnabled: Rewrite if block as statement"
2017-04-27 01:45:49 +00:00
jenkins-bot
0f22c06b9c
Merge "Swap the enable/disable labels"
2017-04-26 17:19:25 +00:00
Pavel Astakhov
3954552b43
Swap the enable/disable labels
...
Bug: T163916
Change-Id: Ie868556fe31ea4aae976e94526cc96bb79803626
2017-04-26 22:48:13 +06:00
Ed Sanders
9205f900bd
wikiEditorToolbarEnabled: Rewrite if block as statement
...
Change-Id: I516a8e8f1bf53dc784a2ab3ff49bd20b172dc6e8
2017-04-20 23:31:58 +01:00