Commit graph

1082 commits

Author SHA1 Message Date
Fomafix 9c04302f23 Use 'wikiEditor-toolbar-doneInitialSections' as trigger
Also refactor out single use functions and call enableCodeMirror
from within addCodeMirrorToWikiEditor.

Change-Id: I77d37ae401483e187fe0bc355d7173b57fbe454b
2019-03-06 12:09:28 +00:00
jenkins-bot 8a1e8552f3 Merge "Wait for DOM ready before querying DOM" 2019-03-06 11:59:14 +00:00
Fomafix 4181729151 Wait for DOM ready before querying DOM
This avoids a race condition on loading.

Change-Id: I31c01f9c2b2025b4a46d5afc6ada5044f750eff7
2019-02-25 21:55:31 +01:00
Fomafix ebd382f004 Make Special:JavaScriptTest pass on Webkit and on Firefox
CodeMirror inserts

 style="padding-right: 0.1px;"

only on Webkit.

The test case now strips this pattern from the rendered HTML before
comparing with the expected test case output.

Change-Id: I34b201f790d3d85a5f51d8200bf8219f11d14506
2019-02-25 08:14:58 +01:00
Fomafix 5161c6abe9 Make Special:JavaScriptTest pass with and without extension Cite
Change-Id: Ib3bae7968c7d1eb0d5f862f0410f016f47abcd15
2019-02-25 08:10:32 +01:00
libraryupgrader 7e059f7247 build: Updating mediawiki/mediawiki-codesniffer to 24.0.0
Change-Id: I7a7d9b19547b1a41e33d8201b96949e7f4be7e14
2019-02-06 11:38:13 +00:00
Translation updater bot 817c566c17 Localisation updates from https://translatewiki.net.
Change-Id: Ib0ea53d3b688a1c7eac16a987c1a3f00532b9300
2019-01-08 22:29:30 +01:00
Translation updater bot 4905b36b1e Localisation updates from https://translatewiki.net.
Change-Id: Ia87313bd579005861b0313003f8aba7d7d1a80b2
2019-01-05 22:33:37 +01:00
Kunal Mehta b5a2b5deec build: Set "root": true, in .eslintrc.json
This ensures that each repository's "npm test" command is fully
independent of wherever it might be in the filesystem.

Bug: T206485
Change-Id: I7f96f21d586e198abbeb965471dec620abecd845
2018-12-17 18:54:12 -08:00
Translation updater bot 29cc48e113 Localisation updates from https://translatewiki.net.
Change-Id: I3534f3a4362ce40ee43ef55adaa726e6a6fc6d37
2018-12-14 22:21:37 +01:00
Ed Sanders 71dcfc6adb build: Update devDependencies
Change-Id: Id99fb30b37e3951705fc52c76b1de6d9f73abf17
2018-12-04 17:59:57 -05:00
James D. Forrester 854b63e18a eslint: Drop 'dot-notation' rule
Bug: T210552
Change-Id: I76b2f32645ba43927b424a1fea5bc3bf2d08447b
2018-11-28 10:31:21 -08:00
libraryupgrader c90c27c444 build: Updating mediawiki/mediawiki-codesniffer to 23.0.0
Change-Id: I72b3448a69ee1e78b7385f882b1084f5299b73a1
2018-11-14 09:25:52 +00:00
Ed Sanders 7604581cc1 Remove obsolete aliases from closures
Bug: T208951
Change-Id: I64c2966b7c41d6b2b1911e2fb52e4c7364bf7964
2018-11-12 13:19:41 +00:00
Translation updater bot f9614332a1 Localisation updates from https://translatewiki.net.
Change-Id: I00b941e4a546d784c63352575d455fcb0cf4a0b2
2018-11-10 22:28:06 +01:00
jenkins-bot 3bd196fb93 Merge "Drop support for MediaWiki core's removed "2006 wikitext editor"" 2018-11-07 12:26:44 +00:00
Translation updater bot d0763f88a9 Localisation updates from https://translatewiki.net.
Change-Id: I9e0313475a53e5788f48b62201d18459457c7ec5
2018-11-04 22:42:04 +01:00
James D. Forrester 8ac2d11b1b Drop support for MediaWiki core's removed "2006 wikitext editor"
Change-Id: Ib8d104ddf104cfeeee1fc7a055293a03fe8e2d3d
2018-10-25 14:06:59 -07:00
Bartosz Dziewoński 079d240a2c ve.ui.CodeMirror: Fix padding to match VisualEditor's padding
VisualEditor's default padding for the source editing surface was
changed in Icdc6f1e2a7544ebbd828f85ff370113a0e06983a (June 2018).

Since then the alignment of editing surface and CodeMirror syntax
highlighting surface was broken in skins that don't override the
default padding (basically every skin except Vector and MonoBook).
Unfortunately Vector and MonoBook happen to be the only skins we
officially support and actually test, so the issue went unnoticed.

Bug: T205154
Bug: T205658
Change-Id: Ic85a6c20b266f6b93ab8ec9c2d35acff679f31bc
2018-09-27 22:06:00 +02:00
Ed Sanders ef8c62c74b Use renamed ve.visibleWhitespaceCharacters
Change-Id: I246079505d4c37406b3f99ca17b7e8e926adaec5
2018-09-24 16:34:54 +01:00
jenkins-bot 7dd9688663 Merge "build: Update linters" 2018-09-13 12:27:47 +00:00
Ed Sanders 1be09a9a1d build: Update linters
Change-Id: I8d3aaf0b7d453033b72e5d6622b8f54df2c86bca
2018-09-12 00:03:19 +01:00
Umherirrender 7cd71f47a7 Remove @staticvar doc annotation
It is unknown to doxygen

Change-Id: I60e98eb3a7e74796e877fd70e8b9b67b5e3b60df
2018-09-09 20:04:35 +02:00
libraryupgrader 9cdee0421a build: Updating mediawiki/phan-taint-check-plugin to 1.5.0
Change-Id: I5a0c270625959fa43841f703df10ca9a08a32a7c
2018-09-07 08:12:20 +00:00
libraryupgrader 10af14ec3c build: Updating mediawiki/mediawiki-codesniffer to 22.0.0
Change-Id: Ifdf12fd08cd94ba64a56433ea6bac4f86ae7c8ac
2018-09-02 23:49:04 +00:00
libraryupgrader 2c9734d45f build: Updating mediawiki/phan-taint-check-plugin to 1.4.0
Change-Id: I88133dca11d56d556dbcdf6f4eddfa9afa2af80c
2018-09-01 06:51:09 +00:00
jenkins-bot ee1769ae00 Merge "Make use of new WikiEditor 2010 toggle tool" 2018-08-21 19:15:45 +00:00
libraryupgrader 18b1f64a60 build: Updating mediawiki/phan-taint-check-plugin to 1.3.0
And updating CoC link to use Special:MyLanguage (T202047).

Change-Id: I7a7769b623a7717d100fe6665ff90292ecf1fc73
2018-08-19 10:46:12 +00:00
Kunal Mehta 35edfa6018 Use new Parser accessors
And there's no need to manually call firstCallInit() anymore, the
Parser will call it in all the necessary places automatically.

Depends-On: Ida62767f3ca53f99609cae01d3a20051bb92ccab
Depends-On: Ia2d98baf6caed2cd779cb00aceba5785cf13d633
Change-Id: I7e2097fa733506985a4b252fc9b01b03f6c28885
2018-08-13 22:56:03 -07:00
Kunal Mehta 0ba594b8ad Don't use deprecated MagicWord methods
Change-Id: I992b966f25cea52002cb8ee91f94dd92ff8c717f
2018-08-12 21:44:24 -07:00
Fomafix 9bda90be76 Get Parser from service instead of global $wgParser
Also always call firstCallInit() which already calls
initialiseVariables().

Change-Id: I55808175c18430a0021e115b27c672635a62669b
2018-08-12 10:34:00 +02:00
Fomafix ca7f33f8ef Use ContentLanguage service instead of global $wgContLang
Depends-On: I193f5b9a95430b0a05573c361715e053e5411e32
Change-Id: I2b6b2392c5be923657cd508459662ba643b21362
2018-08-05 00:33:03 +02:00
Kunal Mehta 1c99f0c9da Configure phan-taint-check-plugin
The plugin checks and flags potential security issues (XSS, SQLi, etc.)
using static analysis.

See <https://www.mediawiki.org/wiki/Phan-taint-check-plugin> for more
details.

Bug: T201219
Change-Id: Icd37e87054d1544386e70452f10434053d55273b
2018-08-03 20:08:33 -07:00
libraryupgrader 0e9b69dde0 build: Updating mediawiki/mediawiki-codesniffer to 21.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation

Change-Id: Ie916e2e5a4cc7578531dd7318143c7c3066103dd
2018-07-27 03:50:30 +00:00
Derk-Jan Hartman d5124e2920 Make use of new WikiEditor 2010 toggle tool
Bug: T198781
Depends-On: I8b7fd41571a48fa4f6560790d94bb966972e740f
Change-Id: Id275142c0d50ca6a133129eebeee8cfc5c1ca99a
2018-07-25 01:12:28 +02:00
Max Semenik c8f75d5ac5 Restore GetPreferences hook handler registration
Accidentally removed in I1ad451acfd1

Bug: T198537
Change-Id: I71788de31a23373f4e0528211ce3ec89fc5f9d3b
2018-07-03 14:25:01 -07:00
Translation updater bot c8ae93806c Localisation updates from https://translatewiki.net.
Change-Id: I5f06c5a0802a896160f24821e680ae93268e63b7
2018-06-27 22:18:28 +02:00
Derk-Jan Hartman 4ebe54a588 Focus before setting the cursor/selection
Bug: T197263
Change-Id: If5efed656746e3e40fcda118e487cdcb00e0114a
2018-06-26 21:55:09 +00:00
Translation updater bot f22a530f7c Localisation updates from https://translatewiki.net.
Change-Id: Id1215f8091e4567eb7dc0b57f72882c80b9863f9
2018-06-24 22:25:30 +02:00
Translation updater bot 8f1b81993d Localisation updates from https://translatewiki.net.
Change-Id: Iff7bfd4b99c48d7c52fc95649d266ddaf699ed97
2018-06-20 23:11:34 +02:00
Translation updater bot 3d40b7fe1c Localisation updates from https://translatewiki.net.
Change-Id: I6e174341786f3113333d70c4d5c4cc312ffff8b7
2018-06-18 22:09:39 +02:00
jenkins-bot 7fa197b2dc Merge "Accessibility: mark syntaxhighlight button as a switch" 2018-06-18 16:04:35 +00:00
Derk-Jan Hartman 42e3dc7cdb Accessibility: mark syntaxhighlight button as a switch
* Protect from setActive not being defined on the old toolbar button
* Use role is switch on the button, since WE only supports simple
buttons
* Add the checked attribute to reflect state of the toggle button

Bug: T196512
Bug: T197534
Change-Id: I48dfef1740f124105f65859ce4f51098f1157fd0
2018-06-18 15:53:37 +00:00
jenkins-bot 579611ff5e Merge "Accessibility: Disable both directions of tabbing in CodeMirror" 2018-06-18 03:41:25 +00:00
Derk-Jan Hartman 736c63fd0b Accessibility: Disable both directions of tabbing in CodeMirror
Bug: T197534
Change-Id: Ia05c3ccbdb4baa8e701bf46478c42d2473777535
2018-06-17 19:24:14 +02:00
Max Semenik 63647bb5dc Remove all BetaFeatures support
Bug: T185030
Change-Id: I1ad451acfd163c783e7b8ec604d8695c14342667
2018-06-13 16:42:40 -07:00
Translation updater bot 564e4ea538 Localisation updates from https://translatewiki.net.
Change-Id: I6f8266d815be88edca0465818af77491f8af5640
2018-06-09 10:26:57 +02:00
Translation updater bot 8467d5fa84 Localisation updates from https://translatewiki.net.
Change-Id: I5fca2d252384f198c3b9332164fd7f9836b1c1a1
2018-06-02 22:41:17 +02:00
Translation updater bot 6d5068cbff Localisation updates from https://translatewiki.net.
Change-Id: I3b96bf5871fcc654b2228a1ff3ca81b0fc96c387
2018-05-31 22:28:22 +02:00
jenkins-bot 7c9dac685e Merge "Disable ULS when CodeMirror is on" 2018-05-31 14:34:46 +00:00