Commit graph

514 commits

Author SHA1 Message Date
Bartosz Dziewoński 079d240a2c ve.ui.CodeMirror: Fix padding to match VisualEditor's padding
VisualEditor's default padding for the source editing surface was
changed in Icdc6f1e2a7544ebbd828f85ff370113a0e06983a (June 2018).

Since then the alignment of editing surface and CodeMirror syntax
highlighting surface was broken in skins that don't override the
default padding (basically every skin except Vector and MonoBook).
Unfortunately Vector and MonoBook happen to be the only skins we
officially support and actually test, so the issue went unnoticed.

Bug: T205154
Bug: T205658
Change-Id: Ic85a6c20b266f6b93ab8ec9c2d35acff679f31bc
2018-09-27 22:06:00 +02:00
Ed Sanders ef8c62c74b Use renamed ve.visibleWhitespaceCharacters
Change-Id: I246079505d4c37406b3f99ca17b7e8e926adaec5
2018-09-24 16:34:54 +01:00
jenkins-bot 7dd9688663 Merge "build: Update linters" 2018-09-13 12:27:47 +00:00
Ed Sanders 1be09a9a1d build: Update linters
Change-Id: I8d3aaf0b7d453033b72e5d6622b8f54df2c86bca
2018-09-12 00:03:19 +01:00
Umherirrender 7cd71f47a7 Remove @staticvar doc annotation
It is unknown to doxygen

Change-Id: I60e98eb3a7e74796e877fd70e8b9b67b5e3b60df
2018-09-09 20:04:35 +02:00
libraryupgrader 9cdee0421a build: Updating mediawiki/phan-taint-check-plugin to 1.5.0
Change-Id: I5a0c270625959fa43841f703df10ca9a08a32a7c
2018-09-07 08:12:20 +00:00
libraryupgrader 10af14ec3c build: Updating mediawiki/mediawiki-codesniffer to 22.0.0
Change-Id: Ifdf12fd08cd94ba64a56433ea6bac4f86ae7c8ac
2018-09-02 23:49:04 +00:00
libraryupgrader 2c9734d45f build: Updating mediawiki/phan-taint-check-plugin to 1.4.0
Change-Id: I88133dca11d56d556dbcdf6f4eddfa9afa2af80c
2018-09-01 06:51:09 +00:00
jenkins-bot ee1769ae00 Merge "Make use of new WikiEditor 2010 toggle tool" 2018-08-21 19:15:45 +00:00
libraryupgrader 18b1f64a60 build: Updating mediawiki/phan-taint-check-plugin to 1.3.0
And updating CoC link to use Special:MyLanguage (T202047).

Change-Id: I7a7769b623a7717d100fe6665ff90292ecf1fc73
2018-08-19 10:46:12 +00:00
Kunal Mehta 35edfa6018 Use new Parser accessors
And there's no need to manually call firstCallInit() anymore, the
Parser will call it in all the necessary places automatically.

Depends-On: Ida62767f3ca53f99609cae01d3a20051bb92ccab
Depends-On: Ia2d98baf6caed2cd779cb00aceba5785cf13d633
Change-Id: I7e2097fa733506985a4b252fc9b01b03f6c28885
2018-08-13 22:56:03 -07:00
Kunal Mehta 0ba594b8ad Don't use deprecated MagicWord methods
Change-Id: I992b966f25cea52002cb8ee91f94dd92ff8c717f
2018-08-12 21:44:24 -07:00
Fomafix 9bda90be76 Get Parser from service instead of global $wgParser
Also always call firstCallInit() which already calls
initialiseVariables().

Change-Id: I55808175c18430a0021e115b27c672635a62669b
2018-08-12 10:34:00 +02:00
Fomafix ca7f33f8ef Use ContentLanguage service instead of global $wgContLang
Depends-On: I193f5b9a95430b0a05573c361715e053e5411e32
Change-Id: I2b6b2392c5be923657cd508459662ba643b21362
2018-08-05 00:33:03 +02:00
Kunal Mehta 1c99f0c9da Configure phan-taint-check-plugin
The plugin checks and flags potential security issues (XSS, SQLi, etc.)
using static analysis.

See <https://www.mediawiki.org/wiki/Phan-taint-check-plugin> for more
details.

Bug: T201219
Change-Id: Icd37e87054d1544386e70452f10434053d55273b
2018-08-03 20:08:33 -07:00
libraryupgrader 0e9b69dde0 build: Updating mediawiki/mediawiki-codesniffer to 21.0.0
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation

Change-Id: Ie916e2e5a4cc7578531dd7318143c7c3066103dd
2018-07-27 03:50:30 +00:00
Derk-Jan Hartman d5124e2920 Make use of new WikiEditor 2010 toggle tool
Bug: T198781
Depends-On: I8b7fd41571a48fa4f6560790d94bb966972e740f
Change-Id: Id275142c0d50ca6a133129eebeee8cfc5c1ca99a
2018-07-25 01:12:28 +02:00
Max Semenik c8f75d5ac5 Restore GetPreferences hook handler registration
Accidentally removed in I1ad451acfd1

Bug: T198537
Change-Id: I71788de31a23373f4e0528211ce3ec89fc5f9d3b
2018-07-03 14:25:01 -07:00
Translation updater bot c8ae93806c Localisation updates from https://translatewiki.net.
Change-Id: I5f06c5a0802a896160f24821e680ae93268e63b7
2018-06-27 22:18:28 +02:00
Derk-Jan Hartman 4ebe54a588 Focus before setting the cursor/selection
Bug: T197263
Change-Id: If5efed656746e3e40fcda118e487cdcb00e0114a
2018-06-26 21:55:09 +00:00
Translation updater bot f22a530f7c Localisation updates from https://translatewiki.net.
Change-Id: Id1215f8091e4567eb7dc0b57f72882c80b9863f9
2018-06-24 22:25:30 +02:00
Translation updater bot 8f1b81993d Localisation updates from https://translatewiki.net.
Change-Id: Iff7bfd4b99c48d7c52fc95649d266ddaf699ed97
2018-06-20 23:11:34 +02:00
Translation updater bot 3d40b7fe1c Localisation updates from https://translatewiki.net.
Change-Id: I6e174341786f3113333d70c4d5c4cc312ffff8b7
2018-06-18 22:09:39 +02:00
jenkins-bot 7fa197b2dc Merge "Accessibility: mark syntaxhighlight button as a switch" 2018-06-18 16:04:35 +00:00
Derk-Jan Hartman 42e3dc7cdb Accessibility: mark syntaxhighlight button as a switch
* Protect from setActive not being defined on the old toolbar button
* Use role is switch on the button, since WE only supports simple
buttons
* Add the checked attribute to reflect state of the toggle button

Bug: T196512
Bug: T197534
Change-Id: I48dfef1740f124105f65859ce4f51098f1157fd0
2018-06-18 15:53:37 +00:00
jenkins-bot 579611ff5e Merge "Accessibility: Disable both directions of tabbing in CodeMirror" 2018-06-18 03:41:25 +00:00
Derk-Jan Hartman 736c63fd0b Accessibility: Disable both directions of tabbing in CodeMirror
Bug: T197534
Change-Id: Ia05c3ccbdb4baa8e701bf46478c42d2473777535
2018-06-17 19:24:14 +02:00
Max Semenik 63647bb5dc Remove all BetaFeatures support
Bug: T185030
Change-Id: I1ad451acfd163c783e7b8ec604d8695c14342667
2018-06-13 16:42:40 -07:00
Translation updater bot 564e4ea538 Localisation updates from https://translatewiki.net.
Change-Id: I6f8266d815be88edca0465818af77491f8af5640
2018-06-09 10:26:57 +02:00
Translation updater bot 8467d5fa84 Localisation updates from https://translatewiki.net.
Change-Id: I5fca2d252384f198c3b9332164fd7f9836b1c1a1
2018-06-02 22:41:17 +02:00
Translation updater bot 6d5068cbff Localisation updates from https://translatewiki.net.
Change-Id: I3b96bf5871fcc654b2228a1ff3ca81b0fc96c387
2018-05-31 22:28:22 +02:00
jenkins-bot 7c9dac685e Merge "Disable ULS when CodeMirror is on" 2018-05-31 14:34:46 +00:00
Max Semenik f973652942 Disable ULS when CodeMirror is on
Bug: T194102
Change-Id: I25894d98a28e2c6096796ab912cc0ee04dd0a6e3
2018-05-30 13:07:07 -07:00
libraryupgrader 5795550382 build: Updating mediawiki/mediawiki-codesniffer to 20.0.0
Change-Id: Id289b2916b7fd07c4a32f4906788c2a56713c39c
2018-05-26 01:31:55 +00:00
Fomafix 31c24340f7 Remove dependencies on deprecated modules 'mediawiki.api.*'
In core the modules 'mediawiki.api.*' get merged into 'mediawiki.api'
and get deprecated in ecc812f06e included in MediaWiki 1.32.

Change-Id: I07471baa50edbd4d5a7ff904b46602729612ccde
2018-05-21 14:37:21 +02:00
Translation updater bot 083b4adbcd Localisation updates from https://translatewiki.net.
Change-Id: Idddd668266a65622c45cbb3fab72b95813142df8
2018-05-16 23:07:40 +02:00
Ed Sanders 341a67496a Simplify target lookup
Change-Id: I00449f043c391c7648e2c17651d15c2807044402
2018-05-12 13:10:05 +01:00
James D. Forrester 780fe9cb9f Beta Feature: Flag as requiring JavaScript
Bug: T194528
Change-Id: Ic37fec8a167fe0c7a12ff52634824dd2585a9e80
2018-05-11 19:51:14 +00:00
Ed Sanders fca1d62a6c Apply line height selector to CodeMirror line wrapper
Bug: T193219
Change-Id: I7973b5e1a4f602c0fc371d78a1ebead093c48e74
2018-04-27 21:42:45 +01:00
Kunal Mehta c6d9adbe83 Set extension type to editor
This extension doesn't even register a parser hook.

Change-Id: Ia31cae5504f404e130bfd77322ec53c79e085f22
2018-04-26 00:33:09 -07:00
jenkins-bot d3c7f3cdd4 Merge "Use CM API for setting document direction" 2018-04-25 18:36:32 +00:00
jenkins-bot 466fca0ec0 Merge "Load CodeMirror with VE always" 2018-04-25 16:04:39 +00:00
Niharika Kohli 7c848abd8d Load CodeMirror with VE always
This patch makes Codemirror on VE independent of the beta feature,
making it always load.

This is a first step to graduating CodeMirror out of beta.

Bug: T191923
Change-Id: Ide794e8f986d3f0455ff282819c71d9144dd75db
2018-04-23 20:54:43 +00:00
Translation updater bot 78d5fd1623 Localisation updates from https://translatewiki.net.
Change-Id: I85ba6a45328d9e269811aacefdc0c65e01ce7f69
2018-04-22 22:21:37 +02:00
jenkins-bot f7162e26f9 Merge "Never load ext.CodeMirror on RTL pages" 2018-04-19 20:35:59 +00:00
Translation updater bot 890d5fd516 Localisation updates from https://translatewiki.net.
Change-Id: I73ec7eb586ffc25d6ae04f15e15b5ffb685d0e33
2018-04-19 22:13:39 +02:00
Ed Sanders d4d92f921f Never load ext.CodeMirror on RTL pages
This does not affect the VE integration, which
does support RTL.

Bug: T191923
Change-Id: I817498157bcc3ff0b92d1ee0e9cf9fc96be83d2f
2018-04-19 16:01:57 +00:00
jenkins-bot 6e2bdac5d2 Merge "Remove 'Try syntax highlighting' popup for all users" 2018-04-18 21:02:25 +00:00
Translation updater bot 09dca5a16e Localisation updates from https://translatewiki.net.
Change-Id: I48135b55cace69b51e66b2ada0feac3acf65441b
2018-04-18 22:10:35 +02:00
Ed Sanders dcf28f37a1 Use CM API for setting document direction
Bug: T191923
Change-Id: I68ee7de8ff2d26044fc8a71a04ade65b5d4420c8
2018-04-16 16:53:29 +01:00