wikimedia/mediawiki-extensions-CodeMirror
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/CodeMirror synced 2024-11-23 22:03:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

CodeMirrorModeMediaWikiConfig: add missing TagStyle for cm-mw-link

Browse source 
The number sign in `[[Link#Section]]` is supposed to have the class
.cm-mw-link, but didn't because it was missing a TagStyle which actually
gives it the CSS class. Now it does.

Add test case for all known CSS classes.

Bug: T348019
Follow-Up: I8f8a81f362bed60dea14ecde9487a2b0c89225e8
Change-Id: I613f8bead76523fbe1a9f05ed75d81893b8737d3
This commit is contained in:
MusikAnimal 2024-03-27 00:32:05 -04:00
parent b97d51ff51
commit fcb7633eb1
3 changed files with 121 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
resources/dist/codemirror.mode.mediawiki.js vendored
View file

File diff suppressed because one or more lines are too long

4
src/codemirror.mode.mediawiki.config.js
View file

@ -466,6 +466,10 @@ class CodeMirrorModeMediaWikiConfig {
tag: context.tokenTable[ this.tags.htmlEntity ], tag: context.tokenTable[ this.tags.htmlEntity ],
class: 'cm-mw-html-entity' class: 'cm-mw-html-entity'
}, },
{
tag: context.tokenTable[ this.tags.link ],
class: 'cm-mw-link'
},
{ {
tag: context.tokenTable[ this.tags.linkPageName ], tag: context.tokenTable[ this.tags.linkPageName ],
class: 'cm-mw-link-pagename' class: 'cm-mw-link-pagename'

116
tests/jest/codemirror.mode.mediawiki.test.js
View file

@ -1,3 +1,5 @@
import { StreamParser } from '@codemirror/language';
import { Tag } from '@lezer/highlight';
import CodeMirror from '../../src/codemirror.js'; import CodeMirror from '../../src/codemirror.js';
import mediaWikiLang from '../../src/codemirror.mode.mediawiki.js'; import mediaWikiLang from '../../src/codemirror.mode.mediawiki.js';
import { mwModeConfig } from '../../src/codemirror.mode.mediawiki.config.js'; import { mwModeConfig } from '../../src/codemirror.mode.mediawiki.config.js';
@ -274,4 +276,118 @@ describe( 'CodeMirrorModeMediaWiki', () => {
'templateVariableDelimiter' 'templateVariableDelimiter'
] ); ] );
} ); } );
it( 'configuration has a TagStyle for all expected CSS classes', () => {
/** @type {StreamParser} */
const mockContext = {
tokenTable: jest.fn().mockReturnValue( Tag.define() )
};
const cssClasses = mwModeConfig.getTagStyles( mockContext )
.map( ( tagStyle ) => tagStyle.class );
expect( cssClasses ).toStrictEqual( [
'cm-mw-apostrophes',
'cm-mw-apostrophes-bold',
'cm-mw-apostrophes-italic',
'cm-mw-comment',
'cm-mw-double-underscore',
'cm-mw-extlink',
'cm-mw-extlink-bracket',
'cm-mw-extlink-protocol',
'cm-mw-extlink-text',
'cm-mw-hr',
'cm-mw-htmltag-attribute',
'cm-mw-htmltag-bracket',
'cm-mw-htmltag-name',
'cm-mw-indenting',
'cm-mw-link-bracket',
'cm-mw-link-delimiter',
'cm-mw-link-text',
'cm-mw-link-tosection',
'cm-mw-list',
'cm-mw-parserfunction',
'cm-mw-parserfunction-bracket',
'cm-mw-parserfunction-delimiter',
'cm-mw-parserfunction-name',
'cm-mw-section-header',
'cm-mw-section-1',
'cm-mw-section-2',
'cm-mw-section-3',
'cm-mw-section-4',
'cm-mw-section-5',
'cm-mw-section-6',
'cm-mw-signature',
'cm-mw-table-bracket',
'cm-mw-table-definition',
'cm-mw-table-delimiter',
'cm-mw-template',
'cm-mw-template-argument-name',
'cm-mw-template-bracket',
'cm-mw-template-delimiter',
'cm-mw-pagename cm-mw-template-name',
'cm-mw-templatevariable',
'cm-mw-templatevariable-bracket',
'cm-mw-templatevariable-name',
// Custom tags
'cm-mw-em',
'cm-mw-error',
'cm-mw-ext-nowiki',
'cm-mw-ext-pre',
'cm-mw-exttag-bracket',
'cm-mw-exttag',
'cm-mw-exttag-attribute',
'cm-mw-exttag-name',
'cm-mw-free-extlink',
'cm-mw-free-extlink-protocol',
'cm-mw-html-entity',
'cm-mw-link',
'cm-mw-link-pagename',
'cm-mw-tag-nowiki',
'cm-mw-pagename',
'cm-mw-tag-pre',
'cm-mw-section',
'cm-mw-skipformatting',
'cm-mw-strong',
'cm-mw-table-caption',
'cm-mw-templatevariable-delimiter',
// Dynamically generated tags
'cm-mw-ext-ground',
'cm-mw-ext-link-ground',
'cm-mw-ext2-ground',
'cm-mw-ext2-link-ground',
'cm-mw-ext3-ground',
'cm-mw-ext3-link-ground',
'cm-mw-link-ground',
'cm-mw-template-ext-ground',
'cm-mw-template-ext-link-ground',
'cm-mw-template-ext2-ground',
'cm-mw-template-ext2-link-ground',
'cm-mw-template-ext3-ground',
'cm-mw-template-ext3-link-ground',
'cm-mw-template-ground',
'cm-mw-template-link-ground',
'cm-mw-template2-ext-ground',
'cm-mw-template2-ext-link-ground',
'cm-mw-template2-ext2-ground',
'cm-mw-template2-ext2-link-ground',
'cm-mw-template2-ext3-ground',
'cm-mw-template2-ext3-link-ground',
'cm-mw-template2-ground',
'cm-mw-template2-link-ground',
'cm-mw-template3-ext-ground',
'cm-mw-template3-ext-link-ground',
'cm-mw-template3-ext2-ground',
'cm-mw-template3-ext2-link-ground',
'cm-mw-template3-ext3-ground',
'cm-mw-template3-ext3-link-ground',
'cm-mw-template3-ground',
'cm-mw-template3-link-ground',
/** Added by the MW config stub above {@link mwLang} */
'cm-mw-tag-ref',
'cm-mw-ext-ref',
'cm-mw-tag-references',
'cm-mw-ext-references',
'cm-mw-tag-myextension',
'cm-mw-ext-myextension'
] );
} );
} ); } );