wikimedia/mediawiki-extensions-CodeMirror
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/CodeMirror synced 2024-11-23 22:03:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

CodeMirror: default to using the same height as the textarea

Browse source 
CodeMirrorWikiEditor: add a 'ext.CodeMirror.initialize' hook to allow
integrations to manipulate the DOM before CodeMirror is initialized.

This is necessary for ProofreadPage, for example (I5c0824bf38cf7).

Bug: T357794
Change-Id: I4deeda192bdc233101ba61739a636f8fd143c1de
This commit is contained in:
MusikAnimal 2024-02-22 16:18:41 -05:00
parent 5bfb8dddad
commit c9c9ed27d3
3 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
resources/dist/main.js vendored
View file

File diff suppressed because one or more lines are too long

2
resources/dist/main.js.map.json vendored
View file

File diff suppressed because one or more lines are too long

10
src/codemirror.js
View file

@ -30,7 +30,13 @@ export default class CodeMirror {
const extensions = [ const extensions = [
this.contentAttributesExtension, this.contentAttributesExtension,
this.phrasesExtension, this.phrasesExtension,
this.specialCharsExtension this.specialCharsExtension,
EditorView.theme( {
// Use the same height as the textarea
'.cm-content': {
height: this.$textarea.outerHeight() + 'px'
}
} )
]; ];
const namespaces = mw.config.get( 'wgCodeMirrorLineNumberingNamespaces' ); const namespaces = mw.config.get( 'wgCodeMirrorLineNumberingNamespaces' );
@ -167,6 +173,8 @@ export default class CodeMirror {
* @stable * @stable
*/ */
initialize( extensions = this.defaultExtensions ) { initialize( extensions = this.defaultExtensions ) {
mw.hook( 'ext.CodeMirror.initialize' ).fire( this.$textarea );
// Set up the initial EditorState of CodeMirror with contents of the native textarea. // Set up the initial EditorState of CodeMirror with contents of the native textarea.
this.state = EditorState.create( { this.state = EditorState.create( {
doc: this.$textarea.textSelection( 'getContents' ), doc: this.$textarea.textSelection( 'getContents' ),