wikimedia/mediawiki-extensions-CodeMirror
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/CodeMirror synced 2024-11-23 22:03:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove $this->setService( 'UserOptionsLookup', ... ) in tests

Browse source 
The mocked service UserOptionsLookup is already injected via contructor
to Hooks.

Change-Id: I013aa6f62bd50802889a0037721ba06902d1a18e
This commit is contained in:
Fomafix 2024-03-04 20:04:02 +00:00
parent 6b3c480f02
commit c3df98cff6
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tests/phpunit/HookTest.php
View file

@ -39,7 +39,6 @@ class HookTest extends MediaWikiIntegrationTestCase {
] ); ] );
$userOptionsLookup = $this->createMock( UserOptionsLookup::class ); $userOptionsLookup = $this->createMock( UserOptionsLookup::class );
$userOptionsLookup->method( 'getOption' )->willReturn( true ); $userOptionsLookup->method( 'getOption' )->willReturn( true );
$this->setService( 'UserOptionsLookup', $userOptionsLookup );
$out = $this->getMockOutputPage(); $out = $this->getMockOutputPage();
$out->method( 'getModules' )->willReturn( [] ); $out->method( 'getModules' )->willReturn( [] );
@ -87,7 +86,6 @@ class HookTest extends MediaWikiIntegrationTestCase {
$out->method( 'getModules' )->willReturn( $module ? [ $module ] : [] ); $out->method( 'getModules' )->willReturn( $module ? [ $module ] : [] );
$userOptionsLookup = $this->createMock( UserOptionsLookup::class ); $userOptionsLookup = $this->createMock( UserOptionsLookup::class );
$userOptionsLookup->method( 'getOption' )->willReturn( true ); $userOptionsLookup->method( 'getOption' )->willReturn( true );
$this->setService( 'UserOptionsLookup', $userOptionsLookup );
if ( $gadget && !ExtensionRegistry::getInstance()->isLoaded( 'Gadgets' ) ) { if ( $gadget && !ExtensionRegistry::getInstance()->isLoaded( 'Gadgets' ) ) {
$this->markTestSkipped( 'Skipped as Gadgets extension is not available' ); $this->markTestSkipped( 'Skipped as Gadgets extension is not available' );