wikimedia/mediawiki-extensions-CodeMirror
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/CodeMirror synced 2024-09-24 02:38:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add tool to VE toolbar automatically using 'utility' group

Browse source 
This removes the need for the init module.

Bug: T340751
Depends-On: Ibcc81c90bc9ba6c5fd012c512daf861973b03b2e
Change-Id: Iec3a4c6b00288aee376af47e778c4aa67a98d29b
This commit is contained in:
Ed Sanders 2023-06-21 17:09:44 +01:00 committed by Bartosz Dziewoński
parent 5b69b2380c
commit 9520546e09
4 changed files with 8 additions and 29 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
extension.json
View file

@ -126,26 +126,22 @@
"ext.CodeMirror.lib"
]
},
"ext.CodeMirror.visualEditor.init": {
"scripts": [
"modules/ve-cm/ve.ui.CodeMirror.init.js"
],
"styles": [
"modules/ve-cm/ve.ui.CodeMirror.init.less"
],
"messages": [
"codemirror-toggle-label"
]
},
"ext.CodeMirror.visualEditor": {
"dependencies": [
"ext.visualEditor.mwcore",
"ext.visualEditor.mwmeta",
"mediawiki.api",
"user.options"
],
"scripts": [
"modules/ve-cm/ve.ui.CodeMirrorAction.js",
"modules/ve-cm/ve.ui.CodeMirrorTool.js"
],
"styles": [
"modules/ve-cm/ve.ui.CodeMirror.less"
],
"messages": [
"codemirror-toggle-label"
]
}
},
@ -193,7 +189,6 @@
},
"VisualEditor": {
"PluginModules": [
"ext.CodeMirror.visualEditor.init",
"ext.CodeMirror.visualEditor"
]
},

16
resources/modules/ve-cm/ve.ui.CodeMirror.init.js
View file

@ -1,16 +0,0 @@
mw.loader.using( 'ext.visualEditor.targetLoader' ).then( function () {
mw.libs.ve.targetLoader.addPlugin( function () {
var target = ve.init.mw.DesktopArticleTarget;
if ( target ) {
var groups = target.static.toolbarGroups.concat( target.static.actionGroups );
groups.some( function ( group ) {
if ( group.name === 'pageMenu' ) {
var index = group.include.indexOf( 'changeDirectionality' );
group.include.splice( index, 0, 'codeMirror' );
return true;
}
return false;
} );
}
} );
} );

0
resources/modules/ve-cm/ve.ui.CodeMirror.init.less → resources/modules/ve-cm/ve.ui.CodeMirror.less
View file

2
resources/modules/ve-cm/ve.ui.CodeMirrorTool.js
View file

@ -26,7 +26,7 @@ ve.ui.CodeMirrorTool.static.name = 'codeMirror';
ve.ui.CodeMirrorTool.static.autoAddToCatchall = false;
ve.ui.CodeMirrorTool.static.title = OO.ui.deferMsg( 'codemirror-toggle-label' );
ve.ui.CodeMirrorTool.static.icon = 'highlight';
ve.ui.CodeMirrorTool.static.group = 'codeMirror';
ve.ui.CodeMirrorTool.static.group = 'utility';
ve.ui.CodeMirrorTool.static.commandName = 'codeMirror';
ve.ui.CodeMirrorTool.static.deactivateOnSelect = false;