wikimedia/mediawiki-extensions-CodeMirror
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/CodeMirror synced 2024-11-24 06:13:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ensure CM surface can't be edited in VE mode

Browse source 
CM surface is just for presentation, it shouldn't
be possible to focus or select anything in the surface,
so in addition to it being beneath the VE surface,
disable it through the CM API and disable pointer-events
with CSS.

Bug: T170170
Change-Id: Ief49c293f514e22bc6db5eebb3a11c1bc695432d
This commit is contained in:
Ed Sanders 2017-07-10 17:40:51 +01:00 committed by Bartosz Dziewoński
parent c6ccd44f95
commit 91397eb556
2 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
resources/modules/ve-cm/ve.ui.CodeMirror.init.less
View file

@ -11,6 +11,7 @@
-webkit-box-sizing: border-box; -webkit-box-sizing: border-box;
-moz-box-sizing: border-box; -moz-box-sizing: border-box;
box-sizing: border-box; box-sizing: border-box;
pointer-events: none;
padding: 0 1.14286em; /* 1/0.875 */ padding: 0 1.14286em; /* 1/0.875 */
@media screen and ( min-width: 982px ) { @media screen and ( min-width: 982px ) {

1
resources/modules/ve-cm/ve.ui.CodeMirrorAction.js
View file

@ -46,6 +46,7 @@ ve.ui.CodeMirrorAction.prototype.toggle = function ( enable ) {
surface.mirror = CodeMirror( surfaceView.$element[ 0 ], { surface.mirror = CodeMirror( surfaceView.$element[ 0 ], {
value: surface.getDom(), value: surface.getDom(),
mwConfig: mw.config.get( 'extCodeMirrorConfig' ), mwConfig: mw.config.get( 'extCodeMirrorConfig' ),
readOnly: 'nocursor',
lineWrapping: true, lineWrapping: true,
tabSize: 1, tabSize: 1,
scrollbarStyle: 'null', scrollbarStyle: 'null',