wikimedia/mediawiki-extensions-CodeMirror
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/CodeMirror synced 2024-12-12 14:25:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

mediaWikiLang: remove used hook handlers

Browse source 
Every time when `mediaWikiLang()` is called, a new handler is registered for the hook `ext.CodeMirror.ready`. This causes unexpected errors, so the used handler needs to be removed before registering a new handler.

Bug: T380840
Change-Id: I81bed58ec37a508e53a93895c7e20de358a658e0
This commit is contained in:
bhsd 2024-11-29 21:42:37 +08:00
parent 4647e415d5
commit 60f450a773
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
resources/codemirror.mediawiki.js
View file

@ -1374,6 +1374,8 @@ class CodeMirrorModeMediaWiki {
} }
} }
let handler;
/** /**
* Gets a LanguageSupport instance for the MediaWiki mode. * Gets a LanguageSupport instance for the MediaWiki mode.
* *
@ -1401,7 +1403,10 @@ const mediaWikiLang = ( config = { bidiIsolation: false }, mwConfig = null ) =>
// Register MW-specific Extensions into CodeMirror preferences. Whether they are enabled // Register MW-specific Extensions into CodeMirror preferences. Whether they are enabled
// or not is determined by the user's preferences and wiki configuration. // or not is determined by the user's preferences and wiki configuration.
mw.hook( 'ext.CodeMirror.ready' ).add( ( $textarea, cm ) => { if ( handler ) {
mw.hook( 'ext.CodeMirror.ready' ).remove( handler );
}
handler = ( $textarea, cm ) => {
if ( config.templateFolding !== false ) { if ( config.templateFolding !== false ) {
cm.preferences.registerExtension( 'templateFolding', templateFoldingExtension, cm.view ); cm.preferences.registerExtension( 'templateFolding', templateFoldingExtension, cm.view );
} }
@ -1411,7 +1416,8 @@ const mediaWikiLang = ( config = { bidiIsolation: false }, mwConfig = null ) =>
if ( config.bidiIsolation ) { if ( config.bidiIsolation ) {
cm.preferences.registerExtension( 'bidiIsolation', bidiIsolationExtension, cm.view ); cm.preferences.registerExtension( 'bidiIsolation', bidiIsolationExtension, cm.view );
} }
} ); };
mw.hook( 'ext.CodeMirror.ready' ).add( handler );
return new LanguageSupport( lang, langExtension ); return new LanguageSupport( lang, langExtension );
}; };