wikimedia/mediawiki-extensions-CodeMirror
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/CodeMirror synced 2024-11-23 13:56:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

ve.ui.CodeMirrorAction.v6: Use direction of surface view, not model view

Browse source 
This fixes an issue where the VE document model is incorrectly used in
computing gutter width based on directionality. It should instead be the
VE surface view's direction, in the event the user the is editing in RTL
on a LTR document. See T374196#10311711.

Bug: T374196
Follow-Up: I81e863e19d6d0bad2cc2be743df896e17a8dc548
Change-Id: Ic37d1004e9606dc2d29d98d29f28743202dd5683
This commit is contained in:
MusikAnimal 2024-11-18 23:09:12 -05:00
parent 5d6d0ba56a
commit 2710eade97
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
resources/ve-cm/ve.ui.CodeMirrorAction.v6.js
View file

@ -101,7 +101,7 @@ ve.ui.CodeMirrorAction.prototype.toggle = function ( enable ) {
} ); } );
// Account for the gutter width in the margin. // Account for the gutter width in the margin.
action.updateGutterWidth( doc.getDir() ); action.updateGutterWidth( surfaceView.getDocument().getDir() );
// Set focus on the surface view. // Set focus on the surface view.
surfaceView.focus(); surfaceView.focus();