Commit graph

145 commits

Author SHA1 Message Date
Derk-Jan Hartman 177142940d Configure JS linter to handle more lines
The linter would bail after 100 detected issues (alerting or not) and
would report the warning 'too many errors (xx% scanned)'

Set a higher limit. 1000 seems enough for navigation popups gadget.

Bug: T1092
Change-Id: I263e08a39712279a06b12cd75ebedcccaf191b58
2022-05-30 21:12:19 +00:00
Ed Sanders 2479c7f1bb eslint: Lint Gruntile.js using server rules
Change-Id: I9e452fc08ae483431ad83dca3c7ebd7f04f5d945
2022-02-07 16:22:02 +00:00
Ed Sanders 17e04cab5e Move var declarations inline
Change-Id: Iccad0c3bf194f8fa418181283ac3b2a037fabe5f
2021-10-06 18:00:20 +01:00
Nardog 86e79cdaf3 Improve accuracy of the search/replace toggle
Now toggleSearchReplace() actually looks at the visibility of the search
box, instead of keeping a boolean, to decide whether to show or hide the
box, in case it was opened by Ctrl-F or closed by Esc or clicking X. So
the button itself is no longer a toggle, but a simple action button. In
addition, it now uses Ace's native replace command instead of
reinventing the wheel. Ace no longer hijacks Ctrl-R and with this Ctrl-H
now works.

Bug: T102486
Change-Id: I6bead1b3209e08a46e31ed3f30c61ca52152b688
2021-03-25 20:11:52 +00:00
Umherirrender b2aeedd34a Move images folder into modules folder
All resources needed by client should in one folder

Change-Id: Ib9f6ea7bb59f2b5b8115c381290032170d482a98
2021-03-12 20:09:55 +01:00
Ed Sanders ccb909be60 De-emphasise line numbers
Bug: T271956
Change-Id: I336e7a319a7a4eb5f6fc9f07b149d584a15c73c4
2021-01-13 17:07:02 +00:00
Ed Sanders 56d6d1598a Update Ace 1.4.9 -> 1.4.12
2020.07.06 Version 1.4.12
* removed unused es5-shim
* imporved ruby and vbscript highlighting and folding
* workaround for double space being converted to dot on mobile keyboards

2020.04.15 Version 1.4.10
* added workaround for chrome bug causing memory leak after calling editor.destroy
* added code folding support for vbscript mode

Change-Id: I7b2531b1d5571eac15549d58a8295bcf167acd43
2020-08-12 13:22:05 +01:00
Ed Sanders d4cc23f606 Update ace-build 1.2.9 -> 1.4.9 and recompile
Change-Id: I31eeb56eec4995e1bff8248e5c1d4df7f20ad48b
2020-04-14 14:30:34 -07:00
Timo Tijhof c0c70a2312 Remove use of jquery.ui module aliases
Bug: T219604
Change-Id: Ia639ca6728ac23c14fa5b1a21317ddd3220c3727
2019-11-26 20:06:59 +00:00
Ed Sanders c4bc2c7d36 build: Update linters
Change-Id: I0c7b153461300840deb75c695f893b3b4a778dcf
2019-11-15 16:40:39 +00:00
Ammar 3eb4ef07de Fix typo in comments
"Seperately" → Separately

Bug: T201491
Change-Id: Ib7ce92f36db5abe447e38cda513acb580fab9007
2019-10-07 04:59:58 +01:00
Ed Sanders 5cac43ddd3 build: Update eslint-config-wikimedia to 0.11.0
Change-Id: I99fd10fbcce5d5e6b87b6e3faeb7b18c4e573ef7
2019-03-13 22:38:54 +00:00
Ed Sanders 4ad54da406 build: Update linters
Change-Id: I9baecb9fd4b9d9bf86897ccec8289614b136c3a2
2018-12-10 13:31:37 +00:00
Ed Sanders 8c6473826a Remove obsolete aliases from closures
Bug: T208951
Change-Id: Ib3502d54c39e65c2aed38f7e630a8b8286d522c2
2018-11-12 13:16:11 +00:00
Derk-Jan Hartman e8fbe62ef0 Make use of new WikiEditor 2010 toggle tool
Set a specific WikiEditor version dependency of 0.5.2.

Bug: T198781
Change-Id: I6664a7ff2383d83c7d0fa1fd45e2539fad40c1d0
Depends-On: I8b7fd41571a48fa4f6560790d94bb966972e740f
2018-08-17 11:22:36 -07:00
Volker E 75d8b4c112 Replace deprecated OOUI 'find' icon with 'articleSearch' of 'content' pack
Depends-on: I41c3d5502ff58f72bf7441811eaf17702468469b
Bug: T183645
Change-Id: I0535b667084771ecff3a4c0e14616fc9ee586895
2018-04-02 14:26:48 -07:00
jenkins-bot 54be8e3e2b Merge "Use OOUI icons" 2018-03-24 17:47:16 +00:00
Ed Sanders 819c6e1c82 Use OOUI icons
* Use upstream icons where available
* Move extra icons into a ResourceLoaderImageModule

Depends-On: I3e6f65f6f290778d3fbfa22f5d212c26fee12a86
Change-Id: I61cd750613922e58cec18a2886609f20e73f4a61
2018-03-23 22:51:35 +00:00
jenkins-bot 736eb68e21 Merge "Remove browser support comments" 2018-03-21 23:40:07 +00:00
Ed Sanders af94c2b052 Remove browser support comments
* "Tested with" should be assumed to be Grade A browsers
* "Browsers with issues" are all no longer supported

Change-Id: I942ed087636ad8e5f74cd131132909e7434bd957
2018-03-21 23:18:27 +00:00
Ed Sanders d278279abd Remove comment about resolved upstream issue
Change-Id: Ia92bb37bca7613049d9f3cd3601b78864c303d48
2018-03-21 23:18:23 +00:00
Ed Sanders 3d8950e7b7 Remove unused browser matrix
Since 84926bbd33, WikiEditor doesn't check browser support (because all
supported browsers by MediaWiki exceed these requirements).

Change-Id: I778dcfa75bb0b8a5a530c164e5b908b213d59afe
2018-02-13 19:13:27 +00:00
jenkins-bot d2b0b100f4 Merge "Use correct directionality for nested inputs (e.g. find & replace)" 2018-02-02 18:41:05 +00:00
Ed Sanders c56ec08a14 Use correct directionality for nested inputs (e.g. find & replace)
Bug: T186329
Change-Id: I08cb77aa45378dd21cc2176205d3eaad84469db1
2018-02-02 16:14:21 +00:00
James D. Forrester 85536550c3 Remove reference to mw-editButtons-pipe-separator, now removed from MW
Change-Id: Ia214c25b1ca65f6998da9de0949034829d9959d5
2018-01-10 14:29:04 -08:00
Ed Sanders 14df929c95 Match font and size to other source editors
All of our other source editors (2003/06/10/17) use the
editfont classes.

Change-Id: Ic9f31eadaefba1af0c1d75171a46218abbd8bc88
2018-01-04 12:33:48 +00:00
James D. Forrester 7629004d05 build: Bump various devDependencies to latest
eslint-config-wikimedia   0.4.0  →   0.5.0
 grunt-banana-checker      0.5.0  →   0.6.0
 grunt-eslint             19.0.0  →  20.1.0
 grunt-stylelint           0.6.0  →   0.8.0

Change-Id: Ia01949112243c5a496896c0a3a5eda261e0f66bd
2017-10-25 10:54:00 -07:00
Ed Sanders bbe14dbc2b Remove deprecated methods
Change-Id: Ib81592b4a13528a5ecf30d8a5cebbacae20be189
Depends-On: I3b900116ce2dc44338451c07ecdc419bad82014b
2017-10-12 16:03:54 +01:00
James D. Forrester dd8daf7d22 Hide MediaWiki's "Edit help" links which aren't relevant to non-wikitext content
Copied from WikiEditor.

Bug: T173715
Change-Id: If3234240ec8530dafd6cf0faaa2fba31e09e1a89
2017-08-28 14:08:23 +00:00
Paladox 628e0a84ab Update ace to 06.08.2017
Adds support for CSS media queries

Bug: T167686
Bug: T170999
Change-Id: I553191a9b7ac9ce026a40ef9c317bb1171ec6fc1
2017-08-07 00:08:29 +00:00
Ed Sanders 3b4ffe089f build: Update eslint to 0.4.0 and make pass
Change-Id: I764892179b136b8a4ae6940611ba8b4ecb672957
2017-05-04 21:09:35 +00:00
Brad Jorsch fe072480d3 Check for numeric 0 when checking 'usecodeeditor' pref in JS
A recent core change caused zero-valued preferences to start being
returned as numeric 0 rather than string 0. See the linked bug for
details.

Bug: T161875
Change-Id: I183fd9944e65041b0a330725c41fec2b59ca8379
2017-03-31 19:57:08 +00:00
Volker E e90acf0ab4 Align colors to WikimediaUI color palette
Aligning colors to overhauled color palette, ensuring WCAG level AA
conformance. Also removing unnecessary `xmlns:xlink` where applicable.

Bug: T160602
Change-Id: I958d1868cd5ff80226af566dfe34885f1932b16e
2017-03-15 19:31:55 -07:00
Ed Sanders 7148dfcf3f Use OOUI for prompt dialog
Depends on latest OOUI, and therefore MW 1.29.

Change-Id: I91594f534a2dca657785357a1dcb39e86d072bac
2017-01-09 15:39:27 -08:00
Fomafix 84be29b197 Replace $( document ).ready(...) by $(...)
In jQuery 3 $(document).ready(...) is deprecated.
https://jquery.com/upgrade-guide/3.0/#deprecated-document-ready-handlers-other-than-jquery-function

Change-Id: Id8cfdfa74c1789db1b24c39c16e51c7a0c408f11
2017-01-05 23:03:28 +01:00
Ed Sanders 6042898fcf Use OOUI for confirm dialog
Would be nice to do this for the goto line prompt,
but such a OO.ui.prompt doesn't exist yet.

Change-Id: I6b24e51b5b106ece80e265ff5417878f108619b7
2016-12-24 22:49:21 +00:00
Ed Sanders 1818ed4bea Add missing i18n for 'go to line' prompt
Change-Id: If4f7c243f23fc809c95cf671d5b47ec978a9fdb9
2016-12-09 13:49:46 +00:00
Ed Sanders 7fddf35aa8 build: Remove jshint/jscs, add eslint/stylelint
Change-Id: I4304ca95de7dd395676f40bcbb35a447c039ba21
2016-12-09 13:31:08 +00:00
Derk-Jan Hartman 07b24bb9f0 Remove inline CodeEditor for <syntaxhighlight>
This was an unfinished module to enable the CodeEditor to do inline
editing of <syntaxhighlight> blocks. It was never finished and I think
that with the VE and WE 2017 work, it likely will never be finished
either. For that reason, it is better to remove it altogether.

Change-Id: I83714188a53d2ca6bb7bf0dc6d0c89b7fb45a47a
2016-11-14 23:47:28 +01:00
Derk-Jan Hartman c9d4d7663e Simplify modeloading
Analogous to I82d278920695be12aa80a79548abf8b8ce5445fd, make sure that
we can lazy load any language that Ace supports. Not because we need
it, but because it's the nicer way to do it.

Change-Id: I19b8a31041814ac1273d62a24b5ed622fd91a7a8
2016-10-21 14:13:26 +02:00
Derk-Jan Hartman 46d76471e1 Use slice instead of substring per code conventions
Change-Id: Id9b08270c377f2b31486dbdb9492b77860f436e7
2016-09-26 21:36:53 +02:00
Derk-Jan Hartman c158ae5602 Update Ace and use scoped require / define
This brings Ace to upstream commit
4a55188fdb0eee9e2d3854f175e67408a1e47655

Bug: T127643
Change-Id: I7699e842d7b561b8a35cf7a4ea048f4126eaf856
2016-03-14 00:26:27 +01:00
jenkins-bot e10ed30111 Merge "Replace toolbar with OOUI/OOUI-style SVGs" 2016-02-29 23:33:18 +00:00
Ed Sanders b5312f1d4c Replace toolbar with OOUI/OOUI-style SVGs
* Use resource loader embedding for better performance
  (uses a slightly hacky method to achieve this, the only
  alternative would be to fix the WikiEditor API, but that
  would introduce a version dependency)
* Use SVGs from OOUI where available or create new ones where not.
  These are used and available under the OOjs UI MIT licence.
* Provide PNG fallbacks using LESS mixin
* Remove unused icons

Change-Id: If38d51d24958716e2617c4cb515e7c0575cdfeba
2016-02-29 13:00:15 -08:00
Ed Sanders 41e9cee298 GotoLine: Don't throw an exception if the user cancels the prompt
Change-Id: I540ba492cf3acda01ad61800561cda0276f36c76
2016-02-27 22:39:39 +00:00
jenkins-bot 0a7dc634fc Merge "Adapt toolbar icon change to change 19789d76 in WikiEditor" 2016-02-23 22:01:27 +00:00
Fomafix ecfc6514d3 Remove check for existence of mw.hook
mw.hook was introduced with 2e970257 in MediaWiki core for REL 1.22.

Change-Id: Ib81ba150c4056be19ede2145308489d0b286aea0
2016-01-29 12:32:14 +00:00
Fomafix d4a5b7eddf Adapt toolbar icon change to change 19789d76 in WikiEditor
Bug: T125201
Change-Id: I58c1d246d3fbb8031e3be482f349a0538c44152c
2016-01-29 11:07:47 +00:00
jenkins-bot 74e4cc383f Merge "Abort previous unfinished API request before sending new request" 2016-01-27 20:57:22 +00:00
Fomafix 135716727d Abort previous unfinished API request before sending new request
This change requires 81171ab3 from core included in MediaWiki 1.27.

Change-Id: I8dec32bf49e412510cf5d98f2f946bfd337f47a1
2016-01-27 11:07:38 +00:00