wikimedia/mediawiki-extensions-CiteThisPage
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/CiteThisPage synced 2024-11-28 01:10:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix regression -- don't forbid all names which contain integers, but rather those which are them.

Browse source 
Note that that's still a bad check probably; the ID issue is that a digit isn't a valid first char.
This commit is contained in:
Brion Vibber 2007-12-27 22:18:40 +00:00
parent 35147ec2bb
commit 57a761acb5
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Cite.php
View file

@ -159,7 +159,7 @@ function wfCite() {
return $this->error( 'cite_error_ref_no_key' ); return $this->error( 'cite_error_ref_no_key' );
} }
if( preg_match( '/[0-9]+/', $key ) ) { if( preg_match( '/^[0-9]+$/', $key ) ) {
# Numeric names mess up the resulting id's, potentially produ- # Numeric names mess up the resulting id's, potentially produ-
# cing duplicate id's in the XHTML. The Right Thing To Do # cing duplicate id's in the XHTML. The Right Thing To Do
# would be to mangle them, but it's not really high-priority # would be to mangle them, but it's not really high-priority