mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite
synced 2024-11-24 06:54:00 +00:00
fa77ef25bd
This CSS exists since I2ab47e7 from August 2014. The original idea was to dim the default "General references" when you edit a <ref> or <references> list in VisualEditor. Steps to reproduce: * Start VisualEditor. * Edit a <ref> or <references> list. * Edit the group. * You will see the dimmed text "General references". This is not the CSS in this patch, but the default styling for OOUI placeholders. * Open the dropdown. The list will show a "General references" item. It's not dimmed. This is where the CSS was meant to be. The CSS class name in the OOUI mixin was actually changed from "oo-ui-flaggableElement-…" to "oo-ui-flaggedElement-…" via I1abecd8, just a few days later. In addition the selector wouldn't work anyway for other reasons. The dropdown is not inside the `.ve-ui-mwReferenceGroupInputWidget` container any more but placed outside by the OOUI window manager. And the selector's specifity is to low, at least since Ic57b3ff. I argue it's not worth fixing it. Nobody missed it for 10 years. Light gray text would be illegible anyway on the light gray/light blue backgrounds used in the dropdown menu. Let's consider it dead code and just remove it. The class name doesn't appear anywhere else (any more): https://codesearch.wmcloud.org/search/?q=flaggableElement Change-Id: Ia802303737ba35cd4b14fae924b7227472f905fd |
||
|---|---|---|
| .. | ||
| i18n | ||
| images | ||
| tests | ||
| .eslintrc.json | ||
| ve.ce.MWReferenceNode.js | ||
| ve.ce.MWReferenceNode.less | ||
| ve.ce.MWReferencesListNode.js | ||
| ve.ce.MWReferencesListNode.less | ||
| ve.dm.MWReferenceModel.js | ||
| ve.dm.MWReferenceNode.js | ||
| ve.dm.MWReferencesListNode.js | ||
| ve.ui.MWCitationAction.js | ||
| ve.ui.MWCitationContextItem.js | ||
| ve.ui.MWCitationDialog.js | ||
| ve.ui.MWCitationDialogTool.js | ||
| ve.ui.MWCitationDialogTool.less | ||
| ve.ui.MWCitationNeededContextItem.js | ||
| ve.ui.MWReference.init.js | ||
| ve.ui.MWReferenceContextItem.js | ||
| ve.ui.MWReferenceContextItem.less | ||
| ve.ui.MWReferenceDialog.js | ||
| ve.ui.MWReferenceDialog.less | ||
| ve.ui.MWReferenceDialogTool.js | ||
| ve.ui.MWReferenceGroupInputWidget.js | ||
| ve.ui.MWReferenceResultWidget.js | ||
| ve.ui.MWReferenceResultWidget.less | ||
| ve.ui.MWReferenceSearchWidget.js | ||
| ve.ui.MWReferenceSearchWidget.less | ||
| ve.ui.MWReferencesListCommand.js | ||
| ve.ui.MWReferencesListContextItem.js | ||
| ve.ui.MWReferencesListDialog.js | ||
| ve.ui.MWUseExistingReferenceCommand.js | ||