mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Cite
synced 2024-12-02 18:46:18 +00:00
f94b400474
1. Most existing CiteTests can be unit tests. They run so much faster this way. 2. I modified some test cases to cover all trim() in the code. 3. The strict type hint in CiteHooks is removed because the parameter is not used. Having a hard type hint for what is effectively dead code makes the code more brittle for changes done outside of this codebase. Change-Id: I1bff1d6e02d9ef17d5e6b66aeec3ee42bba99cf4
85 lines
2.5 KiB
PHP
85 lines
2.5 KiB
PHP
<?php
|
|
|
|
namespace Cite\Tests\Unit;
|
|
|
|
use Cite;
|
|
use Wikimedia\TestingAccessWrapper;
|
|
|
|
/**
|
|
* @coversDefaultClass \Cite
|
|
*/
|
|
class CiteTest extends \MediaWikiUnitTestCase {
|
|
|
|
protected function setUp() : void {
|
|
global $wgCiteBookReferencing, $wgFragmentMode;
|
|
|
|
parent::setUp();
|
|
$wgCiteBookReferencing = true;
|
|
$wgFragmentMode = [ 'html5' ];
|
|
}
|
|
|
|
/**
|
|
* @covers ::refArg
|
|
* @dataProvider provideRefAttributes
|
|
*/
|
|
public function testRefArg( array $attributes, array $expected ) {
|
|
/** @var Cite $cite */
|
|
$cite = TestingAccessWrapper::newFromObject( new Cite() );
|
|
$this->assertSame( $expected, $cite->refArg( $attributes ) );
|
|
}
|
|
|
|
public function provideRefAttributes() {
|
|
return [
|
|
[ [], [ null, null, false, null, null ] ],
|
|
|
|
// One attribute only
|
|
[ [ 'dir' => 'invalid' ], [ null, null, false, '', null ] ],
|
|
[ [ 'dir' => 'rtl' ], [ null, null, false, ' class="mw-cite-dir-rtl"', null ] ],
|
|
[ [ 'follow' => ' f ' ], [ null, null, 'f', null, null ] ],
|
|
// FIXME: Unlike all other attributes, group isn't trimmed. Why?
|
|
[ [ 'group' => ' g ' ], [ null, ' g ', null, null, null ] ],
|
|
[ [ 'invalid' => 'i' ], [ false, false, false, false, false ] ],
|
|
[ [ 'invalid' => null ], [ false, false, false, false, false ] ],
|
|
[ [ 'name' => ' n ' ], [ 'n', null, null, null, null ] ],
|
|
[ [ 'name' => null ], [ false, false, false, false, false ] ],
|
|
[ [ 'extends' => ' e ' ], [ null, null, null, null, 'e' ] ],
|
|
|
|
// Pairs
|
|
[ [ 'follow' => 'f', 'name' => 'n' ], [ false, false, false, false, false ] ],
|
|
[ [ 'follow' => null, 'name' => null ], [ false, false, false, false, false ] ],
|
|
[ [ 'follow' => 'f', 'extends' => 'e' ], [ false, false, false, false, false ] ],
|
|
[ [ 'group' => 'g', 'name' => 'n' ], [ 'n', 'g', null, null, null ] ],
|
|
|
|
// Combinations of 3 or more attributes
|
|
[
|
|
[ 'group' => 'g', 'name' => 'n', 'extends' => 'e', 'dir' => 'rtl' ],
|
|
[ 'n', 'g', null, ' class="mw-cite-dir-rtl"', 'e' ]
|
|
],
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @covers ::normalizeKey
|
|
* @dataProvider provideKeyNormalizations
|
|
*/
|
|
public function testNormalizeKey( $key, $expected ) {
|
|
/** @var Cite $cite */
|
|
$cite = TestingAccessWrapper::newFromObject( new Cite() );
|
|
$this->assertSame( $expected, $cite->normalizeKey( $key ) );
|
|
}
|
|
|
|
public function provideKeyNormalizations() {
|
|
return [
|
|
[ 'a b', 'a_b' ],
|
|
[ 'a __ b', 'a_b' ],
|
|
[ ':', ':' ],
|
|
[ "\t\n", '	 ' ],
|
|
[ "'", ''' ],
|
|
[ "''", '''' ],
|
|
[ '"%&/<>?[]{|}', '"%&/<>?[]{|}' ],
|
|
[ 'ISBN', 'ISBN' ],
|
|
];
|
|
}
|
|
|
|
}
|